<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][13675] branches/12.0/src/bp-core/admin: Improve BP Directory/page panels in URLs settings tab</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://buddypress.trac.wordpress.org/changeset/13675">13675</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://buddypress.trac.wordpress.org/changeset/13675","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>imath</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2023-12-19 23:52:46 +0000 (Tue, 19 Dec 2023)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Improve BP Directory/page panels in URLs settings tab
- Adds a disabled input to inform about the directory/page permalink.
- Adds a button to open the corresponding page into a new window.
Fixes <a href="http://buddypress.trac.wordpress.org/ticket/9039">#9039</a> (branch 12.0)</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#branches120srcbpcoreadminbpcoreadminrewritesphp">branches/12.0/src/bp-core/admin/bp-core-admin-rewrites.php</a></li>
<li><a href="#branches120srcbpcoreadmincsscommonrtlcss">branches/12.0/src/bp-core/admin/css/common-rtl.css</a></li>
<li><a href="#branches120srcbpcoreadmincsscommoncss">branches/12.0/src/bp-core/admin/css/common.css</a></li>
<li><a href="#branches120srcbpcoreadminjsrewritesuijs">branches/12.0/src/bp-core/admin/js/rewrites-ui.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="branches120srcbpcoreadminbpcoreadminrewritesphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: branches/12.0/src/bp-core/admin/bp-core-admin-rewrites.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- branches/12.0/src/bp-core/admin/bp-core-admin-rewrites.php 2023-12-19 23:45:13 UTC (rev 13674)
+++ branches/12.0/src/bp-core/admin/bp-core-admin-rewrites.php 2023-12-19 23:52:46 UTC (rev 13675)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -183,6 +183,37 @@
</span><span class="cx" style="display: block; padding: 0 10px"> <input type="text" class="code" name="<?php printf( 'components[%d][post_name]', absint( $directory_data->id ) ); ?>" id="<?php echo esc_attr( sprintf( '%s-directory-slug', sanitize_key( $component_id ) ) ); ?>" value="<?php echo esc_attr( $directory_data->slug ); ?>">
</span><span class="cx" style="display: block; padding: 0 10px"> </td>
</span><span class="cx" style="display: block; padding: 0 10px"> </tr>
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <tr>
+ <th scope="row">
+ <label for="<?php echo esc_attr( sprintf( '%s-directory-url', sanitize_key( $component_id ) ) ); ?>">
+ <?php ( 'activate' === $component_id || 'register' === $component_id ) ? esc_html_e( 'Page permalink', 'buddypress' ) : esc_html_e( 'Directory permalink', 'buddypress' ); ?>
+ </label>
+ </th>
+ <td>
+ <?php
+ $url_args = array(
+ 'component_id' => $component_id,
+ );
+
+ if ( 'activate' === $component_id || 'register' === $component_id ) {
+ $url_args = array(
+ 'component_id' => 'members',
+ sprintf( 'member_%s', $component_id ) => 1,
+ );
+ }
+
+ $permalink = bp_rewrites_get_url( $url_args );
+ ?>
+ <input type="text" class="code bp-directory-url" id="<?php echo esc_attr( sprintf( '%s-directory-url', sanitize_key( $component_id ) ) ); ?>" value="<?php echo esc_url( $permalink ); ?>" disabled="disabled">
+
+ <?php if ( 'activate' !== $component_id && 'register' !== $component_id ) : ?>
+ <a href="<?php echo esc_url( $permalink ); ?>" class="button-secondary bp-open-permalink" target="_bp">
+ <?php esc_html_e( 'View', 'buddypress' ); ?> <span class="dashicons dashicons-external" aria-hidden="true"></span>
+ <span class="screen-reader-text"><?php esc_html_e( '(opens in a new tab)', 'buddypress' ); ?></span>
+ </a>
+ <?php endif; ?>
+ </td>
+ </tr>
</ins><span class="cx" style="display: block; padding: 0 10px"> </table>
</span><span class="cx" style="display: block; padding: 0 10px"> </div>
</span><span class="cx" style="display: block; padding: 0 10px"> </div>
</span></span></pre></div>
<a id="branches120srcbpcoreadmincsscommonrtlcss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: branches/12.0/src/bp-core/admin/css/common-rtl.css</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- branches/12.0/src/bp-core/admin/css/common-rtl.css 2023-12-19 23:45:13 UTC (rev 13674)
+++ branches/12.0/src/bp-core/admin/css/common-rtl.css 2023-12-19 23:52:46 UTC (rev 13675)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -15,8 +15,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 2.0 Dashicons
</span><span class="cx" style="display: block; padding: 0 10px"> 2.1 Top level menus
</span><span class="cx" style="display: block; padding: 0 10px"> 2.2 Settings - Components
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 2.3 Tools
- 2.4 Tooltips
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 2.3 Settings - URls
+ 2.4 Tools
+ 2.5 Tooltips
</ins><span class="cx" style="display: block; padding: 0 10px"> 3.0 Users
</span><span class="cx" style="display: block; padding: 0 10px"> 3.1 Users List
</span><span class="cx" style="display: block; padding: 0 10px"> 3.2 Site Notices
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -307,8 +308,23 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /*
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * 2.3 Tools
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * 2.3 Settings - URLs
</ins><span class="cx" style="display: block; padding: 0 10px"> */
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+.settings_page_bp-rewrites .bp-directory-url {
+ width: 80%;
+ box-shadow: 0 0 0 transparent;
+ border: 1px solid #8c8f94;
+ background-color: #fff;
+ color: #2c3338;
+}
+
+.settings_page_bp-rewrites .bp-open-permalink .dashicons {
+ vertical-align: sub;
+}
+
+/*
+ * 2.4 Tools
+ */
</ins><span class="cx" style="display: block; padding: 0 10px"> #adminmenu .toplevel_page_network-tools div.wp-menu-image:before {
</span><span class="cx" style="display: block; padding: 0 10px"> content: "";
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -330,7 +346,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /*
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * 2.4 Tooltips
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * 2.5 Tooltips
</ins><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> .bp-tooltip {
</span><span class="cx" style="display: block; padding: 0 10px"> position: relative;
</span></span></pre></div>
<a id="branches120srcbpcoreadmincsscommoncss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: branches/12.0/src/bp-core/admin/css/common.css</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- branches/12.0/src/bp-core/admin/css/common.css 2023-12-19 23:45:13 UTC (rev 13674)
+++ branches/12.0/src/bp-core/admin/css/common.css 2023-12-19 23:52:46 UTC (rev 13675)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -15,8 +15,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 2.0 Dashicons
</span><span class="cx" style="display: block; padding: 0 10px"> 2.1 Top level menus
</span><span class="cx" style="display: block; padding: 0 10px"> 2.2 Settings - Components
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 2.3 Tools
- 2.4 Tooltips
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 2.3 Settings - URls
+ 2.4 Tools
+ 2.5 Tooltips
</ins><span class="cx" style="display: block; padding: 0 10px"> 3.0 Users
</span><span class="cx" style="display: block; padding: 0 10px"> 3.1 Users List
</span><span class="cx" style="display: block; padding: 0 10px"> 3.2 Site Notices
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -307,8 +308,23 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /*
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * 2.3 Tools
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * 2.3 Settings - URLs
</ins><span class="cx" style="display: block; padding: 0 10px"> */
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+.settings_page_bp-rewrites .bp-directory-url {
+ width: 80%;
+ box-shadow: 0 0 0 transparent;
+ border: 1px solid #8c8f94;
+ background-color: #fff;
+ color: #2c3338;
+}
+
+.settings_page_bp-rewrites .bp-open-permalink .dashicons {
+ vertical-align: sub;
+}
+
+/*
+ * 2.4 Tools
+ */
</ins><span class="cx" style="display: block; padding: 0 10px"> #adminmenu .toplevel_page_network-tools div.wp-menu-image:before {
</span><span class="cx" style="display: block; padding: 0 10px"> content: "";
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -330,7 +346,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /*
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * 2.4 Tooltips
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * 2.5 Tooltips
</ins><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> .bp-tooltip {
</span><span class="cx" style="display: block; padding: 0 10px"> position: relative;
</span></span></pre></div>
<a id="branches120srcbpcoreadminjsrewritesuijs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: branches/12.0/src/bp-core/admin/js/rewrites-ui.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- branches/12.0/src/bp-core/admin/js/rewrites-ui.js 2023-12-19 23:45:13 UTC (rev 13674)
+++ branches/12.0/src/bp-core/admin/js/rewrites-ui.js 2023-12-19 23:52:46 UTC (rev 13675)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -4,9 +4,9 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> accordions.forEach( function( accordion ) {
</span><span class="cx" style="display: block; padding: 0 10px"> accordion.addEventListener( 'click', function( e ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- e.preventDefault();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( e.target && e.target.matches( 'button.health-check-accordion-trigger' ) ) {
+ e.preventDefault();
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( e.target && e.target.matches( 'button.health-check-accordion-trigger' ) ) {
</del><span class="cx" style="display: block; padding: 0 10px"> var isExpanded = ( 'true' === e.target.getAttribute( 'aria-expanded' ) ),
</span><span class="cx" style="display: block; padding: 0 10px"> panel = document.querySelector( '#' + e.target.getAttribute( 'aria-controls' ) );
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre>
</div>
</div>
</body>
</html>