<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][13636] trunk: Improve the favorites management using the WP Meta API</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://buddypress.trac.wordpress.org/changeset/13636">13636</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://buddypress.trac.wordpress.org/changeset/13636","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>imath</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2023-11-07 22:41:34 +0000 (Tue, 07 Nov 2023)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Improve the favorites management using the WP Meta API
- Introduce `bp_activity_register_user_favorites_meta()` to register the user meta and define sanitization callback.
- Introduce `bp_activity_sanitize_user_favorites_meta()` to do the sanitization job.
- Improve Ajax callbacks about favoriting/unfavoriting activities in template packs.
Props emaralive, dcavins
Fixes <a href="http://buddypress.trac.wordpress.org/ticket/9021">#9021</a>
Closes https://github.com/buddypress/buddypress/pull/189</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcbpactivitybpactivityfiltersphp">trunk/src/bp-activity/bp-activity-filters.php</a></li>
<li><a href="#trunksrcbpactivitybpactivityfunctionsphp">trunk/src/bp-activity/bp-activity-functions.php</a></li>
<li><a href="#trunksrcbptemplatesbplegacybuddypressfunctionsphp">trunk/src/bp-templates/bp-legacy/buddypress-functions.php</a></li>
<li><a href="#trunksrcbptemplatesbpnouveauincludesactivityajaxphp">trunk/src/bp-templates/bp-nouveau/includes/activity/ajax.php</a></li>
<li><a href="#trunktestsphpunittestcasesactivityfunctionsphp">trunk/tests/phpunit/testcases/activity/functions.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcbpactivitybpactivityfiltersphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-activity/bp-activity-filters.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-activity/bp-activity-filters.php 2023-11-07 04:15:44 UTC (rev 13635)
+++ trunk/src/bp-activity/bp-activity-filters.php 2023-11-07 22:41:34 UTC (rev 13636)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -103,8 +103,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> add_filter( 'bp_get_activity_content_body', 'bp_activity_truncate_entry', 5 );
</span><span class="cx" style="display: block; padding: 0 10px"> add_filter( 'bp_get_activity_content', 'bp_activity_truncate_entry', 5 );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-add_filter( 'bp_get_total_favorite_count_for_user', 'bp_core_number_format' );
-add_filter( 'bp_get_total_mention_count_for_user', 'bp_core_number_format' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+add_filter( 'bp_activity_get_user_favorites', 'bp_activity_sanitize_user_favorites_meta' );
+add_filter( 'bp_get_total_favorite_count_for_user', 'bp_core_number_format' );
+add_filter( 'bp_get_total_mention_count_for_user', 'bp_core_number_format' );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> add_filter( 'bp_activity_get_embed_excerpt', 'bp_activity_embed_excerpt_onclick_location_filter', 9 );
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunksrcbpactivitybpactivityfunctionsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-activity/bp-activity-functions.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-activity/bp-activity-functions.php 2023-11-07 04:15:44 UTC (rev 13635)
+++ trunk/src/bp-activity/bp-activity-functions.php 2023-11-07 22:41:34 UTC (rev 13636)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1014,6 +1014,39 @@
</span><span class="cx" style="display: block; padding: 0 10px"> /** Favorites ****************************************************************/
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * Sanitize callback for the User's favorites meta.
+ *
+ * @since 12.0.0
+ *
+ * @param array $value The list of favorited activity IDs.
+ * @return array The sanitized list of favorited activity IDs.
+ */
+function bp_activity_sanitize_user_favorites_meta( $value = array() ) {
+ return array_filter( wp_parse_id_list( $value ) );
+}
+
+/**
+ * Use WordPress Meta API to deal with favorites meta properties and sanitization.
+ *
+ * @since 12.0.0
+ */
+function bp_activity_register_user_favorites_meta() {
+ register_meta(
+ 'user',
+ 'bp_favorite_activities',
+ array(
+ 'single' => true,
+ 'type' => 'array',
+ 'description' => __( 'The list of Activity IDs a user favorited.', 'buddypress' ),
+ 'show_in_rest' => false, // We're not showing this meta into the WP users REST endpoint.
+ 'sanitize_callback' => 'bp_activity_sanitize_user_favorites_meta',
+ 'default' => array(),
+ )
+ );
+}
+add_action( 'bp_init', 'bp_activity_register_user_favorites_meta' );
+
+/**
</ins><span class="cx" style="display: block; padding: 0 10px"> * Get a users favorite activity stream items.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 1.2.0
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1051,19 +1084,27 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @return bool True on success, false on failure.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function bp_activity_add_user_favorite( $activity_id, $user_id = 0 ) {
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Cast as an integer to make sure we're only saving integers into the user's meta.
+ if ( ! empty( $activity_id ) ) {
+ $activity_id = (int) $activity_id;
+ } else {
+ $activity_id = 0;
+ }
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( ! $activity_id ) {
+ return false;
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> // Fallback to logged in user if no user_id is passed.
</span><span class="cx" style="display: block; padding: 0 10px"> if ( empty( $user_id ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $user_id = bp_loggedin_user_id();
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $my_favs = bp_get_user_meta( $user_id, 'bp_favorite_activities', true );
- if ( empty( $my_favs ) || ! is_array( $my_favs ) ) {
- $my_favs = array();
- }
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Get user's existing favorites.
+ $my_favs = bp_activity_get_user_favorites( $user_id );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Bail if the user has already favorited this activity item.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( in_array( $activity_id, $my_favs ) ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( in_array( $activity_id, $my_favs, true ) ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> return false;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1071,8 +1112,12 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $my_favs[] = $activity_id;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Update the total number of users who have favorited this activity.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $fav_count = bp_activity_get_meta( $activity_id, 'favorite_count' );
- $fav_count = !empty( $fav_count ) ? (int) $fav_count + 1 : 1;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $fav_count = (int) bp_activity_get_meta( $activity_id, 'favorite_count' );
+ if ( ! empty( $fav_count ) ) {
+ $fav_count += 1;
+ } else {
+ $fav_count = 1;
+ }
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Update user meta.
</span><span class="cx" style="display: block; padding: 0 10px"> bp_update_user_meta( $user_id, 'bp_favorite_activities', $my_favs );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1126,8 +1171,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $user_id = bp_loggedin_user_id();
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $my_favs = bp_get_user_meta( $user_id, 'bp_favorite_activities', true );
- $my_favs = array_flip( (array) $my_favs );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $my_favs = bp_activity_get_user_favorites( $user_id );
+ $my_favs = array_flip( $my_favs );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Bail if the user has not previously favorited the item.
</span><span class="cx" style="display: block; padding: 0 10px"> if ( ! isset( $my_favs[ $activity_id ] ) ) {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1135,7 +1180,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Remove the fav from the user's favs.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- unset( $my_favs[$activity_id] );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ unset( $my_favs[ $activity_id ] );
</ins><span class="cx" style="display: block; padding: 0 10px"> $my_favs = array_unique( array_flip( $my_favs ) );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Update the total number of users who have favorited this activity.
</span></span></pre></div>
<a id="trunksrcbptemplatesbplegacybuddypressfunctionsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-templates/bp-legacy/buddypress-functions.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-templates/bp-legacy/buddypress-functions.php 2023-11-07 04:15:44 UTC (rev 13635)
+++ trunk/src/bp-templates/bp-legacy/buddypress-functions.php 2023-11-07 22:41:34 UTC (rev 13636)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1277,14 +1277,15 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $activity_id = (int) $_POST['id'];
</span><span class="cx" style="display: block; padding: 0 10px"> $activity_item = new BP_Activity_Activity( $activity_id );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( ! bp_activity_user_can_read( $activity_item, bp_loggedin_user_id() ) ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( empty( $activity_item->id ) || ! bp_activity_user_can_read( $activity_item, bp_loggedin_user_id() ) ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> return;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( bp_activity_add_user_favorite( $_POST['id'] ) )
- _e( 'Remove Favorite', 'buddypress' );
- else
- _e( 'Favorite', 'buddypress' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( bp_activity_add_user_favorite( $activity_id ) ) {
+ esc_html_e( 'Remove Favorite', 'buddypress' );
+ } else {
+ esc_html_e( 'Favorite', 'buddypress' );
+ }
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> exit;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1311,11 +1312,14 @@
</span><span class="cx" style="display: block; padding: 0 10px"> return;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( bp_activity_remove_user_favorite( $_POST['id'] ) )
- _e( 'Favorite', 'buddypress' );
- else
- _e( 'Remove Favorite', 'buddypress' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $activity_id = (int) $_POST['id'];
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( bp_activity_remove_user_favorite( $activity_id ) ) {
+ esc_html_e( 'Favorite', 'buddypress' );
+ } else {
+ esc_html_e( 'Remove Favorite', 'buddypress' );
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> exit;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunksrcbptemplatesbpnouveauincludesactivityajaxphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-templates/bp-nouveau/includes/activity/ajax.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-templates/bp-nouveau/includes/activity/ajax.php 2023-11-07 04:15:44 UTC (rev 13635)
+++ trunk/src/bp-templates/bp-nouveau/includes/activity/ajax.php 2023-11-07 22:41:34 UTC (rev 13636)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -103,11 +103,11 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $activity_id = (int) $_POST['id'];
</span><span class="cx" style="display: block; padding: 0 10px"> $activity_item = new BP_Activity_Activity( $activity_id );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( ! bp_activity_user_can_read( $activity_item, bp_loggedin_user_id() ) ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( empty( $activity_item->id ) || ! bp_activity_user_can_read( $activity_item, bp_loggedin_user_id() ) ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> wp_send_json_error();
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( bp_activity_add_user_favorite( $_POST['id'] ) ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( bp_activity_add_user_favorite( $activity_id ) ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> $response = array( 'content' => __( 'Remove Favorite', 'buddypress' ) );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( ! bp_is_user() ) {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -149,7 +149,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> wp_send_json_error();
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( bp_activity_remove_user_favorite( $_POST['id'] ) ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $activity_id = (int) $_POST['id'];
+
+ if ( bp_activity_remove_user_favorite( $activity_id ) ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> $response = array( 'content' => __( 'Mark as Favorite', 'buddypress' ) );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $fav_count = (int) bp_get_total_favorite_count_for_user( bp_loggedin_user_id() );
</span></span></pre></div>
<a id="trunktestsphpunittestcasesactivityfunctionsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/testcases/activity/functions.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/testcases/activity/functions.php 2023-11-07 04:15:44 UTC (rev 13635)
+++ trunk/tests/phpunit/testcases/activity/functions.php 2023-11-07 22:41:34 UTC (rev 13636)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1466,6 +1466,33 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @group favorites
+ * @group bp_activity_add_user_favorite
+ */
+ public function test_add_user_favorite_not_an_activity_id() {
+ $u1 = self::factory()->user->create();
+ $a = self::factory()->activity->create();
+
+ // bp_activity_add_user_favorite() requires a logged-in user.
+ $current_user = bp_loggedin_user_id();
+ $this->set_current_user( $u1 );
+
+ // Only favorite for user 1
+ bp_activity_add_user_favorite( $a, $u1 );
+ $user_favorites = array( $a );
+ $this->assertEquals( $user_favorites, bp_activity_get_user_favorites( $u1 ) );
+
+ // Adds something that is not an activity id.
+ bp_activity_add_user_favorite( 'not_an_activity_id', $u1 );
+
+ // The above shouldn't be added.
+ $this->assertEquals( $user_favorites, bp_activity_get_user_favorites( $u1 ) );
+ $this->assertEquals( 1, bp_activity_get_meta( $a, 'favorite_count' ) );
+
+ $this->set_current_user( $current_user );
+ }
+
+ /**
</ins><span class="cx" style="display: block; padding: 0 10px"> * @group bp_activity_post_update
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function test_bp_activity_post_update_empty_content() {
</span></span></pre>
</div>
</div>
</body>
</html>