<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][13632] trunk: Prevent potential 3rd party plugins/themes issues for new installs</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://buddypress.trac.wordpress.org/changeset/13632">13632</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://buddypress.trac.wordpress.org/changeset/13632","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>imath</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2023-11-05 07:32:10 +0000 (Sun, 05 Nov 2023)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Prevent potential 3rd party plugins/themes issues for new installs
- Load 12.0 deprecated functions even in new installs.
- Add an Admin Notification to inform about BP Classic: the BP backwards compatibility Add-on.
Props emaralive, dcavins
Fixes <a href="http://buddypress.trac.wordpress.org/ticket/9015">#9015</a>
Closes https://github.com/buddypress/buddypress/pull/183</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcbpcorebpcorefunctionsphp">trunk/src/bp-core/bp-core-functions.php</a></li>
<li><a href="#trunksrcbpcorebpcoreupdatephp">trunk/src/bp-core/bp-core-update.php</a></li>
<li><a href="#trunktestsphpunittestcasescorefunctionsphp">trunk/tests/phpunit/testcases/core/functions.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcbpcorebpcorefunctionsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-core/bp-core-functions.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-core/bp-core-functions.php 2023-11-03 04:37:33 UTC (rev 13631)
+++ trunk/src/bp-core/bp-core-functions.php 2023-11-05 07:32:10 UTC (rev 13632)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -4885,7 +4885,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $current_version = (float) bp_get_version();
</span><span class="cx" style="display: block; padding: 0 10px"> $load_latest_deprecated = $initial_version < $current_version;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // We don't load deprecated functions for new installs.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // New installs.
</ins><span class="cx" style="display: block; padding: 0 10px"> if ( ! $load_latest_deprecated ) {
</span><span class="cx" style="display: block; padding: 0 10px"> // Run some additional checks if PHPUnit is running.
</span><span class="cx" style="display: block; padding: 0 10px"> if ( defined( 'BP_TESTS_DIR' ) ) {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -4904,7 +4904,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> return false;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- return array();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+ // Only load 12.0 deprecated functions.
+ return array( '12.0' );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Try to get the first major version that was in used when BuddyPress was fist installed.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -5119,7 +5121,23 @@
</span><span class="cx" style="display: block; padding: 0 10px"> '<strong>' . __( 'You still use a BP Legacy Widget.', 'buddypress' ) . '</strong><br><br>' .
</span><span class="cx" style="display: block; padding: 0 10px"> __( 'If any of the above items are true, we strongly advise you to install and activate the Classic Add-on before updating to BuddyPress 12.0.0.', 'buddypress' ),
</span><span class="cx" style="display: block; padding: 0 10px"> 'version' => 11.4,
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- )
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ ),
+ 'bp120-new-installs-warning' => (object) array(
+ 'id' => 'bp120-new-installs-warning',
+ 'href' => add_query_arg(
+ array(
+ 'tab' => 'bp-add-ons',
+ 'show' => 'bp-classic',
+ 'n' => 'bp120-new-installs-warning'
+ ),
+ bp_get_admin_url( 'plugin-install.php' )
+ ),
+ 'text' => __( 'Get The BP Classic Add-on', 'buddypress' ),
+ 'title' => __( 'Thank you for installing BuddyPress 12.0!', 'buddypress' ),
+ 'content' => __( 'BuddyPress 12.0 introduces major core changes, overhauling the way that BuddyPress builds and parses URLs.', 'buddypress' ) . '<br><br>' .
+ __( 'If you find that your site is not working correctly with the new version, try installing the new BP Classic Add-on that adds backwards compatibility for plugins and themes that have not yet been updated to work with BuddyPress 12.0.', 'buddypress' ),
+ 'version' => 12.0,
+ ),
</ins><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Only keep unread notifications.
</span></span></pre></div>
<a id="trunksrcbpcorebpcoreupdatephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-core/bp-core-update.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-core/bp-core-update.php 2023-11-03 04:37:33 UTC (rev 13631)
+++ trunk/src/bp-core/bp-core-update.php 2023-11-05 07:32:10 UTC (rev 13632)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -203,12 +203,20 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $switched_to_root_blog = true;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Install BP schema and activate only Activity and XProfile.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Install BP schema and activate default components.
</ins><span class="cx" style="display: block; padding: 0 10px"> if ( bp_is_install() ) {
</span><span class="cx" style="display: block; padding: 0 10px"> // Set the first BP major version the plugin was installed.
</span><span class="cx" style="display: block; padding: 0 10px"> bp_update_option( '_bp_initial_major_version', bp_get_major_version() );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Apply schema and set Activity and XProfile components as active.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Add an unread Admin notification.
+ if ( 13422 === bp_get_db_version() ) {
+ $unread = bp_core_get_unread_admin_notifications();
+ $unread[] = 'bp120-new-installs-warning';
+
+ bp_update_option( 'bp_unread_admin_notifications', $unread );
+ }
+
+ // Apply schema and set default components as active.
</ins><span class="cx" style="display: block; padding: 0 10px"> bp_core_install( $default_components );
</span><span class="cx" style="display: block; padding: 0 10px"> bp_update_option( 'bp-active-components', $default_components );
</span><span class="cx" style="display: block; padding: 0 10px"> bp_core_add_page_mappings( $default_components, 'delete' );
</span></span></pre></div>
<a id="trunktestsphpunittestcasescorefunctionsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/testcases/core/functions.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/testcases/core/functions.php 2023-11-03 04:37:33 UTC (rev 13631)
+++ trunk/tests/phpunit/testcases/core/functions.php 2023-11-05 07:32:10 UTC (rev 13632)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -874,8 +874,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $current_version = (float) bp_get_version();
</span><span class="cx" style="display: block; padding: 0 10px"> $versions = bp_get_deprecated_functions_versions();
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // When current version is the initial version, we shouldn't load deprecated functions files.
- $this->assertTrue( is_array( $versions ) && ! $versions, 'Please check the list of `$deprecated_functions_versions` in `bp_get_deprecated_functions_versions()`. There should be one for each file of the `/src/bp-core/deprecated` directory.' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // When current version is the initial version, we should only load 12.0 deprecated functions file.
+ $this->assertSame( $versions, array( '12.0' ), 'Please check the list of `$deprecated_functions_versions` in `bp_get_deprecated_functions_versions()`. There should be one for each file of the `/src/bp-core/deprecated` directory.' );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // We should load the 2 lasts deprecated functions files.
</span><span class="cx" style="display: block; padding: 0 10px"> $this->bp_initial_version = '8.0';
</span></span></pre>
</div>
</div>
</body>
</html>