<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][13592] trunk: Clear the Groups cache incrementor after a group member removal</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://buddypress.trac.wordpress.org/changeset/13592">13592</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://buddypress.trac.wordpress.org/changeset/13592","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>imath</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2023-10-11 02:09:00 +0000 (Wed, 11 Oct 2023)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Clear the Groups cache incrementor after a group member removal
Do reset the Groups cache incrementor once the `'groups_member_after_remove'` action is fired. Although in most configs this extra action is not needed, adding it makes sure the corresponding cached results is cleared when using the Memcached plugin.
Props iandunn
Fixes <a href="http://buddypress.trac.wordpress.org/ticket/9000">#9000</a>
Closes https://github.com/buddypress/buddypress/pull/171</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcbpgroupsbpgroupscachephp">trunk/src/bp-groups/bp-groups-cache.php</a></li>
<li><a href="#trunktestsphpunittestcasesgroupscachephp">trunk/tests/phpunit/testcases/groups/cache.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcbpgroupsbpgroupscachephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-groups/bp-groups-cache.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-groups/bp-groups-cache.php 2023-10-06 04:09:15 UTC (rev 13591)
+++ trunk/src/bp-groups/bp-groups-cache.php 2023-10-11 02:09:00 UTC (rev 13592)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -325,11 +325,12 @@
</span><span class="cx" style="display: block; padding: 0 10px"> function bp_groups_reset_cache_incrementor() {
</span><span class="cx" style="display: block; padding: 0 10px"> return bp_core_reset_incrementor( 'bp_groups' );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-add_action( 'groups_group_after_save', 'bp_groups_reset_cache_incrementor' );
-add_action( 'bp_groups_delete_group', 'bp_groups_reset_cache_incrementor' );
-add_action( 'updated_group_meta', 'bp_groups_reset_cache_incrementor' );
-add_action( 'deleted_group_meta', 'bp_groups_reset_cache_incrementor' );
-add_action( 'added_group_meta', 'bp_groups_reset_cache_incrementor' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+add_action( 'groups_group_after_save', 'bp_groups_reset_cache_incrementor' );
+add_action( 'bp_groups_delete_group', 'bp_groups_reset_cache_incrementor' );
+add_action( 'updated_group_meta', 'bp_groups_reset_cache_incrementor' );
+add_action( 'deleted_group_meta', 'bp_groups_reset_cache_incrementor' );
+add_action( 'added_group_meta', 'bp_groups_reset_cache_incrementor' );
+add_action( 'groups_member_after_remove', 'bp_groups_reset_cache_incrementor' );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * Reset cache incrementor for Groups component when a group's taxonomy terms change.
</span></span></pre></div>
<a id="trunktestsphpunittestcasesgroupscachephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/testcases/groups/cache.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/testcases/groups/cache.php 2023-10-06 04:09:15 UTC (rev 13591)
+++ trunk/tests/phpunit/testcases/groups/cache.php 2023-10-11 02:09:00 UTC (rev 13592)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -5,6 +5,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @group cache
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> class BP_Tests_Group_Cache extends BP_UnitTestCase {
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
</ins><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * @group bp_groups_update_meta_cache
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -279,4 +280,47 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertEquals( 3, groups_get_total_group_count( true ) );
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertEquals( 3, BP_Groups_Group::get_total_group_count() );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+ /**
+ * @ticket BP9000
+ */
+ public function test_groups_get_groups_for_user_cache_once_left() {
+ $g = self::factory()->group->create();
+ $u = self::factory()->user->create();
+
+ groups_join_group( $g, $u );
+ $u_groups = groups_get_groups( array( 'user_id' => $u ) );
+ $u_group_ids = wp_list_pluck( $u_groups['groups'], 'id' );
+
+ $this->assertContains( $g, $u_group_ids );
+
+ groups_leave_group( $g, $u );
+ $u_groups = groups_get_groups( array( 'user_id' => $u ) );
+ $u_group_ids = wp_list_pluck( $u_groups['groups'], 'id' );
+
+ $this->assertNotContains( $g, $u_group_ids );
+ }
+
+ /**
+ * @ticket BP9000
+ */
+ public function test_groups_get_groups_for_user_cache_once_removed() {
+ $g = self::factory()->group->create();
+ $u = self::factory()->user->create();
+
+ groups_join_group( $g, $u );
+ $u_groups = groups_get_groups( array( 'user_id' => $u ) );
+ $u_group_ids = wp_list_pluck( $u_groups['groups'], 'id' );
+
+ $this->assertContains( $g, $u_group_ids );
+
+ add_filter( 'bp_is_item_admin', '__return_true' );
+ groups_remove_member( $u, $g );
+ remove_filter( 'bp_is_item_admin', '__return_true' );
+
+ $u_groups = groups_get_groups( array( 'user_id' => $u ) );
+ $u_group_ids = wp_list_pluck( $u_groups['groups'], 'id' );
+
+ $this->assertNotContains( $g, $u_group_ids );
+ }
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre>
</div>
</div>
</body>
</html>