<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][13536] trunk/src/bp-core/bp-core-update.php: Improve BuddyPress 12.0.0 upgrade tasks</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://buddypress.trac.wordpress.org/changeset/13536">13536</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://buddypress.trac.wordpress.org/changeset/13536","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>imath</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2023-07-30 07:30:39 +0000 (Sun, 30 Jul 2023)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Improve BuddyPress 12.0.0 upgrade tasks
1. Only perform the BP Rewrites API & Legacy Widgets upgrade tasks when the BP Classic plugin is not active.
2. Add an action hook in case 3rd party plugins need to perform specific tasks once BP has been updated to 12.0.0.
Fixes <a href="http://buddypress.trac.wordpress.org/ticket/8955">#8955</a>
Closes https://github.com/buddypress/buddypress/pull/145</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcbpcorebpcoreupdatephp">trunk/src/bp-core/bp-core-update.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcbpcorebpcoreupdatephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-core/bp-core-update.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-core/bp-core-update.php 2023-07-30 07:08:49 UTC (rev 13535)
+++ trunk/src/bp-core/bp-core-update.php 2023-07-30 07:30:39 UTC (rev 13536)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -801,85 +801,100 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * 12.0.0 update routine.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * - Swith directory page post type from "page" to "buddypress".
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * - Remove Legacy Widgets option.
+ * - Add the default community visibility value.
</ins><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 12.0.0
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function bp_update_to_12_0() {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $post_type = bp_core_get_directory_post_type();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /*
+ * Only perform the BP Rewrites API & Legacy Widgets upgrade tasks
+ * when the BP Classic plugin is not active.
+ */
+ if ( ! function_exists( 'bp_classic' ) ) {
+ $post_type = bp_core_get_directory_post_type();
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( 'page' !== $post_type ) {
- $directory_pages = bp_core_get_directory_pages();
- $nav_menu_item_ids = array();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( 'page' !== $post_type ) {
+ $directory_pages = bp_core_get_directory_pages();
+ $nav_menu_item_ids = array();
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Do not check post slugs nor post types.
- remove_filter( 'wp_unique_post_slug', 'bp_core_set_unique_directory_page_slug', 10 );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Do not check post slugs nor post types.
+ remove_filter( 'wp_unique_post_slug', 'bp_core_set_unique_directory_page_slug', 10 );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Update Directory pages post types.
- foreach ( $directory_pages as $directory_page ) {
- $nav_menu_item_ids[] = $directory_page->id;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Update Directory pages post types.
+ foreach ( $directory_pages as $directory_page ) {
+ $nav_menu_item_ids[] = $directory_page->id;
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Switch the post type.
- wp_update_post(
- array(
- 'ID' => $directory_page->id,
- 'post_type' => $post_type,
- 'post_status' => 'publish',
- )
- );
- }
-
- // Update nav menu items!
- $nav_menus = wp_get_nav_menus( array( 'hide_empty' => true ) );
- foreach ( $nav_menus as $nav_menu ) {
- $items = wp_get_nav_menu_items( $nav_menu->term_id );
- foreach ( $items as $item ) {
- if ( 'page' !== $item->object || ! in_array( $item->object_id, $nav_menu_item_ids, true ) ) {
- continue;
- }
-
- wp_update_nav_menu_item(
- $nav_menu->term_id,
- $item->ID,
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Switch the post type.
+ wp_update_post(
</ins><span class="cx" style="display: block; padding: 0 10px"> array(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'menu-item-db-id' => $item->db_id,
- 'menu-item-object-id' => $item->object_id,
- 'menu-item-object' => $post_type,
- 'menu-item-parent-id' => $item->menu_item_parent,
- 'menu-item-position' => $item->menu_order,
- 'menu-item-type' => 'post_type',
- 'menu-item-title' => $item->title,
- 'menu-item-url' => $item->url,
- 'menu-item-description' => $item->description,
- 'menu-item-attr-title' => $item->attr_title,
- 'menu-item-target' => $item->target,
- 'menu-item-classes' => implode( ' ', (array) $item->classes ),
- 'menu-item-xfn' => $item->xfn,
- 'menu-item-status' => 'publish',
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ 'ID' => $directory_page->id,
+ 'post_type' => $post_type,
+ 'post_status' => 'publish',
</ins><span class="cx" style="display: block; padding: 0 10px"> )
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+ // Update nav menu items!
+ $nav_menus = wp_get_nav_menus( array( 'hide_empty' => true ) );
+ foreach ( $nav_menus as $nav_menu ) {
+ $items = wp_get_nav_menu_items( $nav_menu->term_id );
+ foreach ( $items as $item ) {
+ if ( 'page' !== $item->object || ! in_array( $item->object_id, $nav_menu_item_ids, true ) ) {
+ continue;
+ }
+
+ wp_update_nav_menu_item(
+ $nav_menu->term_id,
+ $item->ID,
+ array(
+ 'menu-item-db-id' => $item->db_id,
+ 'menu-item-object-id' => $item->object_id,
+ 'menu-item-object' => $post_type,
+ 'menu-item-parent-id' => $item->menu_item_parent,
+ 'menu-item-position' => $item->menu_order,
+ 'menu-item-type' => 'post_type',
+ 'menu-item-title' => $item->title,
+ 'menu-item-url' => $item->url,
+ 'menu-item-description' => $item->description,
+ 'menu-item-attr-title' => $item->attr_title,
+ 'menu-item-target' => $item->target,
+ 'menu-item-classes' => implode( ' ', (array) $item->classes ),
+ 'menu-item-xfn' => $item->xfn,
+ 'menu-item-status' => 'publish',
+ )
+ );
+ }
+ }
+
+ // Finally make sure to rebuilt permalinks at next page load.
+ bp_delete_rewrite_rules();
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Finally make sure to rebuilt permalinks at next page load.
- bp_delete_rewrite_rules();
- }
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Widgets.
+ $widget_options = array(
+ 'widget_bp_core_login_widget',
+ 'widget_bp_core_members_widget',
+ 'widget_bp_core_whos_online_widget',
+ 'widget_bp_core_recently_active_widget',
+ 'widget_bp_groups_widget',
+ 'widget_bp_messages_sitewide_notices_widget',
+ );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Widgets.
- $widget_options = array(
- 'widget_bp_core_login_widget',
- 'widget_bp_core_members_widget',
- 'widget_bp_core_whos_online_widget',
- 'widget_bp_core_recently_active_widget',
- 'widget_bp_groups_widget',
- 'widget_bp_messages_sitewide_notices_widget',
- );
-
- foreach ( $widget_options as $widget_option ) {
- bp_delete_option( $widget_option );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ foreach ( $widget_options as $widget_option ) {
+ bp_delete_option( $widget_option );
+ }
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Community visibility.
</span><span class="cx" style="display: block; padding: 0 10px"> bp_update_option( '_bp_community_visibility', array( 'global' => 'anyone' ) );
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+ /**
+ * Fires once BuddyPress achieved 12.0 upgrading tasks.
+ *
+ * @since 12.0.0
+ */
+ do_action( 'bp_updated_to_12_0' );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span></span></pre>
</div>
</div>
</body>
</html>