<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][13500] trunk/src: Core, Activity: remove more never used inited variables in functions</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://buddypress.trac.wordpress.org/changeset/13500">13500</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://buddypress.trac.wordpress.org/changeset/13500","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>imath</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2023-06-10 06:22:42 +0000 (Sat, 10 Jun 2023)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Core, Activity: remove more never used inited variables in functions
Props upadalavipul, kajalgohel, viralsampat
Fixes <a href="http://buddypress.trac.wordpress.org/ticket/8892">#8892</a>
Closes https://github.com/buddypress/buddypress/pull/115</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcbpactivitybpactivitynotificationsphp">trunk/src/bp-activity/bp-activity-notifications.php</a></li>
<li><a href="#trunksrcbpactivitybpactivitytemplatephp">trunk/src/bp-activity/bp-activity-template.php</a></li>
<li><a href="#trunksrcbpcorebpcorebuddybarphp">trunk/src/bp-core/bp-core-buddybar.php</a></li>
<li><a href="#trunksrcbpcoreclassesclassbpblockphp">trunk/src/bp-core/classes/class-bp-block.php</a></li>
<li><a href="#trunksrcbpcoreclassesclassbpcorebpnavbackcompatphp">trunk/src/bp-core/classes/class-bp-core-bp-nav-backcompat.php</a></li>
<li><a href="#trunksrcbpcoreclassesclassbpinvitationmanagerphp">trunk/src/bp-core/classes/class-bp-invitation-manager.php</a></li>
<li><a href="#trunksrcbpcoreclassesclassbpmediaextractorphp">trunk/src/bp-core/classes/class-bp-media-extractor.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcbpactivitybpactivitynotificationsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-activity/bp-activity-notifications.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-activity/bp-activity-notifications.php 2023-06-09 00:52:29 UTC (rev 13499)
+++ trunk/src/bp-activity/bp-activity-notifications.php 2023-06-10 06:22:42 UTC (rev 13500)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -42,7 +42,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /* translators: %s: the current user display name */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $title = sprintf( __( '@%s Mentions', 'buddypress' ), bp_get_loggedin_user_username() );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $text = sprintf( __( '@%s Mentions', 'buddypress' ), bp_get_loggedin_user_username() );
</ins><span class="cx" style="display: block; padding: 0 10px"> $amount = 'single';
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( (int) $total_items > 1 ) {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -57,7 +57,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> case 'update_reply':
</span><span class="cx" style="display: block; padding: 0 10px"> $link = bp_get_notifications_permalink();
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $title = __( 'New Activity reply', 'buddypress' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $text = __( 'New Activity reply', 'buddypress' );
</ins><span class="cx" style="display: block; padding: 0 10px"> $amount = 'single';
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( (int) $total_items > 1 ) {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -76,7 +76,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> case 'comment_reply':
</span><span class="cx" style="display: block; padding: 0 10px"> $link = bp_get_notifications_permalink();
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $title = __( 'New Activity comment reply', 'buddypress' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $text = __( 'New Activity comment reply', 'buddypress' );
</ins><span class="cx" style="display: block; padding: 0 10px"> $amount = 'single';
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( (int) $total_items > 1 ) {
</span></span></pre></div>
<a id="trunksrcbpactivitybpactivitytemplatephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-activity/bp-activity-template.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-activity/bp-activity-template.php 2023-06-09 00:52:29 UTC (rev 13499)
+++ trunk/src/bp-activity/bp-activity-template.php 2023-06-10 06:22:42 UTC (rev 13500)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -3190,7 +3190,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function bp_activity_can_comment() {
</span><span class="cx" style="display: block; padding: 0 10px"> global $activities_template;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $bp = buddypress();
</del><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Determine ability to comment based on activity type name.
</span><span class="cx" style="display: block; padding: 0 10px"> $activity_type = bp_get_activity_type();
</span></span></pre></div>
<a id="trunksrcbpcorebpcorebuddybarphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-core/bp-core-buddybar.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-core/bp-core-buddybar.php 2023-06-09 00:52:29 UTC (rev 13499)
+++ trunk/src/bp-core/bp-core-buddybar.php 2023-06-10 06:22:42 UTC (rev 13500)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -119,8 +119,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @return false|array Returns false on failure, new nav item on success.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function bp_core_create_nav_link( $args = '', $component = 'members' ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $bp = buddypress();
-
</del><span class="cx" style="display: block; padding: 0 10px"> $defaults = array(
</span><span class="cx" style="display: block; padding: 0 10px"> 'component_id' => '', // The component ID registering this nav item.
</span><span class="cx" style="display: block; padding: 0 10px"> 'name' => false, // Display name for the nav item.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -538,8 +536,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @return false|array Returns false on failure, new BP_Core_Nav_Item instance on success.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function bp_core_create_subnav_link( $args = '', $component = 'members' ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $bp = buddypress();
-
</del><span class="cx" style="display: block; padding: 0 10px"> $r = bp_parse_args(
</span><span class="cx" style="display: block; padding: 0 10px"> $args,
</span><span class="cx" style="display: block; padding: 0 10px"> array(
</span></span></pre></div>
<a id="trunksrcbpcoreclassesclassbpblockphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-core/classes/class-bp-block.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-core/classes/class-bp-block.php 2023-06-09 00:52:29 UTC (rev 13499)
+++ trunk/src/bp-core/classes/class-bp-block.php 2023-06-10 06:22:42 UTC (rev 13500)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -195,9 +195,9 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( ! isset( $this->registered_scripts['editor_script'] ) || ! $this->registered_scripts['editor_script'] ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $this->block = new WP_Error( 'script_registration_error', __( 'The required `editor_script` could not be registered.', 'buddypress' ) );
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+ // Register the styles.
</ins><span class="cx" style="display: block; padding: 0 10px"> } else {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Register the styles.
- $registered_styles = array();
</del><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> foreach ( array( 'editor_style', 'style' ) as $style_handle_key ) {
</span><span class="cx" style="display: block; padding: 0 10px"> if ( ! isset( $wp_args[ $style_handle_key ] ) || ! $wp_args[ $style_handle_key ] ) {
</span></span></pre></div>
<a id="trunksrcbpcoreclassesclassbpcorebpnavbackcompatphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-core/classes/class-bp-core-bp-nav-backcompat.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-core/classes/class-bp-core-bp-nav-backcompat.php 2023-06-09 00:52:29 UTC (rev 13499)
+++ trunk/src/bp-core/classes/class-bp-core-bp-nav-backcompat.php 2023-06-10 06:22:42 UTC (rev 13500)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -216,8 +216,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @return bool|array
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> protected function get_nav( $offset ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $bp = buddypress();
-
</del><span class="cx" style="display: block; padding: 0 10px"> $component_nav = $this->get_component_nav( $offset );
</span><span class="cx" style="display: block; padding: 0 10px"> $primary_nav = $component_nav->get_primary( array( 'slug' => $offset ), false );
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunksrcbpcoreclassesclassbpinvitationmanagerphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-core/classes/class-bp-invitation-manager.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-core/classes/class-bp-invitation-manager.php 2023-06-09 00:52:29 UTC (rev 13499)
+++ trunk/src/bp-core/classes/class-bp-invitation-manager.php 2023-06-10 06:22:42 UTC (rev 13500)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -169,8 +169,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @return bool The result of `run_send_action()`.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function send_invitation_by_id( $invitation_id = 0, $args = array() ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $updated = false;
-
</del><span class="cx" style="display: block; padding: 0 10px"> $invitation = new BP_Invitation( $invitation_id );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( ! $invitation->id ) {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -327,8 +325,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @return bool The result of `run_send_action()`.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function send_request_notification_by_id( $request_id = 0, $args = array() ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $updated = false;
-
</del><span class="cx" style="display: block; padding: 0 10px"> $request = new BP_Invitation( $request_id );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( ! $request->id ) {
</span></span></pre></div>
<a id="trunksrcbpcoreclassesclassbpmediaextractorphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-core/classes/class-bp-media-extractor.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-core/classes/class-bp-media-extractor.php 2023-06-09 00:52:29 UTC (rev 13499)
+++ trunk/src/bp-core/classes/class-bp-media-extractor.php 2023-06-10 06:22:42 UTC (rev 13500)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -519,7 +519,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> protected function extract_embeds( $richtext, $plaintext, $extra_args = array() ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $data = array( 'has' => array( 'embeds' => 0 ), 'embeds' => array() );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $embeds = array();
</del><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( ! function_exists( '_wp_oembed_get_object' ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> require( ABSPATH . WPINC . '/class-oembed.php' );
</span></span></pre>
</div>
</div>
</body>
</html>