<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][13497] trunk/src: Core, Activity & Notifications: remove never used inited variables</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://buddypress.trac.wordpress.org/changeset/13497">13497</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://buddypress.trac.wordpress.org/changeset/13497","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>imath</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2023-06-04 05:48:51 +0000 (Sun, 04 Jun 2023)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Core, Activity & Notifications: remove never used inited variables
Props upadalavipul
Fixes <a href="http://buddypress.trac.wordpress.org/ticket/8892">#8892</a>
Closes https://github.com/buddypress/buddypress/pull/113</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcbpactivitybpactivityadminphp">trunk/src/bp-activity/bp-activity-admin.php</a></li>
<li><a href="#trunksrcbpactivityclassesclassbpactivitylisttablephp">trunk/src/bp-activity/classes/class-bp-activity-list-table.php</a></li>
<li><a href="#trunksrcbpcoreadminbpcoreadminfunctionsphp">trunk/src/bp-core/admin/bp-core-admin-functions.php</a></li>
<li><a href="#trunksrcbpcoreadminbpcoreadminschemaphp">trunk/src/bp-core/admin/bp-core-admin-schema.php</a></li>
<li><a href="#trunksrcbpcorebpcoreavatarsphp">trunk/src/bp-core/bp-core-avatars.php</a></li>
<li><a href="#trunksrcbpnotificationsbpnotificationsfunctionsphp">trunk/src/bp-notifications/bp-notifications-functions.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcbpactivitybpactivityadminphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-activity/bp-activity-admin.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-activity/bp-activity-admin.php 2023-06-03 07:39:51 UTC (rev 13496)
+++ trunk/src/bp-activity/bp-activity-admin.php 2023-06-04 05:48:51 UTC (rev 13497)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -984,7 +984,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @param object $item Activity item.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function bp_activity_admin_edit_metabox_type( $item ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $bp = buddypress();
</del><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $actions = array();
</span><span class="cx" style="display: block; padding: 0 10px"> $selected = $item->type;
</span></span></pre></div>
<a id="trunksrcbpactivityclassesclassbpactivitylisttablephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-activity/classes/class-bp-activity-list-table.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-activity/classes/class-bp-activity-list-table.php 2023-06-03 07:39:51 UTC (rev 13496)
+++ trunk/src/bp-activity/classes/class-bp-activity-list-table.php 2023-06-04 05:48:51 UTC (rev 13497)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -95,7 +95,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $filter_query = false;
</span><span class="cx" style="display: block; padding: 0 10px"> $include_id = false;
</span><span class="cx" style="display: block; padding: 0 10px"> $search_terms = false;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $sort = 'DESC';
</del><span class="cx" style="display: block; padding: 0 10px"> $spam = 'ham_only';
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Set current page.
</span></span></pre></div>
<a id="trunksrcbpcoreadminbpcoreadminfunctionsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-core/admin/bp-core-admin-functions.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-core/admin/bp-core-admin-functions.php 2023-06-03 07:39:51 UTC (rev 13496)
+++ trunk/src/bp-core/admin/bp-core-admin-functions.php 2023-06-04 05:48:51 UTC (rev 13497)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1145,7 +1145,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $tax_name = esc_attr( $r['taxonomy'] );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $taxonomy = get_taxonomy( $r['taxonomy'] );
</del><span class="cx" style="display: block; padding: 0 10px"> ?>
</span><span class="cx" style="display: block; padding: 0 10px"> <div id="taxonomy-<?php echo $tax_name; ?>" class="categorydiv">
</span><span class="cx" style="display: block; padding: 0 10px"> <div id="<?php echo $tax_name; ?>-all" class="tabs-panel">
</span></span></pre></div>
<a id="trunksrcbpcoreadminbpcoreadminschemaphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-core/admin/bp-core-admin-schema.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-core/admin/bp-core-admin-schema.php 2023-06-03 07:39:51 UTC (rev 13496)
+++ trunk/src/bp-core/admin/bp-core-admin-schema.php 2023-06-04 05:48:51 UTC (rev 13497)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -613,7 +613,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> function bp_core_install_nonmember_opt_outs() {
</span><span class="cx" style="display: block; padding: 0 10px"> $sql = array();
</span><span class="cx" style="display: block; padding: 0 10px"> $charset_collate = $GLOBALS['wpdb']->get_charset_collate();
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $bp_prefix = bp_core_get_table_prefix();
</del><span class="cx" style="display: block; padding: 0 10px"> $optouts_class = new BP_Optout();
</span><span class="cx" style="display: block; padding: 0 10px"> $table_name = $optouts_class->get_table_name();
</span><span class="cx" style="display: block; padding: 0 10px"> $sql = "CREATE TABLE {$table_name} (
</span></span></pre></div>
<a id="trunksrcbpcorebpcoreavatarsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-core/bp-core-avatars.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-core/bp-core-avatars.php 2023-06-03 07:39:51 UTC (rev 13496)
+++ trunk/src/bp-core/bp-core-avatars.php 2023-06-04 05:48:51 UTC (rev 13497)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -17,24 +17,27 @@
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function bp_core_set_avatar_constants() {
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $bp = buddypress();
-
- if ( !defined( 'BP_AVATAR_THUMB_WIDTH' ) )
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( ! defined( 'BP_AVATAR_THUMB_WIDTH' ) ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> define( 'BP_AVATAR_THUMB_WIDTH', 50 );
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ }
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( !defined( 'BP_AVATAR_THUMB_HEIGHT' ) )
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( ! defined( 'BP_AVATAR_THUMB_HEIGHT' ) ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> define( 'BP_AVATAR_THUMB_HEIGHT', 50 );
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ }
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( !defined( 'BP_AVATAR_FULL_WIDTH' ) )
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( ! defined( 'BP_AVATAR_FULL_WIDTH' ) ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> define( 'BP_AVATAR_FULL_WIDTH', 150 );
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ }
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( !defined( 'BP_AVATAR_FULL_HEIGHT' ) )
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( ! defined( 'BP_AVATAR_FULL_HEIGHT' ) ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> define( 'BP_AVATAR_FULL_HEIGHT', 150 );
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ }
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( !defined( 'BP_AVATAR_ORIGINAL_MAX_WIDTH' ) )
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( ! defined( 'BP_AVATAR_ORIGINAL_MAX_WIDTH' ) ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> define( 'BP_AVATAR_ORIGINAL_MAX_WIDTH', 450 );
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ }
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( !defined( 'BP_AVATAR_ORIGINAL_MAX_FILESIZE' ) ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( ! defined( 'BP_AVATAR_ORIGINAL_MAX_FILESIZE' ) ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> define( 'BP_AVATAR_ORIGINAL_MAX_FILESIZE', bp_attachments_get_max_upload_file_size( 'avatar' ) );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunksrcbpnotificationsbpnotificationsfunctionsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-notifications/bp-notifications-functions.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-notifications/bp-notifications-functions.php 2023-06-03 07:39:51 UTC (rev 13496)
+++ trunk/src/bp-notifications/bp-notifications-functions.php 2023-06-04 05:48:51 UTC (rev 13497)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -928,8 +928,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'order' => 'DESC',
</span><span class="cx" style="display: block; padding: 0 10px"> ) );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $user_data_to_export = array();
-
</del><span class="cx" style="display: block; padding: 0 10px"> foreach ( $notifications as $notification ) {
</span><span class="cx" style="display: block; padding: 0 10px"> if ( 'xprofile' === $notification->component_name ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $component_name = 'profile';
</span></span></pre>
</div>
</div>
</body>
</html>