<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][13476] trunk/src: Remove never used inited variables in Blogs & Members components</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://buddypress.trac.wordpress.org/changeset/13476">13476</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://buddypress.trac.wordpress.org/changeset/13476","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>imath</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2023-05-13 09:19:10 +0000 (Sat, 13 May 2023)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Remove never used inited variables in Blogs & Members components
Props upadalavipul
Fixes <a href="http://buddypress.trac.wordpress.org/ticket/8892">#8892</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcbpblogsbpblogsactivityphp">trunk/src/bp-blogs/bp-blogs-activity.php</a></li>
<li><a href="#trunksrcbpblogsbpblogsfiltersphp">trunk/src/bp-blogs/bp-blogs-filters.php</a></li>
<li><a href="#trunksrcbpmembersclassesclassbpmembersinvitationmanagerphp">trunk/src/bp-members/classes/class-bp-members-invitation-manager.php</a></li>
<li><a href="#trunksrcbpmembersclassesclassbpmemberslisttablephp">trunk/src/bp-members/classes/class-bp-members-list-table.php</a></li>
<li><a href="#trunksrcbpmembersclassesclassbpmembersmslisttablephp">trunk/src/bp-members/classes/class-bp-members-ms-list-table.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcbpblogsbpblogsactivityphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-blogs/bp-blogs-activity.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-blogs/bp-blogs-activity.php 2023-05-13 08:57:35 UTC (rev 13475)
+++ trunk/src/bp-blogs/bp-blogs-activity.php 2023-05-13 09:19:10 UTC (rev 13476)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -954,7 +954,6 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Get the comment status.
</span><span class="cx" style="display: block; padding: 0 10px"> $post_comment_status = wp_get_comment_status( $post_comment_id );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $old_comment_status = $post_comment_status;
</del><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // No need to edit the activity, as it's the activity who's updating the comment.
</span><span class="cx" style="display: block; padding: 0 10px"> remove_action( 'transition_comment_status', 'bp_activity_transition_post_type_comment_status', 10 );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1417,7 +1416,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $blog_comment_id = bp_activity_get_meta( $activity->id, "bp_blogs_{$post_type}_comment_id" );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( ! empty( $blog_comment_id ) ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $bp = buddypress();
</del><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Check if a comment action id is set for the parent activity.
</span><span class="cx" style="display: block; padding: 0 10px"> $comment_action_id = bp_activity_post_type_get_tracking_arg( $parent_activity->type, 'comment_action_id' );
</span></span></pre></div>
<a id="trunksrcbpblogsbpblogsfiltersphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-blogs/bp-blogs-filters.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-blogs/bp-blogs-filters.php 2023-05-13 08:57:35 UTC (rev 13475)
+++ trunk/src/bp-blogs/bp-blogs-filters.php 2023-05-13 09:19:10 UTC (rev 13476)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -77,7 +77,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @return bool True to authorize the post to be published, otherwise false.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function bp_blogs_post_pre_publish( $return = true, $blog_id = 0, $post_id = 0, $user_id = 0 ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $bp = buddypress();
</del><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // If blog is not trackable, do not record the activity.
</span><span class="cx" style="display: block; padding: 0 10px"> if ( ! bp_blogs_is_blog_trackable( $blog_id, $user_id ) ) {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -90,7 +89,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> $sitewide_tags_blog_settings = bp_core_get_root_option( 'sitewide_tags_blog' );
</span><span class="cx" style="display: block; padding: 0 10px"> if ( ! empty( $sitewide_tags_blog_settings ) ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $st_options = maybe_unserialize( $sitewide_tags_blog_settings );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $st_options = maybe_unserialize( $sitewide_tags_blog_settings );
</ins><span class="cx" style="display: block; padding: 0 10px"> $tags_blog_id = isset( $st_options['tags_blog_id'] ) ? $st_options['tags_blog_id'] : 0;
</span><span class="cx" style="display: block; padding: 0 10px"> } else {
</span><span class="cx" style="display: block; padding: 0 10px"> $tags_blog_id = bp_core_get_root_option( 'sitewide_tags_blog' );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -104,7 +103,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @param bool $value Current status of the sitewide tags activity.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( (int) $blog_id == $tags_blog_id && apply_filters( 'bp_blogs_block_sitewide_tags_activity', true ) ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( (int) $blog_id === $tags_blog_id && apply_filters( 'bp_blogs_block_sitewide_tags_activity', true ) ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> return false;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunksrcbpmembersclassesclassbpmembersinvitationmanagerphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-members/classes/class-bp-members-invitation-manager.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-members/classes/class-bp-members-invitation-manager.php 2023-05-13 08:57:35 UTC (rev 13475)
+++ trunk/src/bp-members/classes/class-bp-members-invitation-manager.php 2023-05-13 09:19:10 UTC (rev 13476)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -52,8 +52,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> return false;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $inviter_ud = bp_core_get_core_userdata( $invitation->inviter_id );
-
</del><span class="cx" style="display: block; padding: 0 10px"> $invite_url = esc_url(
</span><span class="cx" style="display: block; padding: 0 10px"> add_query_arg(
</span><span class="cx" style="display: block; padding: 0 10px"> array(
</span></span></pre></div>
<a id="trunksrcbpmembersclassesclassbpmemberslisttablephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-members/classes/class-bp-members-list-table.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-members/classes/class-bp-members-list-table.php 2023-05-13 08:57:35 UTC (rev 13475)
+++ trunk/src/bp-members/classes/class-bp-members-list-table.php 2023-05-13 09:19:10 UTC (rev 13476)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -366,8 +366,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> return;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $profile_field_ids = array();
-
</del><span class="cx" style="display: block; padding: 0 10px"> // Fetch registration field data once only.
</span><span class="cx" style="display: block; padding: 0 10px"> if ( ! $this->signup_field_labels ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $field_groups = bp_xprofile_get_groups(
</span></span></pre></div>
<a id="trunksrcbpmembersclassesclassbpmembersmslisttablephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-members/classes/class-bp-members-ms-list-table.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-members/classes/class-bp-members-ms-list-table.php 2023-05-13 08:57:35 UTC (rev 13475)
+++ trunk/src/bp-members/classes/class-bp-members-ms-list-table.php 2023-05-13 09:19:10 UTC (rev 13476)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -358,7 +358,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( bp_is_active( 'xprofile' ) ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $profile_field_ids = array();
</del><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Fetch registration field data once only.
</span><span class="cx" style="display: block; padding: 0 10px"> if ( ! $this->signup_field_labels ) {
</span></span></pre>
</div>
</div>
</body>
</html>