<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][13194] trunk/src: BP Blocks: localize dynamic Blocks script data into site's footer</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://buddypress.trac.wordpress.org/changeset/13194">13194</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://buddypress.trac.wordpress.org/changeset/13194","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>imath</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2021-12-23 06:24:36 +0000 (Thu, 23 Dec 2021)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>BP Blocks: localize dynamic Blocks script data into site's footer
These script data were not printed into themes using the Full Site Editing feature, like Twenty Twenty-Two, which was generated a JavaScript error as soon as the user clicked on one of the links to filter the loop's items (friends, members or groups).
Moving the script localization to the site's footer makes sure the JavaScript error disappears and that links are fully functional. This change has also been successfully tested on regular WordPress themes.
See <a href="http://buddypress.trac.wordpress.org/ticket/8474">#8474</a> </pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcbpfriendsbpfriendsblocksphp">trunk/src/bp-friends/bp-friends-blocks.php</a></li>
<li><a href="#trunksrcbpgroupsbpgroupsblocksphp">trunk/src/bp-groups/bp-groups-blocks.php</a></li>
<li><a href="#trunksrcbpmembersbpmembersblocksphp">trunk/src/bp-members/bp-members-blocks.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcbpfriendsbpfriendsblocksphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-friends/bp-friends-blocks.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-friends/bp-friends-blocks.php 2021-12-18 19:25:13 UTC (rev 13193)
+++ trunk/src/bp-friends/bp-friends-blocks.php 2021-12-23 06:24:36 UTC (rev 13194)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -24,6 +24,23 @@
</span><span class="cx" style="display: block; padding: 0 10px"> return;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $path = sprintf(
+ '/%1$s/%2$s/%3$s',
+ bp_rest_namespace(),
+ bp_rest_version(),
+ buddypress()->members->id
+ );
+
+ wp_localize_script(
+ 'bp-friends-script',
+ 'bpFriendsSettings',
+ array(
+ 'path' => ltrim( $path, '/' ),
+ 'root' => esc_url_raw( get_rest_url() ),
+ 'nonce' => wp_create_nonce( 'wp_rest' ),
+ )
+ );
+
</ins><span class="cx" style="display: block; padding: 0 10px"> // Include the common JS template.
</span><span class="cx" style="display: block; padding: 0 10px"> echo bp_get_dynamic_template_part( 'assets/widgets/friends.php' );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -219,15 +236,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> if ( ! has_action( 'wp_footer', 'bp_friends_blocks_add_script_data', 1 ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> wp_set_script_translations( 'bp-friends-script', 'buddypress' );
</span><span class="cx" style="display: block; padding: 0 10px"> wp_enqueue_script( 'bp-friends-script' );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- wp_localize_script(
- 'bp-friends-script',
- 'bpFriendsSettings',
- array(
- 'path' => ltrim( $path, '/' ),
- 'root' => esc_url_raw( get_rest_url() ),
- 'nonce' => wp_create_nonce( 'wp_rest' ),
- )
- );
</del><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> add_action( 'wp_footer', 'bp_friends_blocks_add_script_data', 1 );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre></div>
<a id="trunksrcbpgroupsbpgroupsblocksphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-groups/bp-groups-blocks.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-groups/bp-groups-blocks.php 2021-12-18 19:25:13 UTC (rev 13193)
+++ trunk/src/bp-groups/bp-groups-blocks.php 2021-12-23 06:24:36 UTC (rev 13194)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -325,6 +325,23 @@
</span><span class="cx" style="display: block; padding: 0 10px"> return;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $path = sprintf(
+ '/%1$s/%2$s/%3$s',
+ bp_rest_namespace(),
+ bp_rest_version(),
+ buddypress()->groups->id
+ );
+
+ wp_localize_script(
+ 'bp-dynamic-groups-script',
+ 'bpDynamicGroupsSettings',
+ array(
+ 'path' => ltrim( $path, '/' ),
+ 'root' => esc_url_raw( get_rest_url() ),
+ 'nonce' => wp_create_nonce( 'wp_rest' ),
+ )
+ );
+
</ins><span class="cx" style="display: block; padding: 0 10px"> // Include the common JS template.
</span><span class="cx" style="display: block; padding: 0 10px"> echo bp_get_dynamic_template_part( 'assets/widgets/dynamic-groups.php' );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -495,15 +512,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> if ( ! has_action( 'wp_footer', 'bp_groups_blocks_add_script_data', 1 ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> wp_set_script_translations( 'bp-dynamic-groups-script', 'buddypress' );
</span><span class="cx" style="display: block; padding: 0 10px"> wp_enqueue_script( 'bp-dynamic-groups-script' );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- wp_localize_script(
- 'bp-dynamic-groups-script',
- 'bpDynamicGroupsSettings',
- array(
- 'path' => ltrim( $path, '/' ),
- 'root' => esc_url_raw( get_rest_url() ),
- 'nonce' => wp_create_nonce( 'wp_rest' ),
- )
- );
</del><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> add_action( 'wp_footer', 'bp_groups_blocks_add_script_data', 1 );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre></div>
<a id="trunksrcbpmembersbpmembersblocksphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-members/bp-members-blocks.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-members/bp-members-blocks.php 2021-12-18 19:25:13 UTC (rev 13193)
+++ trunk/src/bp-members/bp-members-blocks.php 2021-12-23 06:24:36 UTC (rev 13194)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -346,6 +346,23 @@
</span><span class="cx" style="display: block; padding: 0 10px"> return;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $path = sprintf(
+ '/%1$s/%2$s/%3$s',
+ bp_rest_namespace(),
+ bp_rest_version(),
+ buddypress()->members->id
+ );
+
+ wp_localize_script(
+ 'bp-dynamic-members-script',
+ 'bpDynamicMembersSettings',
+ array(
+ 'path' => ltrim( $path, '/' ),
+ 'root' => esc_url_raw( get_rest_url() ),
+ 'nonce' => wp_create_nonce( 'wp_rest' ),
+ )
+ );
+
</ins><span class="cx" style="display: block; padding: 0 10px"> // Include the common JS template.
</span><span class="cx" style="display: block; padding: 0 10px"> echo bp_get_dynamic_template_part( 'assets/widgets/dynamic-members.php' );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -512,15 +529,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> if ( ! has_action( 'wp_footer', 'bp_members_blocks_add_script_data', 1 ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> wp_set_script_translations( 'bp-dynamic-members-script', 'buddypress' );
</span><span class="cx" style="display: block; padding: 0 10px"> wp_enqueue_script( 'bp-dynamic-members-script' );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- wp_localize_script(
- 'bp-dynamic-members-script',
- 'bpDynamicMembersSettings',
- array(
- 'path' => ltrim( $path, '/' ),
- 'root' => esc_url_raw( get_rest_url() ),
- 'nonce' => wp_create_nonce( 'wp_rest' ),
- )
- );
</del><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> add_action( 'wp_footer', 'bp_members_blocks_add_script_data', 1 );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre>
</div>
</div>
</body>
</html>