<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][12977] branches/8.0/src/bp-xprofile/classes: Make sure saving empty WP xProfile fields does generate an error</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://buddypress.trac.wordpress.org/changeset/12977">12977</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://buddypress.trac.wordpress.org/changeset/12977","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>imath</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2021-06-28 17:05:06 +0000 (Mon, 28 Jun 2021)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Make sure saving empty WP xProfile fields does generate an error
WP xProfile field types are allowing their values to be empty. In such a case the `xprofile_set_field_data()` is using an array as the value to be saved. This is done to avoid the value of certain types of fields (checkboxes, multiselects) to be overwritten by the default value on next edit.
For WP xProfile field types, we simply need to return an empty string in this case.
See <a href="http://buddypress.trac.wordpress.org/ticket/8494">#8494</a> (branch 8.0)</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#branches80srcbpxprofileclassesclassbpxprofilefieldtypewordpressbiographyphp">branches/8.0/src/bp-xprofile/classes/class-bp-xprofile-field-type-wordpress-biography.php</a></li>
<li><a href="#branches80srcbpxprofileclassesclassbpxprofilefieldtypewordpresstextboxphp">branches/8.0/src/bp-xprofile/classes/class-bp-xprofile-field-type-wordpress-textbox.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="branches80srcbpxprofileclassesclassbpxprofilefieldtypewordpressbiographyphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: branches/8.0/src/bp-xprofile/classes/class-bp-xprofile-field-type-wordpress-biography.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- branches/8.0/src/bp-xprofile/classes/class-bp-xprofile-field-type-wordpress-biography.php 2021-06-27 10:47:39 UTC (rev 12976)
+++ branches/8.0/src/bp-xprofile/classes/class-bp-xprofile-field-type-wordpress-biography.php 2021-06-28 17:05:06 UTC (rev 12977)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -51,6 +51,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @return string The sanitized field value.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function sanitize_for_db( $value ) {
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( ! $value ) {
+ return '';
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> return trim( $value );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="branches80srcbpxprofileclassesclassbpxprofilefieldtypewordpresstextboxphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: branches/8.0/src/bp-xprofile/classes/class-bp-xprofile-field-type-wordpress-textbox.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- branches/8.0/src/bp-xprofile/classes/class-bp-xprofile-field-type-wordpress-textbox.php 2021-06-27 10:47:39 UTC (rev 12976)
+++ branches/8.0/src/bp-xprofile/classes/class-bp-xprofile-field-type-wordpress-textbox.php 2021-06-28 17:05:06 UTC (rev 12977)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -91,6 +91,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @return string The sanitized field value.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function sanitize_for_db( $value ) {
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( ! $value ) {
+ return '';
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> if ( 'user_url' === $this->wp_user_key ) {
</span><span class="cx" style="display: block; padding: 0 10px"> return esc_url_raw( $value );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre>
</div>
</div>
</body>
</html>