<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][12739] trunk/src/bp-core/admin: Make the BP Tools Admin screen more consistent with WP Admin ones</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://buddypress.trac.wordpress.org/changeset/12739">12739</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://buddypress.trac.wordpress.org/changeset/12739","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>imath</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2020-10-03 17:19:21 +0000 (Sat, 03 Oct 2020)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Make the BP Tools Admin screen more consistent with WP Admin ones
- the notice message now uses the same width & height than in other administration screens.
- improve the visibility of the advice about not running multiple tools at the same time.
- edit the HTML markup to use existing WordPress styling and save some code lines into our `common.css` file.
Fixes <a href="http://buddypress.trac.wordpress.org/ticket/8357">#8357</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcbpcoreadminbpcoreadmintoolsphp">trunk/src/bp-core/admin/bp-core-admin-tools.php</a></li>
<li><a href="#trunksrcbpcoreadmincsscommonrtlcss">trunk/src/bp-core/admin/css/common-rtl.css</a></li>
<li><a href="#trunksrcbpcoreadmincsscommoncss">trunk/src/bp-core/admin/css/common.css</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcbpcoreadminbpcoreadmintoolsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-core/admin/bp-core-admin-tools.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-core/admin/bp-core-admin-tools.php 2020-10-02 19:25:21 UTC (rev 12738)
+++ trunk/src/bp-core/admin/bp-core-admin-tools.php 2020-10-03 17:19:21 UTC (rev 12739)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -22,21 +22,26 @@
</span><span class="cx" style="display: block; padding: 0 10px"> <h1 class="wp-heading-inline"><?php esc_html_e( 'BuddyPress Tools', 'buddypress' ) ?></h1>
</span><span class="cx" style="display: block; padding: 0 10px"> <hr class="wp-header-end">
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <p><?php esc_html_e( 'BuddyPress keeps track of various relationships between members, groups, and activity items. Occasionally these relationships become out of sync, most often after an import, update, or migration.', 'buddypress' ); ?></p>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <p><?php esc_html_e( 'BuddyPress keeps track of various relationships between members, groups, and activity items.', 'buddypress' ); ?></p>
+ <p><?php esc_html_e( 'Occasionally these relationships become out of sync, most often after an import, update, or migration.', 'buddypress' ); ?></p>
</ins><span class="cx" style="display: block; padding: 0 10px"> <p><?php esc_html_e( 'Use the tools below to manually recalculate these relationships.', 'buddypress' ); ?>
</span><span class="cx" style="display: block; padding: 0 10px"> </p>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <p class="description"><?php esc_html_e( 'Some of these tools create substantial database overhead. Avoid running more than one repair job at a time.', 'buddypress' ); ?></p>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <p class="attention"><?php esc_html_e( 'Some of these tools create substantial database overhead. Avoid running more than one repair job at a time.', 'buddypress' ); ?></p>
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <h2><?php esc_html_e( 'Activate checkboxe(s) to select the operation(s) to perform', 'buddypress' ); ?></h2>
+
</ins><span class="cx" style="display: block; padding: 0 10px"> <form class="settings" method="post" action="">
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> <fieldset>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <legend><?php esc_html_e( 'Repair tools', 'buddypress' ) ?></legend>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <legend class="screen-reader-text"><?php esc_html_e( 'Repair tools', 'buddypress' ); ?></legend>
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <div class="checkbox">
</del><span class="cx" style="display: block; padding: 0 10px"> <?php foreach ( bp_admin_repair_list() as $item ) : ?>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <label for="<?php echo esc_attr( str_replace( '_', '-', $item[0] ) ); ?>"><input type="checkbox" class="checkbox" name="<?php echo esc_attr( $item[0] ) . '" id="' . esc_attr( str_replace( '_', '-', $item[0] ) ); ?>" value="1" /> <?php echo esc_html( $item[1] ); ?></label>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <p>
+ <label for="<?php echo esc_attr( str_replace( '_', '-', $item[0] ) ); ?>">
+ <input type="checkbox" class="checkbox" name="<?php echo esc_attr( $item[0] ) . '" id="' . esc_attr( str_replace( '_', '-', $item[0] ) ); ?>" value="1" /> <?php echo esc_html( $item[1] ); ?>
+ </label>
+ </p>
</ins><span class="cx" style="display: block; padding: 0 10px"> <?php endforeach; ?>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- </div>
</del><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> <p class="submit">
</span><span class="cx" style="display: block; padding: 0 10px"> <input class="button-primary" type="submit" name="bp-tools-submit" value="<?php esc_attr_e( 'Repair Items', 'buddypress' ); ?>" />
</span></span></pre></div>
<a id="trunksrcbpcoreadmincsscommonrtlcss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-core/admin/css/common-rtl.css</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-core/admin/css/common-rtl.css 2020-10-02 19:25:21 UTC (rev 12738)
+++ trunk/src/bp-core/admin/css/common-rtl.css 2020-10-03 17:19:21 UTC (rev 12739)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -21,8 +21,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 3.1 Users List
</span><span class="cx" style="display: block; padding: 0 10px"> 3.2 Site Notices
</span><span class="cx" style="display: block; padding: 0 10px"> 4.0 Emails - Edit page
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-5.0 Tools - BuddyPress
-6.0 Plugins page
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+5.0 Plugins page
</ins><span class="cx" style="display: block; padding: 0 10px"> ------------------------------------------------------------------------------*/
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /*------------------------------------------------------------------------------
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -523,56 +522,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /*------------------------------------------------------------------------------
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * 5.0 Tools - BuddyPress
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * 5.0 Plugins page
</ins><span class="cx" style="display: block; padding: 0 10px"> *----------------------------------------------------------------------------*/
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-.tools_page_bp-tools .wrap {
- max-width: 950px;
-}
-
-.tools_page_bp-tools p {
- line-height: 2;
-}
-
-.tools_page_bp-tools fieldset {
- margin: 2em 0 0;
-}
-
-.tools_page_bp-tools legend {
- color: #23282d;
- font-size: 1.3em;
- font-weight: 600;
- margin: 1em 0;
-}
-
-.tools_page_bp-tools label {
- clear: right;
- display: block;
- line-height: 1.5;
- margin: 0 0 1em;
- vertical-align: middle;
-}
-
-@media screen and (max-width: 782px) {
-
- .tools_page_bp-tools p {
- line-height: 1.5;
- }
-
- .tools_page_bp-tools label {
- margin-bottom: 1em;
- padding-left: 25px;
- text-indent: -33px;
- }
-
- .tools_page_bp-tools .checkbox {
- padding: 0 30px 0 0;
- }
-}
-
-
-/*------------------------------------------------------------------------------
- * 6.0 Plugins page
- *----------------------------------------------------------------------------*/
</del><span class="cx" style="display: block; padding: 0 10px"> #buddypress-update.not-shiny .update-message {
</span><span class="cx" style="display: block; padding: 0 10px"> border-right: 0;
</span><span class="cx" style="display: block; padding: 0 10px"> padding-right: 36px;
</span></span></pre></div>
<a id="trunksrcbpcoreadmincsscommoncss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-core/admin/css/common.css</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-core/admin/css/common.css 2020-10-02 19:25:21 UTC (rev 12738)
+++ trunk/src/bp-core/admin/css/common.css 2020-10-03 17:19:21 UTC (rev 12739)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -21,8 +21,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 3.1 Users List
</span><span class="cx" style="display: block; padding: 0 10px"> 3.2 Site Notices
</span><span class="cx" style="display: block; padding: 0 10px"> 4.0 Emails - Edit page
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-5.0 Tools - BuddyPress
-6.0 Plugins page
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+5.0 Plugins page
</ins><span class="cx" style="display: block; padding: 0 10px"> ------------------------------------------------------------------------------*/
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /*------------------------------------------------------------------------------
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -523,56 +522,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /*------------------------------------------------------------------------------
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * 5.0 Tools - BuddyPress
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * 5.0 Plugins page
</ins><span class="cx" style="display: block; padding: 0 10px"> *----------------------------------------------------------------------------*/
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-.tools_page_bp-tools .wrap {
- max-width: 950px;
-}
-
-.tools_page_bp-tools p {
- line-height: 2;
-}
-
-.tools_page_bp-tools fieldset {
- margin: 2em 0 0;
-}
-
-.tools_page_bp-tools legend {
- color: #23282d;
- font-size: 1.3em;
- font-weight: 600;
- margin: 1em 0;
-}
-
-.tools_page_bp-tools label {
- clear: left;
- display: block;
- line-height: 1.5;
- margin: 0 0 1em;
- vertical-align: middle;
-}
-
-@media screen and (max-width: 782px) {
-
- .tools_page_bp-tools p {
- line-height: 1.5;
- }
-
- .tools_page_bp-tools label {
- margin-bottom: 1em;
- padding-right: 25px;
- text-indent: -33px;
- }
-
- .tools_page_bp-tools .checkbox {
- padding: 0 0 0 30px;
- }
-}
-
-
-/*------------------------------------------------------------------------------
- * 6.0 Plugins page
- *----------------------------------------------------------------------------*/
</del><span class="cx" style="display: block; padding: 0 10px"> #buddypress-update.not-shiny .update-message {
</span><span class="cx" style="display: block; padding: 0 10px"> border-left: 0;
</span><span class="cx" style="display: block; padding: 0 10px"> padding-left: 36px;
</span></span></pre>
</div>
</div>
</body>
</html>