<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][12679] trunk: BP Members: improve our password validation process</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://buddypress.trac.wordpress.org/changeset/12679">12679</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://buddypress.trac.wordpress.org/changeset/12679","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>imath</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2020-07-04 13:29:50 +0000 (Sat, 04 Jul 2020)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>BP Members: improve our password validation process
We're introducing a new function to validate the member's chosen password: `bp_members_validate_user_password()`.
This function is primarly used to check the password is not empty, and to make sure the password confirmation matches the password. If it's the case, the function will return a `WP_Error` object with no error message. Otherwise this object will contain an error message.
Plugins can now use the `bp_members_validate_user_password` filter to add their own error messages according to a custom validation process. See the last unit tests of this commit for an example of use.
Props devnik, tharsheblows
Fixes <a href="http://buddypress.trac.wordpress.org/ticket/8066">#8066</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcbpmembersbpmembersfunctionsphp">trunk/src/bp-members/bp-members-functions.php</a></li>
<li><a href="#trunksrcbpmembersscreensregisterphp">trunk/src/bp-members/screens/register.php</a></li>
<li><a href="#trunksrcbpsettingsactionsgeneralphp">trunk/src/bp-settings/actions/general.php</a></li>
<li><a href="#trunktestsphpunittestcasesmembersfunctionsphp">trunk/tests/phpunit/testcases/members/functions.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcbpmembersbpmembersfunctionsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-members/bp-members-functions.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-members/bp-members-functions.php 2020-07-04 11:42:49 UTC (rev 12678)
+++ trunk/src/bp-members/bp-members-functions.php 2020-07-04 13:29:50 UTC (rev 12679)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1769,6 +1769,40 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * Validate a user password.
+ *
+ * @since 7.0.0
+ *
+ * @param string $pass The password.
+ * @param string $confirm_pass The confirmed password.
+ * @param null|WP_User $userdata Null or the userdata object when a member updates their password from front-end.
+ * @return WP_Error A WP error object possibly containing error messages.
+ */
+function bp_members_validate_user_password( $pass, $confirm_pass, $userdata = null ) {
+ $errors = new WP_Error();
+
+ if ( ! $pass || ! $confirm_pass ) {
+ $errors->add( 'missing_user_password', __( 'Please make sure you enter your password twice', 'buddypress' ) );
+ }
+
+ if ( $pass && $confirm_pass && $pass !== $confirm_pass ) {
+ $errors->add( 'mismatching_user_password', __( 'The passwords you entered do not match.', 'buddypress' ) );
+ }
+
+ /**
+ * Filter here to add password validation errors.
+ *
+ * @since 7.0.0
+ *
+ * @param WP_Error $errors Password validation errors.
+ * @param string $pass The password.
+ * @param string $confirm_pass The confirmed password.
+ * @param null|WP_User $userdata Null or the userdata object when a member updates their password from front-end.
+ */
+ return apply_filters( 'bp_members_validate_user_password', $errors, $pass, $confirm_pass, $userdata );
+}
+
+/**
</ins><span class="cx" style="display: block; padding: 0 10px"> * Validate blog URL and title provided at signup.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 1.2.2
</span></span></pre></div>
<a id="trunksrcbpmembersscreensregisterphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-members/screens/register.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-members/screens/register.php 2020-07-04 11:42:49 UTC (rev 12678)
+++ trunk/src/bp-members/screens/register.php 2020-07-04 13:29:50 UTC (rev 12679)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -59,20 +59,32 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $account_details = bp_core_validate_user_signup( $_POST['signup_username'], $_POST['signup_email'] );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // If there are errors with account details, set them for display.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( !empty( $account_details['errors']->errors['user_name'] ) )
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( ! empty( $account_details['errors']->errors['user_name'] ) ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> $bp->signup->errors['signup_username'] = $account_details['errors']->errors['user_name'][0];
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ }
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( !empty( $account_details['errors']->errors['user_email'] ) )
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( ! empty( $account_details['errors']->errors['user_email'] ) ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> $bp->signup->errors['signup_email'] = $account_details['errors']->errors['user_email'][0];
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ }
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Check that both password fields are filled in.
- if ( empty( $_POST['signup_password'] ) || empty( $_POST['signup_password_confirm'] ) )
- $bp->signup->errors['signup_password'] = __( 'Please make sure you enter your password twice', 'buddypress' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $signup_pass = '';
+ if ( isset( $_POST['signup_password'] ) ) {
+ $signup_pass = wp_unslash( $_POST['signup_password'] );
+ }
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Check that the passwords match.
- if ( ( !empty( $_POST['signup_password'] ) && !empty( $_POST['signup_password_confirm'] ) ) && $_POST['signup_password'] != $_POST['signup_password_confirm'] )
- $bp->signup->errors['signup_password'] = __( 'The passwords you entered do not match.', 'buddypress' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $signup_pass_confirm = '';
+ if ( isset( $_POST['signup_password_confirm'] ) ) {
+ $signup_pass_confirm = wp_unslash( $_POST['signup_password_confirm'] );
+ }
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Check the account password for problems.
+ $account_password = bp_members_validate_user_password( $signup_pass, $signup_pass_confirm );
+ $password_error = $account_password->get_error_message();
+
+ if ( $password_error ) {
+ $bp->signup->errors['signup_password'] = $password_error;
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> if ( bp_signup_requires_privacy_policy_acceptance() && ! empty( $_POST['signup-privacy-policy-check'] ) && empty( $_POST['signup-privacy-policy-accept'] ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $bp->signup->errors['signup_privacy_policy'] = __( 'You must indicate that you have read and agreed to the Privacy Policy.', 'buddypress' );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -237,4 +249,4 @@
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> bp_core_load_template( apply_filters( 'bp_core_template_register', array( 'register', 'registration/register' ) ) );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-add_action( 'bp_screens', 'bp_core_screen_signup' );
</del><span class="cx" style="display: block; padding: 0 10px">\ No newline at end of file
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+add_action( 'bp_screens', 'bp_core_screen_signup' );
</ins></span></pre></div>
<a id="trunksrcbpsettingsactionsgeneralphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-settings/actions/general.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-settings/actions/general.php 2020-07-04 11:42:49 UTC (rev 12678)
+++ trunk/src/bp-settings/actions/general.php 2020-07-04 13:29:50 UTC (rev 12679)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -130,23 +130,22 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /* Password Change Attempt ***************************************/
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( !empty( $_POST['pass1'] ) && !empty( $_POST['pass2'] ) ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( ! empty( $_POST['pass1'] ) && ! empty( $_POST['pass2'] ) ) {
+ $pass = wp_unslash( $_POST['pass1'] );
+ $pass_confirm = wp_unslash( $_POST['pass2'] );
+ $pass_error = bp_members_validate_user_password( $pass, $pass_confirm, $update_user );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( ( $_POST['pass1'] == $_POST['pass2'] ) && !strpos( " " . wp_unslash( $_POST['pass1'] ), "\\" ) ) {
-
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( ! $pass_error->get_error_message() ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> // Password change attempt is successful.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( ( ! empty( $_POST['pwd'] ) && $_POST['pwd'] != $_POST['pass1'] ) || is_super_admin() ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( ( ! empty( $_POST['pwd'] ) && wp_unslash( $_POST['pwd'] ) !== $pass ) || is_super_admin() ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> $update_user->user_pass = $_POST['pass1'];
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $pass_changed = true;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $pass_error = false;
+ $pass_changed = true;
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // The new password is the same as the current password.
</span><span class="cx" style="display: block; padding: 0 10px"> } else {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $pass_error = 'same';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $pass_error->add( 'same_user_password', __( 'The new password must be different from the current password.', 'buddypress' ) );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-
- // Password change attempt was unsuccessful.
- } else {
- $pass_error = 'mismatch';
</del><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Both password fields were empty.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -154,8 +153,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $pass_error = false;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // One of the password boxes was left empty.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- } elseif ( ( empty( $_POST['pass1'] ) && !empty( $_POST['pass2'] ) ) || ( !empty( $_POST['pass1'] ) && empty( $_POST['pass2'] ) ) ) {
- $pass_error = 'empty';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ } elseif ( ( empty( $_POST['pass1'] ) && ! empty( $_POST['pass2'] ) ) || ( ! empty( $_POST['pass1'] ) && empty( $_POST['pass2'] ) ) ) {
+ $pass_error = new WP_Error( 'empty_user_password', __( 'One of the password fields was empty.', 'buddypress' ) );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // The structure of the $update_user object changed in WP 3.3, but
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -180,7 +179,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Password Error.
</span><span class="cx" style="display: block; padding: 0 10px"> } else {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $pass_error = 'invalid';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $pass_error = new WP_Error( 'invalid_user_password', __( 'Your current password is invalid.', 'buddypress' ) );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Email feedback.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -202,23 +201,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> break;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Password feedback.
- switch ( $pass_error ) {
- case 'invalid' :
- $feedback['pass_error'] = __( 'Your current password is invalid.', 'buddypress' );
- break;
- case 'mismatch' :
- $feedback['pass_mismatch'] = __( 'The new password fields did not match.', 'buddypress' );
- break;
- case 'empty' :
- $feedback['pass_empty'] = __( 'One of the password fields was empty.', 'buddypress' );
- break;
- case 'same' :
- $feedback['pass_same'] = __( 'The new password must be different from the current password.', 'buddypress' );
- break;
- case false :
- // No change.
- break;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( is_wp_error( $pass_error ) && $pass_error->get_error_message() ) {
+ $feedback[ $pass_error->get_error_code() ] = $pass_error->get_error_message();
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // No errors so show a simple success message.
</span></span></pre></div>
<a id="trunktestsphpunittestcasesmembersfunctionsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/testcases/members/functions.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/testcases/members/functions.php 2020-07-04 11:42:49 UTC (rev 12678)
+++ trunk/tests/phpunit/testcases/members/functions.php 2020-07-04 13:29:50 UTC (rev 12679)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -581,6 +581,62 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @group bp_members_validate_user_password
+ */
+ public function test_bp_members_validate_user_password() {
+ $validate = bp_members_validate_user_password( 'foobar', 'foobar' );
+
+ $this->assertEmpty( $validate->get_error_message() );
+ }
+
+ /**
+ * @group bp_members_validate_user_password
+ */
+ public function test_bp_members_validate_user_password_missing() {
+ $validate = bp_members_validate_user_password( '', '' );
+
+ $this->assertEquals( 'missing_user_password', $validate->get_error_code() );
+
+ $validate = bp_members_validate_user_password( 'foobar', '' );
+
+ $this->assertEquals( 'missing_user_password', $validate->get_error_code() );
+
+ $validate = bp_members_validate_user_password( '', 'foobar' );
+
+ $this->assertEquals( 'missing_user_password', $validate->get_error_code() );
+ }
+
+ /**
+ * @group bp_members_validate_user_password
+ */
+ public function test_bp_members_validate_user_password_mismatching() {
+ $validate = bp_members_validate_user_password( 'foobar', 'barfoo' );
+
+ $this->assertEquals( 'mismatching_user_password', $validate->get_error_code() );
+ }
+
+ /**
+ * @group bp_members_validate_user_password
+ */
+ public function test_bp_members_validate_user_password_too_short() {
+ add_filter( 'bp_members_validate_user_password', array( $this, 'filter_bp_members_validate_user_password' ), 10, 2 );
+
+ $validate = bp_members_validate_user_password( 'one', 'one' );
+
+ remove_filter( 'bp_members_validate_user_password', array( $this, 'filter_bp_members_validate_user_password' ), 10, 2 );
+
+ $this->assertEquals( 'too_short_user_password', $validate->get_error_code() );
+ }
+
+ function filter_bp_members_validate_user_password( $errors, $pass ) {
+ if ( 4 > strlen( $pass ) ) {
+ $errors->add( 'too_short_user_password', __( 'Your password is too short.', 'buddypress' ) );
+ }
+
+ return $errors;
+ }
+
+ /**
</ins><span class="cx" style="display: block; padding: 0 10px"> * @group bp_core_activate_signup
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function test_bp_core_activate_signup_password() {
</span></span></pre>
</div>
</div>
</body>
</html>