<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][12599] trunk/tests/phpunit/testcases/xprofile/activity.php: Use shared fixtures in `BP_Tests_XProfile_Activity`.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://buddypress.trac.wordpress.org/changeset/12599">12599</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://buddypress.trac.wordpress.org/changeset/12599","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>boonebgorges</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2020-03-28 21:20:46 +0000 (Sat, 28 Mar 2020)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Use shared fixtures in `BP_Tests_XProfile_Activity`.
Aside from improving speed, this allows us to skirt PHP 7.4 variable
access notices thrown when the fixtures were improperly created.
See <a href="http://buddypress.trac.wordpress.org/ticket/8264">#8264</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunktestsphpunittestcasesxprofileactivityphp">trunk/tests/phpunit/testcases/xprofile/activity.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunktestsphpunittestcasesxprofileactivityphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/testcases/xprofile/activity.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/testcases/xprofile/activity.php 2020-03-28 20:27:15 UTC (rev 12598)
+++ trunk/tests/phpunit/testcases/xprofile/activity.php 2020-03-28 21:20:46 UTC (rev 12599)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -5,29 +5,51 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @group activity
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> class BP_Tests_XProfile_Activity extends BP_UnitTestCase {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- protected $updated_profile_data = array();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ protected static $updated_profile_data = array();
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ public static function wpSetUpBeforeClass( $factory ) {
+ self::$updated_profile_data['u'] = $factory->user->create();
+ self::$updated_profile_data['g'] = $factory->xprofile_group->create();
+ self::$updated_profile_data['f'] = $factory->xprofile_field->create( array(
+ 'field_group_id' => self::$updated_profile_data['g'],
+ ) );
+ }
+
+ public static function tearDownAfterClass() {
+ $d = self::$updated_profile_data;
+
+ xprofile_delete_field_group( $d['g'] );
+ xprofile_delete_field( $d['f'] );
+
+ self::delete_user( $d['u'] );
+
+ self::commit_transaction();
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * @group bp_xprofile_updated_profile_activity
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function test_bp_xprofile_updated_profile_activity_with_errors() {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $d = $this->setup_updated_profile_data();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $d = self::$updated_profile_data;
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Fake new/old values to ensure a change
</span><span class="cx" style="display: block; padding: 0 10px"> $old_values = array(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->updated_profile_data['f'] => array(
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $d['f'] => array(
</ins><span class="cx" style="display: block; padding: 0 10px"> 'value' => 'foo',
</span><span class="cx" style="display: block; padding: 0 10px"> 'visibility' => 'public',
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px"> $new_values = array(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->updated_profile_data['f'] => array(
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $d['f'] => array(
</ins><span class="cx" style="display: block; padding: 0 10px"> 'value' => 'foo2',
</span><span class="cx" style="display: block; padding: 0 10px"> 'visibility' => 'public',
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->assertFalse( bp_xprofile_updated_profile_activity( $d['u'], array( $d['f'] ), true ) );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $du = isset( $d['u'] ) ? $d['u'] : '';
+ $df = isset( $d['f'] ) ? $d['f'] : '';
+
+ $this->assertFalse( bp_xprofile_updated_profile_activity( $du, array( $df ), true ) );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -34,7 +56,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @group bp_xprofile_updated_profile_activity
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function test_bp_xprofile_updated_profile_activity_throttled() {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $d = $this->setup_updated_profile_data();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $d = self::$updated_profile_data;
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $time = time();
</span><span class="cx" style="display: block; padding: 0 10px"> $prev_time = date( 'Y-m-d H:i:s', $time - ( 119 * 60 ) );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -49,13 +71,13 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Fake new/old values to ensure a change
</span><span class="cx" style="display: block; padding: 0 10px"> $old_values = array(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->updated_profile_data['f'] => array(
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $d['f'] => array(
</ins><span class="cx" style="display: block; padding: 0 10px"> 'value' => 'foo',
</span><span class="cx" style="display: block; padding: 0 10px"> 'visibility' => 'public',
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px"> $new_values = array(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->updated_profile_data['f'] => array(
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $d['f'] => array(
</ins><span class="cx" style="display: block; padding: 0 10px"> 'value' => 'foo2',
</span><span class="cx" style="display: block; padding: 0 10px"> 'visibility' => 'public',
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -68,7 +90,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @group bp_xprofile_updated_profile_activity
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function test_bp_xprofile_updated_profile_activity_outside_of_throttle() {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $d = $this->setup_updated_profile_data();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $d = self::$updated_profile_data;
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $time = strtotime( bp_core_current_time() );
</span><span class="cx" style="display: block; padding: 0 10px"> $prev_time = date( 'Y-m-d H:i:s', $time - ( 121 * 60 ) );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -83,13 +105,13 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Fake new/old values to ensure a change
</span><span class="cx" style="display: block; padding: 0 10px"> $old_values = array(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->updated_profile_data['f'] => array(
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $d['f'] => array(
</ins><span class="cx" style="display: block; padding: 0 10px"> 'value' => 'foo',
</span><span class="cx" style="display: block; padding: 0 10px"> 'visibility' => 'public',
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px"> $new_values = array(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->updated_profile_data['f'] => array(
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $d['f'] => array(
</ins><span class="cx" style="display: block; padding: 0 10px"> 'value' => 'foo2',
</span><span class="cx" style="display: block; padding: 0 10px"> 'visibility' => 'public',
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -114,17 +136,17 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @group bp_xprofile_updated_profile_activity
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function test_bp_xprofile_updated_profile_activity_no_existing_activity() {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $d = $this->setup_updated_profile_data();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $d = self::$updated_profile_data;
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Fake new/old values to ensure a change
</span><span class="cx" style="display: block; padding: 0 10px"> $old_values = array(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->updated_profile_data['f'] => array(
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $d['f'] => array(
</ins><span class="cx" style="display: block; padding: 0 10px"> 'value' => 'foo',
</span><span class="cx" style="display: block; padding: 0 10px"> 'visibility' => 'public',
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px"> $new_values = array(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->updated_profile_data['f'] => array(
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $d['f'] => array(
</ins><span class="cx" style="display: block; padding: 0 10px"> 'value' => 'foo2',
</span><span class="cx" style="display: block; padding: 0 10px"> 'visibility' => 'public',
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -149,16 +171,16 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @group bp_xprofile_updated_profile_activity
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function test_bp_xprofile_updated_profile_activity_no_changes() {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $d = $this->setup_updated_profile_data();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $d = self::$updated_profile_data;
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $old_values = array(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->updated_profile_data['f'] => array(
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $d['f'] => array(
</ins><span class="cx" style="display: block; padding: 0 10px"> 'value' => 'foo',
</span><span class="cx" style="display: block; padding: 0 10px"> 'visibility' => 'public',
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px"> $new_values = array(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->updated_profile_data['f'] => array(
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $d['f'] => array(
</ins><span class="cx" style="display: block; padding: 0 10px"> 'value' => 'foo',
</span><span class="cx" style="display: block; padding: 0 10px"> 'visibility' => 'public',
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -171,16 +193,16 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @group bp_xprofile_updated_profile_activity
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function test_bp_xprofile_updated_profile_activity_no_public_changes() {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $d = $this->setup_updated_profile_data();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $d = self::$updated_profile_data;
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $old_values = array(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->updated_profile_data['f'] => array(
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $d['f'] => array(
</ins><span class="cx" style="display: block; padding: 0 10px"> 'value' => 'foo',
</span><span class="cx" style="display: block; padding: 0 10px"> 'visibility' => 'loggedin',
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px"> $new_values = array(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->updated_profile_data['f'] => array(
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $d['f'] => array(
</ins><span class="cx" style="display: block; padding: 0 10px"> 'value' => 'bar',
</span><span class="cx" style="display: block; padding: 0 10px"> 'visibility' => 'loggedin',
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -193,16 +215,16 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @group bp_xprofile_updated_profile_activity
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function test_bp_xprofile_updated_profile_activity_public_changed_to_private() {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $d = $this->setup_updated_profile_data();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $d = self::$updated_profile_data;
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $old_values = array(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->updated_profile_data['f'] => array(
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $d['f'] => array(
</ins><span class="cx" style="display: block; padding: 0 10px"> 'value' => 'foo',
</span><span class="cx" style="display: block; padding: 0 10px"> 'visibility' => 'public',
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px"> $new_values = array(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->updated_profile_data['f'] => array(
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $d['f'] => array(
</ins><span class="cx" style="display: block; padding: 0 10px"> 'value' => 'bar',
</span><span class="cx" style="display: block; padding: 0 10px"> 'visibility' => 'loggedin',
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -215,16 +237,16 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @group bp_xprofile_updated_profile_activity
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function test_bp_xprofile_updated_profile_activity_private_changed_to_public() {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $d = $this->setup_updated_profile_data();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $d = self::$updated_profile_data;
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $old_values = array(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->updated_profile_data['f'] => array(
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $d['f'] => array(
</ins><span class="cx" style="display: block; padding: 0 10px"> 'value' => 'foo',
</span><span class="cx" style="display: block; padding: 0 10px"> 'visibility' => 'loggedin',
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px"> $new_values = array(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->updated_profile_data['f'] => array(
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $d['f'] => array(
</ins><span class="cx" style="display: block; padding: 0 10px"> 'value' => 'foo',
</span><span class="cx" style="display: block; padding: 0 10px"> 'visibility' => 'public',
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -237,11 +259,11 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @group bp_xprofile_updated_profile_activity
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function test_bp_xprofile_updated_profile_activity_field_didnt_previously_exist() {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $d = $this->setup_updated_profile_data();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $d = self::$updated_profile_data;
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $old_values = array();
</span><span class="cx" style="display: block; padding: 0 10px"> $new_values = array(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->updated_profile_data['f'] => array(
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $d['f'] => array(
</ins><span class="cx" style="display: block; padding: 0 10px"> 'value' => 'bar',
</span><span class="cx" style="display: block; padding: 0 10px"> 'visibility' => 'public',
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -254,16 +276,16 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @group bp_xprofile_updated_profile_activity
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function test_bp_xprofile_updated_profile_activity_public_changes() {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $d = $this->setup_updated_profile_data();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $d = self::$updated_profile_data;
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $old_values = array(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->updated_profile_data['f'] => array(
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $d['f'] => array(
</ins><span class="cx" style="display: block; padding: 0 10px"> 'value' => 'foo',
</span><span class="cx" style="display: block; padding: 0 10px"> 'visibility' => 'public',
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px"> $new_values = array(
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $this->updated_profile_data['f'] => array(
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $d['f'] => array(
</ins><span class="cx" style="display: block; padding: 0 10px"> 'value' => 'bar',
</span><span class="cx" style="display: block; padding: 0 10px"> 'visibility' => 'public',
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -309,13 +331,4 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertSame( $expected, $a_obj->action );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-
- protected function setup_updated_profile_data() {
- $this->updated_profile_data['u'] = self::factory()->user->create();
- $this->updated_profile_data['g'] = self::factory()->xprofile_group->create();
- $this->updated_profile_data['f'] = self::factory()->xprofile_field->create( array(
- 'field_group_id' => $this->updated_profile_data['g'],
- ) );
-
- }
</del><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre>
</div>
</div>
</body>
</html>