<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][12524] trunk/src: Core/Nouveau: fix PHP Code standards in inline comments</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://buddypress.trac.wordpress.org/changeset/12524">12524</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://buddypress.trac.wordpress.org/changeset/12524","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>imath</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2020-01-18 11:32:41 +0000 (Sat, 18 Jan 2020)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Core/Nouveau: fix PHP Code standards in inline comments
Props passoniate
See <a href="http://buddypress.trac.wordpress.org/ticket/8213">#8213</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcbploaderphp">trunk/src/bp-loader.php</a></li>
<li><a href="#trunksrcbptemplatesbpnouveaubuddypressfunctionsphp">trunk/src/bp-templates/bp-nouveau/buddypress-functions.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcbploaderphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-loader.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-loader.php 2020-01-18 11:19:13 UTC (rev 12523)
+++ trunk/src/bp-loader.php 2020-01-18 11:32:41 UTC (rev 12524)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -26,7 +26,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * PHP supported by WordPress.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-// Exit if accessed directly
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+// Exit if accessed directly.
</ins><span class="cx" style="display: block; padding: 0 10px"> defined( 'ABSPATH' ) || exit;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Required PHP version.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -85,7 +85,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> if ( defined( 'BUDDYPRESS_LATE_LOAD' ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> add_action( 'plugins_loaded', 'buddypress', (int) BUDDYPRESS_LATE_LOAD );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // "And now here's something we hope you'll really like!"
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // "And now here's something we hope you'll really like!".
</ins><span class="cx" style="display: block; padding: 0 10px"> } else {
</span><span class="cx" style="display: block; padding: 0 10px"> $GLOBALS['bp'] = buddypress();
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre></div>
<a id="trunksrcbptemplatesbpnouveaubuddypressfunctionsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-templates/bp-nouveau/buddypress-functions.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-templates/bp-nouveau/buddypress-functions.php 2020-01-18 11:19:13 UTC (rev 12523)
+++ trunk/src/bp-templates/bp-nouveau/buddypress-functions.php 2020-01-18 11:32:41 UTC (rev 12524)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -170,29 +170,29 @@
</span><span class="cx" style="display: block; padding: 0 10px"> // We need to neutralize the BuddyPress core "bp_core_render_message()" once it has been added.
</span><span class="cx" style="display: block; padding: 0 10px"> add_action( 'bp_actions', array( $this, 'neutralize_core_template_notices' ), 6 );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Scripts
- add_action( 'bp_enqueue_scripts', array( $this, 'register_scripts' ), 2 ); // Register theme JS
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Scripts.
+ add_action( 'bp_enqueue_scripts', array( $this, 'register_scripts' ), 2 ); // Register theme JS.
</ins><span class="cx" style="display: block; padding: 0 10px"> remove_action( 'bp_enqueue_scripts', 'bp_core_confirmation_js' );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- add_action( 'bp_enqueue_scripts', array( $this, 'enqueue_styles' ) ); // Enqueue theme CSS
- add_action( 'bp_enqueue_scripts', array( $this, 'enqueue_scripts' ) ); // Enqueue theme JS
- add_filter( 'bp_enqueue_scripts', array( $this, 'localize_scripts' ) ); // Enqueue theme script localization
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ add_action( 'bp_enqueue_scripts', array( $this, 'enqueue_styles' ) ); // Enqueue theme CSS.
+ add_action( 'bp_enqueue_scripts', array( $this, 'enqueue_scripts' ) ); // Enqueue theme JS.
+ add_filter( 'bp_enqueue_scripts', array( $this, 'localize_scripts' ) ); // Enqueue theme script localization.
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Body no-js class
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Body no-js class.
</ins><span class="cx" style="display: block; padding: 0 10px"> add_filter( 'body_class', array( $this, 'add_nojs_body_class' ), 20, 1 );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Ajax querystring
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Ajax querystring.
</ins><span class="cx" style="display: block; padding: 0 10px"> add_filter( 'bp_ajax_querystring', 'bp_nouveau_ajax_querystring', 10, 2 );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Register directory nav items
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Register directory nav items.
</ins><span class="cx" style="display: block; padding: 0 10px"> add_action( 'bp_screens', array( $this, 'setup_directory_nav' ), 15 );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Register the Default front pages Dynamic Sidebars
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Register the Default front pages Dynamic Sidebars.
</ins><span class="cx" style="display: block; padding: 0 10px"> add_action( 'widgets_init', 'bp_nouveau_register_sidebars', 11 );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Register the Primary Object nav widget
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Register the Primary Object nav widget.
</ins><span class="cx" style="display: block; padding: 0 10px"> add_action( 'bp_widgets_init', array( 'BP_Nouveau_Object_Nav_Widget', 'register_widget' ) );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Set the BP Uri for the Ajax customizer preview
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Set the BP Uri for the Ajax customizer preview.
</ins><span class="cx" style="display: block; padding: 0 10px"> add_filter( 'bp_uri', array( $this, 'customizer_set_uri' ), 10, 1 );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /** Override **********************************************************/
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -317,7 +317,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> ),
</span><span class="cx" style="display: block; padding: 0 10px"> ) );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Bail if no scripts
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Bail if no scripts.
</ins><span class="cx" style="display: block; padding: 0 10px"> if ( empty( $scripts ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> return;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -430,7 +430,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'object_nav_parent' => '#buddypress',
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // If the Object/Item nav are in the sidebar
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // If the Object/Item nav are in the sidebar.
</ins><span class="cx" style="display: block; padding: 0 10px"> if ( bp_nouveau_is_object_nav_in_sidebar() ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $params['object_nav_parent'] = '.buddypress_object_nav';
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -459,11 +459,11 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $supported_objects = array_merge( $supported_objects, array( 'group_members', 'group_requests' ) );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Add components & nonces
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Add components & nonces.
</ins><span class="cx" style="display: block; padding: 0 10px"> $params['objects'] = $supported_objects;
</span><span class="cx" style="display: block; padding: 0 10px"> $params['nonces'] = $object_nonces;
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Used to transport the settings inside the Ajax requests
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Used to transport the settings inside the Ajax requests.
</ins><span class="cx" style="display: block; padding: 0 10px"> if ( is_customize_preview() ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $params['customizer_settings'] = bp_nouveau_get_temporary_setting( 'any' );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -602,7 +602,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> continue;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Define the primary nav for the current component's directory
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Define the primary nav for the current component's directory.
</ins><span class="cx" style="display: block; padding: 0 10px"> $this->directory_nav->add_nav( $nav_item );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre>
</div>
</div>
</body>
</html>