<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][12463] trunk: Improve the way BP REST API Controllers are loaded</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://buddypress.trac.wordpress.org/changeset/12463">12463</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://buddypress.trac.wordpress.org/changeset/12463","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>imath</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2019-09-25 23:22:00 +0000 (Wed, 25 Sep 2019)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Improve the way BP REST API Controllers are loaded
Introduce a new filter to allow site owners to eventually disable one or more BP REST API Controllers.
See <a href="http://buddypress.trac.wordpress.org/ticket/7156">#7156</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcbpactivityclassesclassbpactivitycomponentphp">trunk/src/bp-activity/classes/class-bp-activity-component.php</a></li>
<li><a href="#trunksrcbpcoreclassesclassbpcomponentphp">trunk/src/bp-core/classes/class-bp-component.php</a></li>
<li><a href="#trunksrcbpgroupsclassesclassbpgroupscomponentphp">trunk/src/bp-groups/classes/class-bp-groups-component.php</a></li>
<li><a href="#trunksrcbpmembersclassesclassbpmemberscomponentphp">trunk/src/bp-members/classes/class-bp-members-component.php</a></li>
<li><a href="#trunksrcbpmessagesclassesclassbpmessagescomponentphp">trunk/src/bp-messages/classes/class-bp-messages-component.php</a></li>
<li><a href="#trunksrcbpnotificationsclassesclassbpnotificationscomponentphp">trunk/src/bp-notifications/classes/class-bp-notifications-component.php</a></li>
<li><a href="#trunksrcbpxprofileclassesclassbpxprofilecomponentphp">trunk/src/bp-xprofile/classes/class-bp-xprofile-component.php</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li><a href="#trunktestsphpunitassetsbprestapicontrollersphp">trunk/tests/phpunit/assets/bp-rest-api-controllers.php</a></li>
<li><a href="#trunktestsphpunittestcasescoreclassbpcomponentphp">trunk/tests/phpunit/testcases/core/class-bp-component.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcbpactivityclassesclassbpactivitycomponentphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-activity/classes/class-bp-activity-component.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-activity/classes/class-bp-activity-component.php 2019-09-25 15:36:17 UTC (rev 12462)
+++ trunk/src/bp-activity/classes/class-bp-activity-component.php 2019-09-25 23:22:00 UTC (rev 12463)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -461,11 +461,11 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * Init the BP REST API.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 5.0.0
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ *
+ * @param array $controllers Optional. See BP_Component::rest_api_init() for
+ * description.
</ins><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- public function rest_api_init() {
- $controller = new BP_REST_Activity_Endpoint();
- $controller->register_routes();
-
- parent::rest_api_init();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ public function rest_api_init( $controllers = array() ) {
+ parent::rest_api_init( array( 'BP_REST_Activity_Endpoint' ) );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre></div>
<a id="trunksrcbpcoreclassesclassbpcomponentphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-core/classes/class-bp-component.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-core/classes/class-bp-component.php 2019-09-25 15:36:17 UTC (rev 12462)
+++ trunk/src/bp-core/classes/class-bp-component.php 2019-09-25 23:22:00 UTC (rev 12463)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -867,9 +867,36 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * Init the BP REST API.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 5.0.0
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ *
+ * @param array $controllers The list of BP REST controllers to load.
</ins><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- public function rest_api_init() {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ public function rest_api_init( $controllers = array() ) {
+ if ( is_array( $controllers ) && $controllers ) {
+ // Built-in controllers.
+ $_controllers = $controllers;
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /**
+ * Use this filter to disable all or some REST API controllers
+ * for the component.
+ *
+ * This is a dynamic hook that is based on the component string ID.
+ *
+ * @since 5.0.0
+ *
+ * @param array $controllers The list of BP REST API controllers to load.
+ */
+ $controllers = (array) apply_filters( 'bp_' . $this->id . '_rest_api_controllers', $controllers );
+
+ foreach( $controllers as $controller ) {
+ if ( ! in_array( $controller, $_controllers, true ) ) {
+ continue;
+ }
+
+ $component_controller = new $controller;
+ $component_controller->register_routes();
+ }
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * Fires in the rest_api_init method inside BP_Component.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span></span></pre></div>
<a id="trunksrcbpgroupsclassesclassbpgroupscomponentphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-groups/classes/class-bp-groups-component.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-groups/classes/class-bp-groups-component.php 2019-09-25 15:36:17 UTC (rev 12462)
+++ trunk/src/bp-groups/classes/class-bp-groups-component.php 2019-09-25 23:22:00 UTC (rev 12463)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -927,23 +927,17 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * Init the BP REST API.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 5.0.0
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ *
+ * @param array $controllers Optional. See BP_Component::rest_api_init() for
+ * description.
</ins><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- public function rest_api_init() {
- $controller = new BP_REST_Groups_Endpoint();
- $controller->register_routes();
-
- $controller = new BP_REST_Group_Membership_Endpoint();
- $controller->register_routes();
-
- $controller = new BP_REST_Group_Invites_Endpoint();
- $controller->register_routes();
-
- $controller = new BP_REST_Group_Membership_Request_Endpoint();
- $controller->register_routes();
-
- $controller = new BP_REST_Attachments_Group_Avatar_Endpoint();
- $controller->register_routes();
-
- parent::rest_api_init();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ public function rest_api_init( $controllers = array() ) {
+ parent::rest_api_init( array(
+ 'BP_REST_Groups_Endpoint',
+ 'BP_REST_Group_Membership_Endpoint',
+ 'BP_REST_Group_Invites_Endpoint',
+ 'BP_REST_Group_Membership_Request_Endpoint',
+ 'BP_REST_Attachments_Group_Avatar_Endpoint',
+ ) );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre></div>
<a id="trunksrcbpmembersclassesclassbpmemberscomponentphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-members/classes/class-bp-members-component.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-members/classes/class-bp-members-component.php 2019-09-25 15:36:17 UTC (rev 12462)
+++ trunk/src/bp-members/classes/class-bp-members-component.php 2019-09-25 23:22:00 UTC (rev 12463)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -461,21 +461,19 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * Init the BP REST API.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 5.0.0
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ *
+ * @param array $controllers Optional. See BP_Component::rest_api_init() for
+ * description.
</ins><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- public function rest_api_init() {
- /**
- * As the Members component is always loaded,
- * let's register the Components endpoint here.
- */
- $controller = new BP_REST_Components_Endpoint();
- $controller->register_routes();
-
- $controller = new BP_REST_Members_Endpoint();
- $controller->register_routes();
-
- $controller = new BP_REST_Attachments_Member_Avatar_Endpoint();
- $controller->register_routes();
-
- parent::rest_api_init();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ public function rest_api_init( $controllers = array() ) {
+ parent::rest_api_init( array(
+ /**
+ * As the Members component is always loaded,
+ * let's register the Components endpoint here.
+ */
+ 'BP_REST_Components_Endpoint',
+ 'BP_REST_Members_Endpoint',
+ 'BP_REST_Attachments_Member_Avatar_Endpoint',
+ ) );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre></div>
<a id="trunksrcbpmessagesclassesclassbpmessagescomponentphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-messages/classes/class-bp-messages-component.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-messages/classes/class-bp-messages-component.php 2019-09-25 15:36:17 UTC (rev 12462)
+++ trunk/src/bp-messages/classes/class-bp-messages-component.php 2019-09-25 23:22:00 UTC (rev 12463)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -438,11 +438,11 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * Init the BP REST API.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 5.0.0
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ *
+ * @param array $controllers Optional. See BP_Component::rest_api_init() for
+ * description.
</ins><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- public function rest_api_init() {
- $controller = new BP_REST_Messages_Endpoint();
- $controller->register_routes();
-
- parent::rest_api_init();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ public function rest_api_init( $controllers = array() ) {
+ parent::rest_api_init( array( 'BP_REST_Messages_Endpoint' ) );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre></div>
<a id="trunksrcbpnotificationsclassesclassbpnotificationscomponentphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-notifications/classes/class-bp-notifications-component.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-notifications/classes/class-bp-notifications-component.php 2019-09-25 15:36:17 UTC (rev 12462)
+++ trunk/src/bp-notifications/classes/class-bp-notifications-component.php 2019-09-25 23:22:00 UTC (rev 12463)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -320,11 +320,11 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * Init the BP REST API.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 5.0.0
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ *
+ * @param array $controllers Optional. See BP_Component::rest_api_init() for
+ * description.
</ins><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- public function rest_api_init() {
- $controller = new BP_REST_Notifications_Endpoint();
- $controller->register_routes();
-
- parent::rest_api_init();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ public function rest_api_init( $controllers = array() ) {
+ parent::rest_api_init( array( 'BP_REST_Notifications_Endpoint' ) );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre></div>
<a id="trunksrcbpxprofileclassesclassbpxprofilecomponentphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-xprofile/classes/class-bp-xprofile-component.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-xprofile/classes/class-bp-xprofile-component.php 2019-09-25 15:36:17 UTC (rev 12462)
+++ trunk/src/bp-xprofile/classes/class-bp-xprofile-component.php 2019-09-25 23:22:00 UTC (rev 12463)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -494,17 +494,15 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * Init the BP REST API.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 5.0.0
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ *
+ * @param array $controllers Optional. See BP_Component::rest_api_init() for
+ * description.
</ins><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- public function rest_api_init() {
- $controller = new BP_REST_XProfile_Fields_Endpoint();
- $controller->register_routes();
-
- $controller = new BP_REST_XProfile_Field_Groups_Endpoint();
- $controller->register_routes();
-
- $controller = new BP_REST_XProfile_Data_Endpoint();
- $controller->register_routes();
-
- parent::rest_api_init();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ public function rest_api_init( $controllers = array() ) {
+ parent::rest_api_init( array(
+ 'BP_REST_XProfile_Fields_Endpoint',
+ 'BP_REST_XProfile_Field_Groups_Endpoint',
+ 'BP_REST_XProfile_Data_Endpoint',
+ ) );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre></div>
<a id="trunktestsphpunitassetsbprestapicontrollersphp"></a>
<div class="addfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Added: trunk/tests/phpunit/assets/bp-rest-api-controllers.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/assets/bp-rest-api-controllers.php (rev 0)
+++ trunk/tests/phpunit/assets/bp-rest-api-controllers.php 2019-09-25 23:22:00 UTC (rev 12463)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -0,0 +1,54 @@
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+<?php
+/**
+ * BP REST Controllers' mocks
+ */
+
+class BP_REST_Mock_Class {
+ public function __construct() {}
+
+ public function register_routes( $controller = '' ) {
+ array_push( buddypress()->unit_test_rest->controllers, $controller );
+ }
+}
+
+/**
+ * BP Member Avatar REST Controller's mock.
+ */
+class BP_REST_Attachments_Member_Avatar_Endpoint extends BP_REST_Mock_Class {
+ public function __construct() {
+ $this->namespace = bp_rest_namespace() . '/' . bp_rest_version();
+ $this->rest_base = 'members';
+ }
+
+ public function register_routes( $controller = '' ) {
+ parent::register_routes( 'BP_REST_Attachments_Member_Avatar_Endpoint' );
+ }
+}
+
+/**
+ * BP Components REST Controller's mock.
+ */
+class BP_REST_Components_Endpoint extends BP_REST_Mock_Class {
+ public function __construct() {
+ $this->namespace = bp_rest_namespace() . '/' . bp_rest_version();
+ $this->rest_base = 'components';
+ }
+
+ public function register_routes( $controller = '' ) {
+ parent::register_routes( 'BP_REST_Components_Endpoint' );
+ }
+}
+
+/**
+ * BP Members REST Controller's mock.
+ */
+class BP_REST_Members_Endpoint extends BP_REST_Mock_Class {
+ public function __construct() {
+ $this->namespace = bp_rest_namespace() . '/' . bp_rest_version();
+ $this->rest_base = 'members';
+ }
+
+ public function register_routes( $controller = '' ) {
+ parent::register_routes( 'BP_REST_Members_Endpoint' );
+ }
+}
</ins><span class="cx" style="display: block; padding: 0 10px">Property changes on: trunk/tests/phpunit/assets/bp-rest-api-controllers.php
</span><span class="cx" style="display: block; padding: 0 10px">___________________________________________________________________
</span></span></pre></div>
<a id="svneolstyle"></a>
<div class="addfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Added: svn:eol-style</h4></div>
<ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+native
</ins><span class="cx" style="display: block; padding: 0 10px">\ No newline at end of property
</span><a id="trunktestsphpunittestcasescoreclassbpcomponentphp"></a>
<div class="addfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Added: trunk/tests/phpunit/testcases/core/class-bp-component.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/testcases/core/class-bp-component.php (rev 0)
+++ trunk/tests/phpunit/testcases/core/class-bp-component.php 2019-09-25 23:22:00 UTC (rev 12463)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -0,0 +1,71 @@
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+<?php
+
+include_once BP_TESTS_DIR . '/assets/bp-rest-api-controllers.php';
+
+/**
+ * @group core
+ * @group BP_Component
+ */
+class BP_Tests_BP_Component_TestCases extends BP_UnitTestCase {
+ public function setUp() {
+ parent::setUp();
+
+ $bp = buddypress();
+ $bp->unit_test_rest = new stdClass;
+ $bp->unit_test_rest->controllers = array();
+ }
+
+ public function remove_controller( $controllers ) {
+ return array_diff( $controllers, array( 'BP_REST_Members_Endpoint' ) );
+ }
+
+ public function add_controller( $controllers ) {
+ return array_merge( $controllers, array( 'Foo_Bar' ) );
+ }
+
+ public function test_rest_api_init_for_members_component() {
+ $bp_members = new BP_Members_Component();
+ $bp = buddypress();
+
+ $bp_members->rest_api_init();
+
+ $this->assertSame( $bp->unit_test_rest->controllers, array(
+ 'BP_REST_Components_Endpoint',
+ 'BP_REST_Members_Endpoint',
+ 'BP_REST_Attachments_Member_Avatar_Endpoint',
+ ) );
+ }
+
+ public function test_rest_api_init_for_members_component_can_remove_controller() {
+ $bp_members = new BP_Members_Component();
+ $bp = buddypress();
+
+ add_filter( 'bp_members_rest_api_controllers', array( $this, 'remove_controller' ) );
+
+ $bp_members->rest_api_init();
+
+ remove_filter( 'bp_members_rest_api_controllers', array( $this, 'remove_controller' ) );
+
+ $this->assertSame( $bp->unit_test_rest->controllers, array(
+ 'BP_REST_Components_Endpoint',
+ 'BP_REST_Attachments_Member_Avatar_Endpoint',
+ ) );
+ }
+
+ public function test_rest_api_init_for_members_component_cannot_add_controller() {
+ $bp_members = new BP_Members_Component();
+ $bp = buddypress();
+
+ add_filter( 'bp_members_rest_api_controllers', array( $this, 'add_controller' ) );
+
+ $bp_members->rest_api_init();
+
+ remove_filter( 'bp_members_rest_api_controllers', array( $this, 'add_controller' ) );
+
+ $this->assertSame( $bp->unit_test_rest->controllers, array(
+ 'BP_REST_Components_Endpoint',
+ 'BP_REST_Members_Endpoint',
+ 'BP_REST_Attachments_Member_Avatar_Endpoint',
+ ) );
+ }
+}
</ins><span class="cx" style="display: block; padding: 0 10px">Property changes on: trunk/tests/phpunit/testcases/core/class-bp-component.php
</span><span class="cx" style="display: block; padding: 0 10px">___________________________________________________________________
</span></span></pre></div>
<a id="svneolstyle"></a>
<div class="addfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Added: svn:eol-style</h4></div>
<ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+native
</ins><span class="cx" style="display: block; padding: 0 10px">\ No newline at end of property
</span></div>
</body>
</html>