<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][11906] trunk/src/bp-templates/bp-nouveau: Nouveau: Fix keyboard focus for hidden form controls.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { white-space: pre-line; overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://buddypress.trac.wordpress.org/changeset/11906">11906</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://buddypress.trac.wordpress.org/changeset/11906","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>mercime</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2018-03-21 15:01:04 +0000 (Wed, 21 Mar 2018)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Nouveau: Fix keyboard focus for hidden form controls.
This prevents loss of focus for keyboard users as they tab through the form
controls where initial state is hidden.
Fixes <a href="http://buddypress.trac.wordpress.org/ticket/7711">#7711</a>, <a href="http://buddypress.trac.wordpress.org/ticket/7720">#7720</a>. See <a href="http://buddypress.trac.wordpress.org/ticket/7714">#7714</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcbptemplatesbpnouveaucommonstyles_bpmixinsscss">trunk/src/bp-templates/bp-nouveau/common-styles/_bp-mixins.scss</a></li>
<li><a href="#trunksrcbptemplatesbpnouveaucommonstyles_bp_searchscss">trunk/src/bp-templates/bp-nouveau/common-styles/_bp_search.scss</a></li>
<li><a href="#trunksrcbptemplatesbpnouveaucssbuddypressrtlcss">trunk/src/bp-templates/bp-nouveau/css/buddypress-rtl.css</a></li>
<li><a href="#trunksrcbptemplatesbpnouveaucssbuddypresscss">trunk/src/bp-templates/bp-nouveau/css/buddypress.css</a></li>
<li><a href="#trunksrcbptemplatesbpnouveaujsbuddypressgroupinvitesjs">trunk/src/bp-templates/bp-nouveau/js/buddypress-group-invites.js</a></li>
<li><a href="#trunksrcbptemplatesbpnouveaujsbuddypressmessagesjs">trunk/src/bp-templates/bp-nouveau/js/buddypress-messages.js</a></li>
<li><a href="#trunksrcbptemplatesbpnouveaujsbuddypressnouveaujs">trunk/src/bp-templates/bp-nouveau/js/buddypress-nouveau.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcbptemplatesbpnouveaucommonstyles_bpmixinsscss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-templates/bp-nouveau/common-styles/_bp-mixins.scss</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-templates/bp-nouveau/common-styles/_bp-mixins.scss 2018-03-20 12:34:32 UTC (rev 11905)
+++ trunk/src/bp-templates/bp-nouveau/common-styles/_bp-mixins.scss 2018-03-21 15:01:04 UTC (rev 11906)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -147,11 +147,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> // Convenience helper to add hide properties to rulesets
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> @mixin hide() {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- height: 0;
- left: -999em;
- overflow: hidden;
- position: absolute;
- top: -999em;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ display: none;
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // companion mixins properties for showing the element for :focus/:hover
</span></span></pre></div>
<a id="trunksrcbptemplatesbpnouveaucommonstyles_bp_searchscss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-templates/bp-nouveau/common-styles/_bp_search.scss</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-templates/bp-nouveau/common-styles/_bp_search.scss 2018-03-20 12:34:32 UTC (rev 11905)
+++ trunk/src/bp-templates/bp-nouveau/common-styles/_bp_search.scss 2018-03-21 15:01:04 UTC (rev 11906)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -54,12 +54,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // For non no-js we'll add back in show() further down.
- button[type="submit"] {
-
- @include hide();
- }
-
</del><span class="cx" style="display: block; padding: 0 10px"> button[type="submit"].bp-show {
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> @include show();
</span></span></pre></div>
<a id="trunksrcbptemplatesbpnouveaucssbuddypressrtlcss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-templates/bp-nouveau/css/buddypress-rtl.css</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-templates/bp-nouveau/css/buddypress-rtl.css 2018-03-20 12:34:32 UTC (rev 11905)
+++ trunk/src/bp-templates/bp-nouveau/css/buddypress-rtl.css 2018-03-21 15:01:04 UTC (rev 11906)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -3573,16 +3573,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> line-height: 1.6;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-.buddypress-wrap form.bp-dir-search-form button[type="submit"],
-.buddypress-wrap form.bp-messages-search-form button[type="submit"],
-.buddypress-wrap form.bp-invites-search-form button[type="submit"] {
- height: 0;
- right: -999em;
- overflow: hidden;
- position: absolute;
- top: -999em;
-}
-
</del><span class="cx" style="display: block; padding: 0 10px"> .buddypress-wrap form.bp-dir-search-form button[type="submit"].bp-show,
</span><span class="cx" style="display: block; padding: 0 10px"> .buddypress-wrap form.bp-messages-search-form button[type="submit"].bp-show,
</span><span class="cx" style="display: block; padding: 0 10px"> .buddypress-wrap form.bp-invites-search-form button[type="submit"].bp-show {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -3818,11 +3808,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> .bp-hide {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- height: 0;
- right: -999em;
- overflow: hidden;
- position: absolute;
- top: -999em;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ display: none;
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> .bp-show {
</span></span></pre></div>
<a id="trunksrcbptemplatesbpnouveaucssbuddypresscss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-templates/bp-nouveau/css/buddypress.css</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-templates/bp-nouveau/css/buddypress.css 2018-03-20 12:34:32 UTC (rev 11905)
+++ trunk/src/bp-templates/bp-nouveau/css/buddypress.css 2018-03-21 15:01:04 UTC (rev 11906)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -3573,16 +3573,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> line-height: 1.6;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-.buddypress-wrap form.bp-dir-search-form button[type="submit"],
-.buddypress-wrap form.bp-messages-search-form button[type="submit"],
-.buddypress-wrap form.bp-invites-search-form button[type="submit"] {
- height: 0;
- left: -999em;
- overflow: hidden;
- position: absolute;
- top: -999em;
-}
-
</del><span class="cx" style="display: block; padding: 0 10px"> .buddypress-wrap form.bp-dir-search-form button[type="submit"].bp-show,
</span><span class="cx" style="display: block; padding: 0 10px"> .buddypress-wrap form.bp-messages-search-form button[type="submit"].bp-show,
</span><span class="cx" style="display: block; padding: 0 10px"> .buddypress-wrap form.bp-invites-search-form button[type="submit"].bp-show {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -3818,11 +3808,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> .bp-hide {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- height: 0;
- left: -999em;
- overflow: hidden;
- position: absolute;
- top: -999em;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ display: none;
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> .bp-show {
</span></span></pre></div>
<a id="trunksrcbptemplatesbpnouveaujsbuddypressgroupinvitesjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-templates/bp-nouveau/js/buddypress-group-invites.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-templates/bp-nouveau/js/buddypress-group-invites.js 2018-03-20 12:34:32 UTC (rev 11905)
+++ trunk/src/bp-templates/bp-nouveau/js/buddypress-group-invites.js 2018-03-21 15:01:04 UTC (rev 11906)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -489,8 +489,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> template: bp.template( 'bp-invites-filters' ),
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> events : {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'focus #group_invites_search' : 'displaySrcBtn',
- 'blur #group_invites_search' : 'hideSrcBtn',
</del><span class="cx" style="display: block; padding: 0 10px"> 'search #group_invites_search' : 'resetSearchTerms',
</span><span class="cx" style="display: block; padding: 0 10px"> 'submit #group_invites_search_form' : 'setSearchTerms',
</span><span class="cx" style="display: block; padding: 0 10px"> 'click #bp-invites-next-page' : 'nextPage',
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -530,22 +528,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> bp.Nouveau.GroupInvites.displayFeedback( response.feedback, 'error' );
</span><span class="cx" style="display: block; padding: 0 10px"> },
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- displaySrcBtn: function( event ) {
- event.preventDefault();
-
- $( event.target ).closest( 'form' ).find( '[type=submit]' ).addClass('bp-show');
- },
-
- hideSrcBtn: function( event ) {
- event.preventDefault();
-
- if ( $( event.target ).val() ) {
- return;
- }
-
- $( event.target ).closest( 'form' ).find( '[type=submit]' ).addClass('bp-hide').removeClass('bp-show');
- },
-
</del><span class="cx" style="display: block; padding: 0 10px"> resetSearchTerms: function( event ) {
</span><span class="cx" style="display: block; padding: 0 10px"> event.preventDefault();
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunksrcbptemplatesbpnouveaujsbuddypressmessagesjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-templates/bp-nouveau/js/buddypress-messages.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-templates/bp-nouveau/js/buddypress-messages.js 2018-03-20 12:34:32 UTC (rev 11905)
+++ trunk/src/bp-templates/bp-nouveau/js/buddypress-messages.js 2018-03-21 15:01:04 UTC (rev 11906)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1007,8 +1007,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> template: bp.template( 'bp-messages-filters' ),
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> events : {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'focus #user_messages_search' : 'displaySrcBtn',
- 'blur #user_messages_search' : 'hideSrcBtn',
</del><span class="cx" style="display: block; padding: 0 10px"> 'search #user_messages_search' : 'resetSearchTerms',
</span><span class="cx" style="display: block; padding: 0 10px"> 'submit #user_messages_search_form' : 'setSearchTerms',
</span><span class="cx" style="display: block; padding: 0 10px"> 'click #bp-messages-next-page' : 'nextPage',
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1056,22 +1054,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> bp.Nouveau.Messages.displayFeedback( response.feedback, response.type );
</span><span class="cx" style="display: block; padding: 0 10px"> },
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- displaySrcBtn: function( event ) {
- event.preventDefault();
-
- $( event.target ).closest( 'form' ).find( '[type=submit]' ).addClass('bp-show').removeClass('bp-hide');
- },
-
- hideSrcBtn: function( event ) {
- event.preventDefault();
-
- if ( $( event.target ).val() ) {
- return;
- }
-
- $( event.target ).closest( 'form' ).find( '[type=submit]' ).addClass('bp-hide').removeClass('bp-show');
- },
-
</del><span class="cx" style="display: block; padding: 0 10px"> resetSearchTerms: function( event ) {
</span><span class="cx" style="display: block; padding: 0 10px"> event.preventDefault();
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunksrcbptemplatesbpnouveaujsbuddypressnouveaujs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-templates/bp-nouveau/js/buddypress-nouveau.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-templates/bp-nouveau/js/buddypress-nouveau.js 2018-03-20 12:34:32 UTC (rev 11905)
+++ trunk/src/bp-templates/bp-nouveau/js/buddypress-nouveau.js 2018-03-21 15:01:04 UTC (rev 11906)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -487,8 +487,6 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Searching
</span><span class="cx" style="display: block; padding: 0 10px"> $( '#buddypress [data-bp-search]' ).on( 'submit', 'form', this, this.searchQuery );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $( '#buddypress [data-bp-search]' ).on( 'focus', 'input[type=search]', this.showSearchSubmit );
- $( '#buddypress [data-bp-search]' ).on( 'blur', 'input[type=search]', this.hideSearchSubmit );
</del><span class="cx" style="display: block; padding: 0 10px"> $( '#buddypress [data-bp-search] form' ).on( 'search', 'input[type=search]', this.resetSearch );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Buttons
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -674,17 +672,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> },
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * [hideSearchSubmit description]
- * @param {[type]} event [description]
- * @return {[type]} [description]
- */
- hideSearchSubmit: function( event ) {
- if ( ! $( event.target ).val() ) {
- $( event.delegateTarget ).find( '[type=submit]' ).addClass('bp-hide').removeClass('bp-show');
- }
- },
-
- /**
</del><span class="cx" style="display: block; padding: 0 10px"> * [resetSearch description]
</span><span class="cx" style="display: block; padding: 0 10px"> * @param {[type]} event [description]
</span><span class="cx" style="display: block; padding: 0 10px"> * @return {[type]} [description]
</span></span></pre>
</div>
</div>
</body>
</html>