<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][11780] trunk/src: Groups: reinstate functions `bp_is_group_forums_active()`, `bp_group_new_topic_button()`, `bp_get_group_new_topic_button()`.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://buddypress.trac.wordpress.org/changeset/11780">11780</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://buddypress.trac.wordpress.org/changeset/11780","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>djpaul</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2018-01-02 13:04:42 +0000 (Tue, 02 Jan 2018)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Groups: reinstate functions `bp_is_group_forums_active()`, `bp_group_new_topic_button()`, `bp_get_group_new_topic_button()`.
The first function has been reinstated for compatibility with third-party plugins, "BuddyPress for Sensei" and "BuddyPress for LearnDash".
The latter two functions rendered a "new topic" button on a Group screen.
Current proposal is that bbPress is updated to add this back, because otherwise we have to make assumptions about bbPress' permalinks, or rely on calling a bbPress function (which feels conceptually wrong from an integration perspective).
Also fix a PHP Notice caused by an incomplete prior removal of `bp_group_new_topic_button()` (see `bp-legacy/buddypress-functions.php`).
See <a href="http://buddypress.trac.wordpress.org/ticket/5351">#5351</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcbpcorebpcoreoptionsphp">trunk/src/bp-core/bp-core-options.php</a></li>
<li><a href="#trunksrcbpgroupsbpgroupstemplatephp">trunk/src/bp-groups/bp-groups-template.php</a></li>
<li><a href="#trunksrcbptemplatesbplegacybuddypressfunctionsphp">trunk/src/bp-templates/bp-legacy/buddypress-functions.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcbpcorebpcoreoptionsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-core/bp-core-options.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-core/bp-core-options.php 2018-01-02 10:20:02 UTC (rev 11779)
+++ trunk/src/bp-core/bp-core-options.php 2018-01-02 13:04:42 UTC (rev 11780)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -689,6 +689,31 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * Check whether bbPress plugin-powered Group Forums are enabled.
+ *
+ * @since 1.6.0
+ * @since 3.0.0 $default argument's default value changed from true to false.
+ * @deprecated 3.0.0 No longer used in core, but supported for third-party code.
+ *
+ * @param bool $default Optional. Fallback value if not found in the database.
+ * Default: false.
+ * @return bool True if group forums are active, otherwise false.
+ */
+function bp_is_group_forums_active( $default = false ) {
+ $is_active = function_exists( 'bbp_is_group_forums_active' ) ? bbp_is_group_forums_active( $default ) : $default;
+
+ /**
+ * Filters whether or not bbPress plugin-powered Group Forums are enabled.
+ *
+ * @since 1.6.0
+ * @deprecated 3.0.0 No longer used in core, but supported for third-party code.
+ *
+ * @param bool $value Whether or not bbPress plugin-powered Group Forums are enabled.
+ */
+ return (bool) apply_filters( 'bp_is_group_forums_active', $is_active );
+}
+
+/**
</ins><span class="cx" style="display: block; padding: 0 10px"> * Check whether Akismet is enabled.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 1.6.0
</span></span></pre></div>
<a id="trunksrcbpgroupsbpgroupstemplatephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-groups/bp-groups-template.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-groups/bp-groups-template.php 2018-01-02 10:20:02 UTC (rev 11779)
+++ trunk/src/bp-groups/bp-groups-template.php 2018-01-02 13:04:42 UTC (rev 11780)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -3189,6 +3189,31 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * Output a 'New Topic' button for a group.
+ *
+ * @since 1.2.7
+ * @deprecated 3.0.0 No longer used in core, but supported for third-party code.
+ *
+ * @param BP_Groups_Group|bool $group The BP Groups_Group object if passed, boolean false if not passed.
+ */
+function bp_group_new_topic_button( $group = false ) {
+}
+
+ /**
+ * Return a 'New Topic' button for a group.
+ *
+ * @since 1.2.7
+ * @deprecated 3.0.0 No longer used in core, but supported for third-party code.
+ *
+ * @param BP_Groups_Group|bool $group The BP Groups_Group object if passed, boolean false if not passed.
+ *
+ * @return false
+ */
+ function bp_get_group_new_topic_button( $group = false ) {
+ return false;
+ }
+
+/**
</ins><span class="cx" style="display: block; padding: 0 10px"> * Output button to join a group.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 1.0.0
</span></span></pre></div>
<a id="trunksrcbptemplatesbplegacybuddypressfunctionsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-templates/bp-legacy/buddypress-functions.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-templates/bp-legacy/buddypress-functions.php 2018-01-02 10:20:02 UTC (rev 11779)
+++ trunk/src/bp-templates/bp-legacy/buddypress-functions.php 2018-01-02 13:04:42 UTC (rev 11780)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -106,7 +106,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> // Group buttons.
</span><span class="cx" style="display: block; padding: 0 10px"> if ( bp_is_active( 'groups' ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> add_action( 'bp_group_header_actions', 'bp_group_join_button', 5 );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- add_action( 'bp_group_header_actions', 'bp_group_new_topic_button', 20 );
</del><span class="cx" style="display: block; padding: 0 10px"> add_action( 'bp_directory_groups_actions', 'bp_group_join_button' );
</span><span class="cx" style="display: block; padding: 0 10px"> add_action( 'bp_groups_directory_group_filter', 'bp_legacy_theme_group_create_nav', 999 );
</span><span class="cx" style="display: block; padding: 0 10px"> add_action( 'bp_after_group_admin_content', 'bp_legacy_groups_admin_screen_hidden_input' );
</span></span></pre>
</div>
</div>
</body>
</html>