<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][11774] branches/2.9: Remove calls to `create_function()`.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://buddypress.trac.wordpress.org/changeset/11774">11774</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://buddypress.trac.wordpress.org/changeset/11774","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>boonebgorges</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2017-12-13 01:16:42 +0000 (Wed, 13 Dec 2017)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Remove calls to `create_function()`.
`create_function()` is deprecated in PHP 7.2.
Merges <a href="http://buddypress.trac.wordpress.org/changeset/11773">[11773]</a> to the 2.9 branch.
See <a href="http://buddypress.trac.wordpress.org/ticket/7634">#7634</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#branches29srcbpcoredeprecated16php">branches/2.9/src/bp-core/deprecated/1.6.php</a></li>
<li><a href="#branches29srcbpgroupsclassesclassbpgroupextensionphp">branches/2.9/src/bp-groups/classes/class-bp-group-extension.php</a></li>
<li><a href="#branches29srcbpmembersbpmembersscreensphp">branches/2.9/src/bp-members/bp-members-screens.php</a></li>
<li><a href="#branches29srcbptemplatesbplegacybuddypressfunctionsphp">branches/2.9/src/bp-templates/bp-legacy/buddypress-functions.php</a></li>
</ul>
<h3>Property Changed</h3>
<ul>
<li><a href="#branches29">branches/2.9/</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<span class="cx" style="display: block; padding: 0 10px">Index: branches/2.9
</span><span class="cx" style="display: block; padding: 0 10px">===================================================================
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">--- branches/2.9 2017-12-13 01:13:51 UTC (rev 11773)
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+++ branches/2.9 2017-12-13 01:16:42 UTC (rev 11774)
</ins><a id="branches29"></a>
<div class="propset"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Property changes: branches/2.9</h4>
<pre class="diff"><span>
</span></pre></div>
<a id="svnmergeinfo"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: svn:mergeinfo</h4></div>
<span class="cx" style="display: block; padding: 0 10px"> /branches/1.5:5187,5203,5210-5216,5220,5225,5247,5635
</span><span class="cx" style="display: block; padding: 0 10px"> /branches/2.4:10363
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-/trunk:11720-11721,11723,11725,11727,11729,11768
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+/trunk:11720-11721,11723,11725,11727,11729,11768,11773
</ins><span class="cx" style="display: block; padding: 0 10px">\ No newline at end of property
</span><a id="branches29srcbpcoredeprecated16php"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: branches/2.9/src/bp-core/deprecated/1.6.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- branches/2.9/src/bp-core/deprecated/1.6.php 2017-12-13 01:13:51 UTC (rev 11773)
+++ branches/2.9/src/bp-core/deprecated/1.6.php 2017-12-13 01:16:42 UTC (rev 11774)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -265,8 +265,13 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // For each of the problematic hooks, exit at the very end of execution
</span><span class="cx" style="display: block; padding: 0 10px"> foreach( $actions as $action ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- add_action( 'wp_ajax_' . $action, create_function( '', 'exit;' ), 9999 );
- add_action( 'wp_ajax_nopriv_' . $action, create_function( '', 'exit;' ), 9999 );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ add_action( 'wp_ajax_' . $action, function() {
+ exit;
+ }, 9999 );
+
+ add_action( 'wp_ajax_nopriv_' . $action, function() {
+ exit;
+ }, 9999 );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> add_action( 'after_setup_theme', 'bp_die_legacy_ajax_callbacks', 20 );
</span></span></pre></div>
<a id="branches29srcbpgroupsclassesclassbpgroupextensionphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: branches/2.9/src/bp-groups/classes/class-bp-group-extension.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- branches/2.9/src/bp-groups/classes/class-bp-group-extension.php 2017-12-13 01:13:51 UTC (rev 11773)
+++ branches/2.9/src/bp-groups/classes/class-bp-group-extension.php 2017-12-13 01:16:42 UTC (rev 11774)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -753,8 +753,14 @@
</span><span class="cx" style="display: block; padding: 0 10px"> // When we are viewing the extension display page, set the title and options title.
</span><span class="cx" style="display: block; padding: 0 10px"> if ( bp_is_current_action( $this->slug ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> add_filter( 'bp_group_user_has_access', array( $this, 'group_access_protection' ), 10, 2 );
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- add_action( 'bp_template_content_header', create_function( '', 'echo "' . esc_attr( $this->name ) . '";' ) );
- add_action( 'bp_template_title', create_function( '', 'echo "' . esc_attr( $this->name ) . '";' ) );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+ $extension_name = $this->name;
+ add_action( 'bp_template_content_header', function() use ( $extension_name ) {
+ echo esc_attr( $extension_name );
+ } );
+ add_action( 'bp_template_title', function() use ( $extension_name ) {
+ echo esc_attr( $extension_name );
+ } );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1196,10 +1202,15 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $group_id = isset( $_GET['gid'] ) ? (int) $_GET['gid'] : 0;
</span><span class="cx" style="display: block; padding: 0 10px"> $screen = $this->screens['admin'];
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $extension_slug = $this->slug;
+ $callback = function() use ( $extension_slug, $group_id ) {
+ do_action( 'bp_groups_admin_meta_box_content_' . $extension_slug, $group_id );
+ };
+
</ins><span class="cx" style="display: block; padding: 0 10px"> add_meta_box(
</span><span class="cx" style="display: block; padding: 0 10px"> $screen['slug'],
</span><span class="cx" style="display: block; padding: 0 10px"> $screen['name'],
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- create_function( '', 'do_action( "bp_groups_admin_meta_box_content_' . $this->slug . '", ' . $group_id . ' );' ),
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $callback,
</ins><span class="cx" style="display: block; padding: 0 10px"> get_current_screen()->id,
</span><span class="cx" style="display: block; padding: 0 10px"> $screen['metabox_context'],
</span><span class="cx" style="display: block; padding: 0 10px"> $screen['metabox_priority']
</span></span></pre></div>
<a id="branches29srcbpmembersbpmembersscreensphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: branches/2.9/src/bp-members/bp-members-screens.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- branches/2.9/src/bp-members/bp-members-screens.php 2017-12-13 01:13:51 UTC (rev 11773)
+++ branches/2.9/src/bp-members/bp-members-screens.php 2017-12-13 01:16:42 UTC (rev 11774)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -183,11 +183,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> // Add any errors to the action for the field in the template for display.
</span><span class="cx" style="display: block; padding: 0 10px"> if ( !empty( $bp->signup->errors ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> foreach ( (array) $bp->signup->errors as $fieldname => $error_message ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- /*
- * The addslashes() and stripslashes() used to avoid create_function()
- * syntax errors when the $error_message contains quotes.
- */
-
</del><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * Filters the error message in the loop.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -195,7 +190,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @param string $value Error message wrapped in html.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- add_action( 'bp_' . $fieldname . '_errors', create_function( '', 'echo apply_filters(\'bp_members_signup_error_message\', "<div class=\"error\">" . stripslashes( \'' . addslashes( $error_message ) . '\' ) . "</div>" );' ) );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ add_action( 'bp_' . $fieldname . '_errors', function() use ( $error_message ) {
+ echo apply_filters( 'bp_members_signup_error_message', "<div class=\"error\">" . $error_message . "</div>" );
+ } );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> } else {
</span><span class="cx" style="display: block; padding: 0 10px"> $bp->signup->step = 'save-details';
</span></span></pre></div>
<a id="branches29srcbptemplatesbplegacybuddypressfunctionsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: branches/2.9/src/bp-templates/bp-legacy/buddypress-functions.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- branches/2.9/src/bp-templates/bp-legacy/buddypress-functions.php 2017-12-13 01:13:51 UTC (rev 11773)
+++ branches/2.9/src/bp-templates/bp-legacy/buddypress-functions.php 2017-12-13 01:16:42 UTC (rev 11774)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1611,10 +1611,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> bp_messages_embed();
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Add new-message css class.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- add_filter( 'bp_get_the_thread_message_css_class', create_function( '$retval', '
- $retval[] = "new-message";
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ add_filter( 'bp_get_the_thread_message_css_class', function( $retval ) {
+ $retval[] = 'new-message';
</ins><span class="cx" style="display: block; padding: 0 10px"> return $retval;
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- ' ) );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ } );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Output single message template part.
</span><span class="cx" style="display: block; padding: 0 10px"> bp_get_template_part( 'members/single/messages/message' );
</span></span></pre>
</div>
</div>
</body>
</html>