<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][11719] trunk/src/bp-templates/bp-nouveau/buddypress: Accessibility: Replace `<a href="#">` with Semantic Elements.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://buddypress.trac.wordpress.org/changeset/11719">11719</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://buddypress.trac.wordpress.org/changeset/11719","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>mercime</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2017-11-01 21:01:03 +0000 (Wed, 01 Nov 2017)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Accessibility: Replace `<a href="#">` with Semantic Elements.
Using semantic markup like the `button` which is specifically meant for controlling a user interface instead of a fragment identifier separator `#` value with the `href` attribute, helps assistive technologies identify the real purpose of the UI element across all browsers and all devices.
Fixes <a href="http://buddypress.trac.wordpress.org/ticket/7612">#7612</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcbptemplatesbpnouveaubuddypressassets_attachmentsavatarscameraphp">trunk/src/bp-templates/bp-nouveau/buddypress/assets/_attachments/avatars/camera.php</a></li>
<li><a href="#trunksrcbptemplatesbpnouveaubuddypressassets_attachmentsavatarscropphp">trunk/src/bp-templates/bp-nouveau/buddypress/assets/_attachments/avatars/crop.php</a></li>
<li><a href="#trunksrcbptemplatesbpnouveaubuddypressassets_attachmentsavatarsindexphp">trunk/src/bp-templates/bp-nouveau/buddypress/assets/_attachments/avatars/index.php</a></li>
<li><a href="#trunksrcbptemplatesbpnouveaubuddypressassets_attachmentscoverimagesindexphp">trunk/src/bp-templates/bp-nouveau/buddypress/assets/_attachments/cover-images/index.php</a></li>
<li><a href="#trunksrcbptemplatesbpnouveaubuddypresscommonjstemplatesactivityformphp">trunk/src/bp-templates/bp-nouveau/buddypress/common/js-templates/activity/form.php</a></li>
<li><a href="#trunksrcbptemplatesbpnouveaubuddypresscommonjstemplatesinvitesindexphp">trunk/src/bp-templates/bp-nouveau/buddypress/common/js-templates/invites/index.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcbptemplatesbpnouveaubuddypressassets_attachmentsavatarscameraphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-templates/bp-nouveau/buddypress/assets/_attachments/avatars/camera.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-templates/bp-nouveau/buddypress/assets/_attachments/avatars/camera.php 2017-11-01 20:06:29 UTC (rev 11718)
+++ trunk/src/bp-templates/bp-nouveau/buddypress/assets/_attachments/avatars/camera.php 2017-11-01 21:01:03 UTC (rev 11719)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -18,8 +18,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> <div class="avatar-crop-management">
</span><span class="cx" style="display: block; padding: 0 10px"> <div id="avatar-crop-pane" class="avatar" style="width:{{data.w}}px; height:{{data.h}}px"></div>
</span><span class="cx" style="display: block; padding: 0 10px"> <div id="avatar-crop-actions">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <a class="button avatar-webcam-capture" href="#"><?php esc_html_e( 'Capture', 'buddypress' );?></a>
- <a class="button avatar-webcam-save" href="#"><?php esc_html_e( 'Save', 'buddypress' );?></a>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <button type="button" class="button avatar-webcam-capture"><?php esc_html_e( 'Capture', 'buddypress' );?></button>
+ <button type="button" class="button avatar-webcam-save"><?php esc_html_e( 'Save', 'buddypress' );?></button>
</ins><span class="cx" style="display: block; padding: 0 10px"> </div>
</span><span class="cx" style="display: block; padding: 0 10px"> </div>
</span><span class="cx" style="display: block; padding: 0 10px"> <# } #>
</span></span></pre></div>
<a id="trunksrcbptemplatesbpnouveaubuddypressassets_attachmentsavatarscropphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-templates/bp-nouveau/buddypress/assets/_attachments/avatars/crop.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-templates/bp-nouveau/buddypress/assets/_attachments/avatars/crop.php 2017-11-01 20:06:29 UTC (rev 11718)
+++ trunk/src/bp-templates/bp-nouveau/buddypress/assets/_attachments/avatars/crop.php 2017-11-01 21:01:03 UTC (rev 11719)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -17,7 +17,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> <img src="{{data.url}}" id="avatar-crop-preview"/>
</span><span class="cx" style="display: block; padding: 0 10px"> </div>
</span><span class="cx" style="display: block; padding: 0 10px"> <div id="avatar-crop-actions">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <a class="button avatar-crop-submit" href="#"><?php esc_html_e( 'Crop Image', 'buddypress' ); ?></a>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <button type="button" class="button avatar-crop-submit"><?php esc_html_e( 'Crop Image', 'buddypress' ); ?></button>
</ins><span class="cx" style="display: block; padding: 0 10px"> </div>
</span><span class="cx" style="display: block; padding: 0 10px"> </div>
</span><span class="cx" style="display: block; padding: 0 10px"> </script>
</span></span></pre></div>
<a id="trunksrcbptemplatesbpnouveaubuddypressassets_attachmentsavatarsindexphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-templates/bp-nouveau/buddypress/assets/_attachments/avatars/index.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-templates/bp-nouveau/buddypress/assets/_attachments/avatars/index.php 2017-11-01 20:06:29 UTC (rev 11718)
+++ trunk/src/bp-templates/bp-nouveau/buddypress/assets/_attachments/avatars/index.php 2017-11-01 21:01:03 UTC (rev 11719)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -32,10 +32,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> <script id="tmpl-bp-avatar-delete" type="text/html">
</span><span class="cx" style="display: block; padding: 0 10px"> <# if ( 'user' === data.object ) { #>
</span><span class="cx" style="display: block; padding: 0 10px"> <p><?php _e( "If you'd like to delete your current profile photo but not upload a new one, please use the delete profile photo button.", 'buddypress' ); ?></p>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <p><a class="button edit" id="bp-delete-avatar" href="#"><?php esc_html_e( 'Delete My Profile Photo', 'buddypress' ); ?></a></p>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <button type="button" class="button edit" id="bp-delete-avatar"><?php esc_html_e( 'Delete My Profile Photo', 'buddypress' ); ?></button>
</ins><span class="cx" style="display: block; padding: 0 10px"> <# } else if ( 'group' === data.object ) { #>
</span><span class="cx" style="display: block; padding: 0 10px"> <?php bp_nouveau_user_feedback( 'group-avatar-delete-info' ); ?>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <p><a class="button edit" id="bp-delete-avatar" href="#"><?php esc_html_e( 'Delete Group Profile Photo', 'buddypress' ); ?></a></p>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <button type="button" class="button edit" id="bp-delete-avatar"><?php esc_html_e( 'Delete Group Profile Photo', 'buddypress' ); ?></button>
</ins><span class="cx" style="display: block; padding: 0 10px"> <# } else { #>
</span><span class="cx" style="display: block; padding: 0 10px"> <?php do_action( 'bp_attachments_avatar_delete_template' ); ?>
</span><span class="cx" style="display: block; padding: 0 10px"> <# } #>
</span></span></pre></div>
<a id="trunksrcbptemplatesbpnouveaubuddypressassets_attachmentscoverimagesindexphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-templates/bp-nouveau/buddypress/assets/_attachments/cover-images/index.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-templates/bp-nouveau/buddypress/assets/_attachments/cover-images/index.php 2017-11-01 20:06:29 UTC (rev 11718)
+++ trunk/src/bp-templates/bp-nouveau/buddypress/assets/_attachments/cover-images/index.php 2017-11-01 21:01:03 UTC (rev 11719)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -21,10 +21,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> <script id="tmpl-bp-cover-image-delete" type="text/html">
</span><span class="cx" style="display: block; padding: 0 10px"> <# if ( 'user' === data.object ) { #>
</span><span class="cx" style="display: block; padding: 0 10px"> <p><?php _e( "If you'd like to delete your current cover image but not upload a new one, please use the delete Cover Image button.", 'buddypress' ); ?></p>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <p><a class="button edit" id="bp-delete-cover-image" href="#"><?php esc_html_e( 'Delete My Cover Image', 'buddypress' ); ?></a></p>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <button type="button" class="button edit" id="bp-delete-cover-image"><?php esc_html_e( 'Delete My Cover Image', 'buddypress' ); ?></button>
</ins><span class="cx" style="display: block; padding: 0 10px"> <# } else if ( 'group' === data.object ) { #>
</span><span class="cx" style="display: block; padding: 0 10px"> <p><?php _e( "If you'd like to remove the existing group cover image but not upload a new one, please use the delete group cover image button.", 'buddypress' ); ?></p>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <p><a class="button edit" id="bp-delete-cover-image" href="#"><?php esc_html_e( 'Delete Group Cover Image', 'buddypress' ); ?></a></p>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <button type="button" class="button edit" id="bp-delete-cover-image"><?php esc_html_e( 'Delete Group Cover Image', 'buddypress' ); ?></button>
</ins><span class="cx" style="display: block; padding: 0 10px"> <# } else { #>
</span><span class="cx" style="display: block; padding: 0 10px"> <?php do_action( 'bp_attachments_cover_image_delete_template' ); ?>
</span><span class="cx" style="display: block; padding: 0 10px"> <# } #>
</span></span></pre></div>
<a id="trunksrcbptemplatesbpnouveaubuddypresscommonjstemplatesactivityformphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-templates/bp-nouveau/buddypress/common/js-templates/activity/form.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-templates/bp-nouveau/buddypress/common/js-templates/activity/form.php 2017-11-01 20:06:29 UTC (rev 11718)
+++ trunk/src/bp-templates/bp-nouveau/buddypress/common/js-templates/activity/form.php 2017-11-01 21:01:03 UTC (rev 11719)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -22,7 +22,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> </script>
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> <script type="text/html" id="tmpl-activity-post-form-buttons">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <a href="#" class="button dashicons {{data.icon}}" data-button="{{data.id}}"><span class="bp-screen-reader-text">{{data.caption}}</span></a>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <button type="button" class="button dashicons {{data.icon}}" data-button="{{data.id}}"><span class="bp-screen-reader-text">{{data.caption}}</span></button>
</ins><span class="cx" style="display: block; padding: 0 10px"> </script>
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> <script type="text/html" id="tmpl-activity-target-item">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -37,8 +37,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> <span class="bp-item-name">{{data.name}}</span>
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> <# if ( data.selected ) { #>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <a href="#" class="bp-remove-item dashicons dashicons-no" data-item_id="{{data.id}}">
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <button type="button" class="bp-remove-item dashicons dashicons-no" data-item_id="{{data.id}}">
</ins><span class="cx" style="display: block; padding: 0 10px"> <span class="bp-screen-reader-text"><?php esc_html_e( 'Remove item', 'buddypress' ); ?></span>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- </a>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ </button>
</ins><span class="cx" style="display: block; padding: 0 10px"> <# } #>
</span><span class="cx" style="display: block; padding: 0 10px"> </script>
</span></span></pre></div>
<a id="trunksrcbptemplatesbpnouveaubuddypresscommonjstemplatesinvitesindexphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-templates/bp-nouveau/buddypress/common/js-templates/invites/index.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-templates/bp-nouveau/buddypress/common/js-templates/invites/index.php 2017-11-01 20:06:29 UTC (rev 11718)
+++ trunk/src/bp-templates/bp-nouveau/buddypress/common/js-templates/invites/index.php 2017-11-01 21:01:03 UTC (rev 11719)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -109,14 +109,14 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> <script type="text/html" id="tmpl-bp-invites-paginate">
</span><span class="cx" style="display: block; padding: 0 10px"> <# if ( 1 !== data.page ) { #>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <a href="#" id="bp-invites-prev-page" class="button invite-button">
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <button type="button" id="bp-invites-prev-page" class="button invite-button">
</ins><span class="cx" style="display: block; padding: 0 10px"> <span class="bp-screen-reader-text"><?php esc_html_e( 'Previous', 'buddypress' );?></span>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- </a>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ </button>
</ins><span class="cx" style="display: block; padding: 0 10px"> <# } #>
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> <# if ( data.total_page !== data.page ) { #>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <a href="#" id="bp-invites-next-page" class="button invite-button">
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <button type="button" id="bp-invites-next-page" class="button invite-button">
</ins><span class="cx" style="display: block; padding: 0 10px"> <span class="bp-screen-reader-text"><?php esc_html_e( 'Next', 'buddypress' );?></span>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- </a>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ </button>
</ins><span class="cx" style="display: block; padding: 0 10px"> <# } #>
</span><span class="cx" style="display: block; padding: 0 10px"> </script>
</span></span></pre>
</div>
</div>
</body>
</html>