<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][11696] trunk/src/bp-templates/bp-nouveau/buddypress-functions.php: Templates, Nouveau: don't print notice of deprecated template actions to `error_log`.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://buddypress.trac.wordpress.org/changeset/11696">11696</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://buddypress.trac.wordpress.org/changeset/11696","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>djpaul</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2017-09-17 19:11:09 +0000 (Sun, 17 Sep 2017)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Templates, Nouveau: don't print notice of deprecated template actions to `error_log`.
I've kept `bp_nouveau_get_forsaken_hooks()` because this function might be a great utililty for a development helper/plugin -- probably not just BuddyPress core itself.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcbptemplatesbpnouveaubuddypressfunctionsphp">trunk/src/bp-templates/bp-nouveau/buddypress-functions.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcbptemplatesbpnouveaubuddypressfunctionsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-templates/bp-nouveau/buddypress-functions.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-templates/bp-nouveau/buddypress-functions.php 2017-09-17 19:06:35 UTC (rev 11695)
+++ trunk/src/bp-templates/bp-nouveau/buddypress-functions.php 2017-09-17 19:11:09 UTC (rev 11696)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -174,8 +174,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> // We need to neutralize the BuddyPress core "bp_core_render_message()" once it has been added.
</span><span class="cx" style="display: block; padding: 0 10px"> add_action( 'bp_actions', array( $this, 'neutralize_core_template_notices' ), 6 );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Output Nouveau 'forsaken' hook error messages to WP debug log.
-// add_action('bp_init', array( $this, 'nouveau_write_deprecated_hooks_log' ) );
</del><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /** Scripts ***********************************************************/
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -188,6 +186,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> add_action( 'bp_enqueue_scripts', array( $this, 'enqueue_scripts' ) ); // Enqueue theme JS
</span><span class="cx" style="display: block; padding: 0 10px"> add_filter( 'bp_enqueue_scripts', array( $this, 'localize_scripts' ) ); // Enqueue theme script localization
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
</ins><span class="cx" style="display: block; padding: 0 10px"> /** Body no-js Class **************************************************/
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> add_filter( 'body_class', array( $this, 'add_nojs_body_class' ), 20, 1 );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -207,6 +206,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> // Set the BP Uri for the Ajax customizer preview
</span><span class="cx" style="display: block; padding: 0 10px"> add_filter( 'bp_uri', array( $this, 'customizer_set_uri' ), 10, 1 );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
</ins><span class="cx" style="display: block; padding: 0 10px"> /** Override **********************************************************/
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -377,31 +377,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * Pass Nouveau's hook error messages array to WP debug log function if
- * 'define( 'WP_DEBUG', true )' & 'define( 'WP_DEBUG_LOG', true )' are set.
- *
- *
- * @since 1.0.0
- */
- public function nouveau_write_deprecated_hooks_log() {
- if ( ! defined( 'WP_DEBUG') || ! WP_DEBUG )
- return;
-
- $log = $this->developer_feedbacks();
-
- if ( $log ) {
- // File section delimeter for clarity.
- error_log( print_r( '========= Nouveau deprecated action hook messages =========', true ) );
- }
-
- if ( is_array( $log ) || is_object( $log ) ) {
- error_log( print_r( $log, true ) );
- } else {
- error_log( $log );
- }
- }
-
- /**
</del><span class="cx" style="display: block; padding: 0 10px"> * Load localizations for topic script.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * These localizations require information that may not be loaded even by init.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -626,44 +601,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * Inform developers about the Legacy hooks we are not using.
- *
- * This will be sent to the WP error log.
- *
- * @since 1.0.0
- *
- * @return array
- */
- public function developer_feedbacks() {
- $notices = array();
-
- if ( ! defined( 'WP_DEBUG') || ! WP_DEBUG ) {
- return;
- }
-
- // Get the forsaken hooks.
- $forsaken_hooks = bp_nouveau_get_forsaken_hooks();
-
- // Loop to check if deprecated hooks are used.
- foreach ( $forsaken_hooks as $hook => $feedback ) {
- if ( 'action' === $feedback['hook_type'] ) {
- if ( ! has_action( $hook ) ) {
- continue;
- }
-
- } elseif ( 'filter' === $feedback['hook_type'] ) {
- if ( ! has_filter( $hook ) ) {
- continue;
- }
- }
-
- $notices[] = $feedback['message'];
- }
-
- return $notices;
- }
-
- /**
</del><span class="cx" style="display: block; padding: 0 10px"> * We'll handle template notices from BP Nouveau.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 1.0.0
</span></span></pre>
</div>
</div>
</body>
</html>