<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][11384] trunk: BP_Groups_Group: Refactor some fetching functions.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://buddypress.trac.wordpress.org/changeset/11384">11384</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://buddypress.trac.wordpress.org/changeset/11384","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>dcavins</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2017-01-14 01:37:35 +0000 (Sat, 14 Jan 2017)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>BP_Groups_Group: Refactor some fetching functions.
Rewrite `BP_Groups_Group::filter_user_groups`,
`BP_Groups_Group::search_groups`, `BP_Groups_Group::get_random`, and
`BP_Groups_Group::get_by_letter` to use `BP_Groups_Group::get()`. Using
`get()` means that incrementor-based caching will be applied to the
queries and that `get_group_extras()` can be removed in several places.
Fixes <a href="http://buddypress.trac.wordpress.org/ticket/7419">#7419</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcbpgroupsclassesclassbpgroupsgroupphp">trunk/src/bp-groups/classes/class-bp-groups-group.php</a></li>
<li><a href="#trunktestsphpunittestcasesgroupsclassbpgroupsgroupphp">trunk/tests/phpunit/testcases/groups/class-bp-groups-group.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcbpgroupsclassesclassbpgroupsgroupphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-groups/classes/class-bp-groups-group.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-groups/classes/class-bp-groups-group.php 2017-01-14 01:32:34 UTC (rev 11383)
+++ trunk/src/bp-groups/classes/class-bp-groups-group.php 2017-01-14 01:37:35 UTC (rev 11384)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -677,37 +677,35 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @param int|null $page Optional. The page offset of results to return.
</span><span class="cx" style="display: block; padding: 0 10px"> * Default: null (no limit).
</span><span class="cx" style="display: block; padding: 0 10px"> * @return false|array {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * @type array $groups Array of matched and paginated group objects.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @type array $groups Array of matched and paginated group IDs.
</ins><span class="cx" style="display: block; padding: 0 10px"> * @type int $total Total count of groups matching the query.
</span><span class="cx" style="display: block; padding: 0 10px"> * }
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public static function filter_user_groups( $filter, $user_id = 0, $order = false, $limit = null, $page = null ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- global $wpdb;
-
- if ( empty( $user_id ) )
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( empty( $user_id ) ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> $user_id = bp_displayed_user_id();
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ }
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $search_terms_like = '%' . bp_esc_like( $filter ) . '%';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $args = array(
+ 'search_terms' => $filter,
+ 'user_id' => $user_id,
+ 'per_page' => $limit,
+ 'page' => $page,
+ 'order' => $order,
+ );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $pag_sql = $order_sql = $hidden_sql = '';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $groups = BP_Groups_Group::get( $args );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( !empty( $limit ) && !empty( $page ) )
- $pag_sql = $wpdb->prepare( " LIMIT %d, %d", intval( ( $page - 1 ) * $limit), intval( $limit ) );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Modify the results to match the old format.
+ $paged_groups = array();
+ $i = 0;
+ foreach ( $groups['groups'] as $group ) {
+ $paged_groups[ $i ] = new stdClass;
+ $paged_groups[ $i ]->group_id = $group->id;
+ $i++;
+ }
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Get all the group ids for the current user's groups.
- $gids = BP_Groups_Member::get_group_ids( $user_id );
-
- if ( empty( $gids['groups'] ) )
- return false;
-
- $bp = buddypress();
-
- $gids = esc_sql( implode( ',', wp_parse_id_list( $gids['groups'] ) ) );
-
- $paged_groups = $wpdb->get_results( $wpdb->prepare( "SELECT id as group_id FROM {$bp->groups->table_name} WHERE ( name LIKE %s OR description LIKE %s ) AND id IN ({$gids}) {$pag_sql}", $search_terms_like, $search_terms_like ) );
- $total_groups = $wpdb->get_var( $wpdb->prepare( "SELECT COUNT(id) FROM {$bp->groups->table_name} WHERE ( name LIKE %s OR description LIKE %s ) AND id IN ({$gids})", $search_terms_like, $search_terms_like ) );
-
- return array( 'groups' => $paged_groups, 'total' => $total_groups );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ return array( 'groups' => $paged_groups, 'total' => $groups['total'] );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -725,35 +723,31 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * sort).
</span><span class="cx" style="display: block; padding: 0 10px"> * @param string|bool $order ASC or DESC. Default: false (default sort).
</span><span class="cx" style="display: block; padding: 0 10px"> * @return array {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * @type array $groups Array of matched and paginated group objects.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @type array $groups Array of matched and paginated group IDs.
</ins><span class="cx" style="display: block; padding: 0 10px"> * @type int $total Total count of groups matching the query.
</span><span class="cx" style="display: block; padding: 0 10px"> * }
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public static function search_groups( $filter, $limit = null, $page = null, $sort_by = false, $order = false ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- global $wpdb;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $args = array(
+ 'search_terms' => $filter,
+ 'per_page' => $limit,
+ 'page' => $page,
+ 'orderby' => $sort_by,
+ 'order' => $order,
+ );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $search_terms_like = '%' . bp_esc_like( $filter ) . '%';
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $groups = BP_Groups_Group::get( $args );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $pag_sql = $order_sql = $hidden_sql = '';
-
- if ( !empty( $limit ) && !empty( $page ) )
- $pag_sql = $wpdb->prepare( " LIMIT %d, %d", intval( ( $page - 1 ) * $limit), intval( $limit ) );
-
- if ( !empty( $sort_by ) && !empty( $order ) ) {
- $sort_by = esc_sql( $sort_by );
- $order = esc_sql( $order );
- $order_sql = "ORDER BY {$sort_by} {$order}";
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Modify the results to match the old format.
+ $paged_groups = array();
+ $i = 0;
+ foreach ( $groups['groups'] as $group ) {
+ $paged_groups[ $i ] = new stdClass;
+ $paged_groups[ $i ]->group_id = $group->id;
+ $i++;
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( !bp_current_user_can( 'bp_moderate' ) )
- $hidden_sql = "AND status != 'hidden'";
-
- $bp = buddypress();
-
- $paged_groups = $wpdb->get_results( $wpdb->prepare( "SELECT id as group_id FROM {$bp->groups->table_name} WHERE ( name LIKE %s OR description LIKE %s ) {$hidden_sql} {$order_sql} {$pag_sql}", $search_terms_like, $search_terms_like ) );
- $total_groups = $wpdb->get_var( $wpdb->prepare( "SELECT COUNT(id) FROM {$bp->groups->table_name} WHERE ( name LIKE %s OR description LIKE %s ) {$hidden_sql}", $search_terms_like, $search_terms_like ) );
-
- return array( 'groups' => $paged_groups, 'total' => $total_groups );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ return array( 'groups' => $paged_groups, 'total' => $groups['total'] );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1492,8 +1486,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * Default: null (no limit).
</span><span class="cx" style="display: block; padding: 0 10px"> * @param int|null $page Optional. The page offset of results to return.
</span><span class="cx" style="display: block; padding: 0 10px"> * Default: null (no limit).
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * @param bool $populate_extras Optional. Whether to fetch extra
- * information about the groups. Default: true.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @param bool $populate_extras Deprecated.
</ins><span class="cx" style="display: block; padding: 0 10px"> * @param string|array|bool $exclude Optional. Array or comma-separated list of group
</span><span class="cx" style="display: block; padding: 0 10px"> * IDs to exclude from results.
</span><span class="cx" style="display: block; padding: 0 10px"> * @return false|array {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1519,34 +1512,15 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $bp = buddypress();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $args = array(
+ 'per_page' => $limit,
+ 'page' => $page,
+ 'search_terms' => $letter . '*',
+ 'search_columns' => array( 'name' ),
+ 'exclude' => $exclude,
+ );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( !empty( $exclude ) ) {
- $exclude = implode( ',', wp_parse_id_list( $exclude ) );
- $exclude_sql = " AND g.id NOT IN ({$exclude})";
- }
-
- if ( !bp_current_user_can( 'bp_moderate' ) )
- $hidden_sql = " AND status != 'hidden'";
-
- $letter_like = bp_esc_like( $letter ) . '%';
-
- if ( !empty( $limit ) && !empty( $page ) ) {
- $pag_sql = $wpdb->prepare( " LIMIT %d, %d", intval( ( $page - 1 ) * $limit), intval( $limit ) );
- }
-
- $total_groups = $wpdb->get_var( $wpdb->prepare( "SELECT COUNT(DISTINCT g.id) FROM {$bp->groups->table_name_groupmeta} gm1, {$bp->groups->table_name_groupmeta} gm2, {$bp->groups->table_name} g WHERE g.id = gm1.group_id AND g.id = gm2.group_id AND gm2.meta_key = 'last_activity' AND gm1.meta_key = 'total_member_count' AND g.name LIKE %s {$hidden_sql} {$exclude_sql}", $letter_like ) );
-
- $paged_groups = $wpdb->get_results( $wpdb->prepare( "SELECT g.*, gm1.meta_value as total_member_count, gm2.meta_value as last_activity FROM {$bp->groups->table_name_groupmeta} gm1, {$bp->groups->table_name_groupmeta} gm2, {$bp->groups->table_name} g WHERE g.id = gm1.group_id AND g.id = gm2.group_id AND gm2.meta_key = 'last_activity' AND gm1.meta_key = 'total_member_count' AND g.name LIKE %s {$hidden_sql} {$exclude_sql} ORDER BY g.name ASC {$pag_sql}", $letter_like ) );
-
- if ( !empty( $populate_extras ) ) {
- foreach ( (array) $paged_groups as $group ) {
- $group_ids[] = $group->id;
- }
- $paged_groups = BP_Groups_Group::get_group_extras( $paged_groups, $group_ids, 'newest' );
- }
-
- return array( 'groups' => $paged_groups, 'total' => $total_groups );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ return BP_Groups_Group::get( $args );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1576,46 +1550,16 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * }
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public static function get_random( $limit = null, $page = null, $user_id = 0, $search_terms = false, $populate_extras = true, $exclude = false ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- global $wpdb;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $args = array(
+ 'type' => 'random',
+ 'per_page' => $limit,
+ 'page' => $page,
+ 'user_id' => $user_id,
+ 'search_terms' => $search_terms,
+ 'exclude' => $exclude,
+ );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $pag_sql = $hidden_sql = $search_sql = $exclude_sql = '';
-
- if ( !empty( $limit ) && !empty( $page ) )
- $pag_sql = $wpdb->prepare( " LIMIT %d, %d", intval( ( $page - 1 ) * $limit), intval( $limit ) );
-
- if ( !is_user_logged_in() || ( !bp_current_user_can( 'bp_moderate' ) && ( $user_id != bp_loggedin_user_id() ) ) )
- $hidden_sql = "AND g.status != 'hidden'";
-
- if ( !empty( $search_terms ) ) {
- $search_terms_like = '%' . bp_esc_like( $search_terms ) . '%';
- $search_sql = $wpdb->prepare( " AND ( g.name LIKE %s OR g.description LIKE %s )", $search_terms_like, $search_terms_like );
- }
-
- if ( !empty( $exclude ) ) {
- $exclude = wp_parse_id_list( $exclude );
- $exclude = esc_sql( implode( ',', $exclude ) );
- $exclude_sql = " AND g.id NOT IN ({$exclude})";
- }
-
- $bp = buddypress();
-
- if ( !empty( $user_id ) ) {
- $user_id = esc_sql( $user_id );
- $paged_groups = $wpdb->get_results( "SELECT g.*, gm1.meta_value as total_member_count, gm2.meta_value as last_activity FROM {$bp->groups->table_name_groupmeta} gm1, {$bp->groups->table_name_groupmeta} gm2, {$bp->groups->table_name_members} m, {$bp->groups->table_name} g WHERE g.id = m.group_id AND g.id = gm1.group_id AND g.id = gm2.group_id AND gm2.meta_key = 'last_activity' AND gm1.meta_key = 'total_member_count' {$hidden_sql} {$search_sql} AND m.user_id = {$user_id} AND m.is_confirmed = 1 AND m.is_banned = 0 {$exclude_sql} ORDER BY rand() {$pag_sql}" );
- $total_groups = $wpdb->get_var( "SELECT COUNT(DISTINCT m.group_id) FROM {$bp->groups->table_name_members} m LEFT JOIN {$bp->groups->table_name_groupmeta} gm ON m.group_id = gm.group_id INNER JOIN {$bp->groups->table_name} g ON m.group_id = g.id WHERE gm.meta_key = 'last_activity'{$hidden_sql} {$search_sql} AND m.user_id = {$user_id} AND m.is_confirmed = 1 AND m.is_banned = 0 {$exclude_sql}" );
- } else {
- $paged_groups = $wpdb->get_results( "SELECT g.*, gm1.meta_value as total_member_count, gm2.meta_value as last_activity FROM {$bp->groups->table_name_groupmeta} gm1, {$bp->groups->table_name_groupmeta} gm2, {$bp->groups->table_name} g WHERE g.id = gm1.group_id AND g.id = gm2.group_id AND gm2.meta_key = 'last_activity' AND gm1.meta_key = 'total_member_count' {$hidden_sql} {$search_sql} {$exclude_sql} ORDER BY rand() {$pag_sql}" );
- $total_groups = $wpdb->get_var( "SELECT COUNT(DISTINCT g.id) FROM {$bp->groups->table_name_groupmeta} gm INNER JOIN {$bp->groups->table_name} g ON gm.group_id = g.id WHERE gm.meta_key = 'last_activity'{$hidden_sql} {$search_sql} {$exclude_sql}" );
- }
-
- if ( !empty( $populate_extras ) ) {
- foreach ( (array) $paged_groups as $group ) {
- $group_ids[] = $group->id;
- }
- $paged_groups = BP_Groups_Group::get_group_extras( $paged_groups, $group_ids, 'newest' );
- }
-
- return array( 'groups' => $paged_groups, 'total' => $total_groups );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ return BP_Groups_Group::get( $args );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span></span></pre></div>
<a id="trunktestsphpunittestcasesgroupsclassbpgroupsgroupphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/testcases/groups/class-bp-groups-group.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/testcases/groups/class-bp-groups-group.php 2017-01-14 01:32:34 UTC (rev 11383)
+++ trunk/tests/phpunit/testcases/groups/class-bp-groups-group.php 2017-01-14 01:37:35 UTC (rev 11384)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1092,6 +1092,24 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertEquals( array( $g1 ), $found );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ public function test_get_by_letter_typical_use() {
+ $g1 = $this->factory->group->create( array(
+ 'name' => 'Awesome Cool Group',
+ 'description' => 'Neat',
+ ) );
+ $g2 = $this->factory->group->create( array(
+ 'name' => 'Babylon Kong',
+ 'description' => 'Awesome',
+ ) );
+
+ $groups = BP_Groups_Group::get_by_letter( 'A' );
+
+ $found = wp_list_pluck( $groups['groups'], 'id' );
+
+ $this->assertEquals( array( $g1 ), $found );
+
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> public function test_get_by_letter_with_exclude() {
</span><span class="cx" style="display: block; padding: 0 10px"> $g1 = $this->factory->group->create( array(
</span><span class="cx" style="display: block; padding: 0 10px"> 'name' => 'Awesome Cool Group',
</span></span></pre>
</div>
</div>
</body>
</html>