<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][11264] branches/2.7/src/bp-templates/bp-legacy/css: Correct twentysixteen `.no-js` class conflict with BP's version of same class on body element</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://buddypress.trac.wordpress.org/changeset/11264">11264</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://buddypress.trac.wordpress.org/changeset/11264","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>hnla</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2016-12-02 10:07:28 +0000 (Fri, 02 Dec 2016)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Correct twentysixteen `.no-js` class conflict with BP's version of same class on body element
Commit adds a ruleset specific to twntysixteen to hide the onclick dropdown mobile menu on page load.
Twentysixteen adds a hardcoded class to the html element & changes class if JS active scripted in the 'head'; BP runs similar but on body el & changes no-js class on DOM fully loaded.
Menu remains in view after clicking due to 2016 updating js class early and BP lagging behind.
Ruleset targets body element if it has a class `.no-js` and it's parent has class `.js` thus we only run if JS active and for initial page load sequence.
Fixes <a href="http://buddypress.trac.wordpress.org/ticket/7314">#7314</a> ( Branch 2.7 )
Props DarkWolf, DJPaul, r-a-y, hnla</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#branches27srcbptemplatesbplegacycsstwentysixteenrtlcss">branches/2.7/src/bp-templates/bp-legacy/css/twentysixteen-rtl.css</a></li>
<li><a href="#branches27srcbptemplatesbplegacycsstwentysixteencss">branches/2.7/src/bp-templates/bp-legacy/css/twentysixteen.css</a></li>
<li><a href="#branches27srcbptemplatesbplegacycsstwentysixteenscss">branches/2.7/src/bp-templates/bp-legacy/css/twentysixteen.scss</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="branches27srcbptemplatesbplegacycsstwentysixteenrtlcss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: branches/2.7/src/bp-templates/bp-legacy/css/twentysixteen-rtl.css</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- branches/2.7/src/bp-templates/bp-legacy/css/twentysixteen-rtl.css 2016-12-02 09:42:18 UTC (rev 11263)
+++ branches/2.7/src/bp-templates/bp-legacy/css/twentysixteen-rtl.css 2016-12-02 10:07:28 UTC (rev 11264)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -58,6 +58,16 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @section 1.0 - Theme - Structural Elements. overrides, Globals
</span><span class="cx" style="display: block; padding: 0 10px"> *-------------------------------------------------------------------------------
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+/**
+* Corrective measure to deal with 2016 / BP handling of no-js
+* classes - hide menu if BP still showing 'no-js'.
+*/
+@media screen and (max-width: 905px) {
+ html.js body.no-js .site-header-menu {
+ display: none;
+ }
+}
+
</ins><span class="cx" style="display: block; padding: 0 10px"> .buddypress div.clear {
</span><span class="cx" style="display: block; padding: 0 10px"> display: none;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre></div>
<a id="branches27srcbptemplatesbplegacycsstwentysixteencss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: branches/2.7/src/bp-templates/bp-legacy/css/twentysixteen.css</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- branches/2.7/src/bp-templates/bp-legacy/css/twentysixteen.css 2016-12-02 09:42:18 UTC (rev 11263)
+++ branches/2.7/src/bp-templates/bp-legacy/css/twentysixteen.css 2016-12-02 10:07:28 UTC (rev 11264)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -58,6 +58,16 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @section 1.0 - Theme - Structural Elements. overrides, Globals
</span><span class="cx" style="display: block; padding: 0 10px"> *-------------------------------------------------------------------------------
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+/**
+* Corrective measure to deal with 2016 / BP handling of no-js
+* classes - hide menu if BP still showing 'no-js'.
+*/
+@media screen and (max-width: 905px) {
+ html.js body.no-js .site-header-menu {
+ display: none;
+ }
+}
+
</ins><span class="cx" style="display: block; padding: 0 10px"> .buddypress div.clear {
</span><span class="cx" style="display: block; padding: 0 10px"> display: none;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre></div>
<a id="branches27srcbptemplatesbplegacycsstwentysixteenscss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: branches/2.7/src/bp-templates/bp-legacy/css/twentysixteen.scss</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- branches/2.7/src/bp-templates/bp-legacy/css/twentysixteen.scss 2016-12-02 09:42:18 UTC (rev 11263)
+++ branches/2.7/src/bp-templates/bp-legacy/css/twentysixteen.scss 2016-12-02 10:07:28 UTC (rev 11264)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -235,8 +235,32 @@
</span><span class="cx" style="display: block; padding: 0 10px"> *-------------------------------------------------------------------------------
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+// A conflict between BP's body.no-js being removed only
+// when the DOM is fully loaded & Twentysixteens hardcoded
+// class on the html el & scripting in head at start of DOM
+// causes mobile menu to stay opened too long.
+// This ruleset hides menu if html.js (2016 JS has kicked in) but BP still
+// rendering body.no-js before it's own JS removal kicks in.
+// See trac ticket https://buddypress.trac.wordpress.org/ticket/7314
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+/**
+* Corrective measure to deal with 2016 / BP handling of no-js
+* classes - hide menu if BP still showing 'no-js'.
+*/
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+@media screen and (max-width: 905px) {
+
+ html.js {
+
+ body.no-js {
+
+ .site-header-menu {
+ display: none;
+ }
+ }
+ }
+}
+
</ins><span class="cx" style="display: block; padding: 0 10px"> .buddypress {
</span><span class="cx" style="display: block; padding: 0 10px"> // Remove any empty clearing elements, CSS provides clearing.
</span><span class="cx" style="display: block; padding: 0 10px"> div.clear {display: none;}
</span></span></pre>
</div>
</div>
</body>
</html>