<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][11100] trunk/src/bp-groups: Groups: Eliminate the `populate_extras` option from the `bp_has_groups()` stack.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://buddypress.trac.wordpress.org/changeset/11100">11100</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://buddypress.trac.wordpress.org/changeset/11100","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>boonebgorges</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2016-09-14 01:34:44 +0000 (Wed, 14 Sep 2016)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Groups: Eliminate the `populate_extras` option from the `bp_has_groups()` stack.
Fun fact: Now that all these values are cached and lazy-loaded, the
parameter no longer does anything. Begone!
See <a href="http://buddypress.trac.wordpress.org/ticket/5451">#5451</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcbpgroupsbpgroupsfunctionsphp">trunk/src/bp-groups/bp-groups-functions.php</a></li>
<li><a href="#trunksrcbpgroupsbpgroupstemplatephp">trunk/src/bp-groups/bp-groups-template.php</a></li>
<li><a href="#trunksrcbpgroupsclassesclassbpgroupsgroupphp">trunk/src/bp-groups/classes/class-bp-groups-group.php</a></li>
<li><a href="#trunksrcbpgroupsclassesclassbpgroupsmembersuggestionsphp">trunk/src/bp-groups/classes/class-bp-groups-member-suggestions.php</a></li>
<li><a href="#trunksrcbpgroupsclassesclassbpgroupstemplatephp">trunk/src/bp-groups/classes/class-bp-groups-template.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcbpgroupsbpgroupsfunctionsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-groups/bp-groups-functions.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-groups/bp-groups-functions.php 2016-09-13 22:09:52 UTC (rev 11099)
+++ trunk/src/bp-groups/bp-groups-functions.php 2016-09-14 01:34:44 UTC (rev 11100)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -711,7 +711,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'show_hidden' => false, // Show hidden groups to non-admins.
</span><span class="cx" style="display: block; padding: 0 10px"> 'per_page' => 20, // The number of results to return per page.
</span><span class="cx" style="display: block; padding: 0 10px"> 'page' => 1, // The page to return if limiting per page.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'populate_extras' => true, // Fetch meta such as is_banned and is_member.
</del><span class="cx" style="display: block; padding: 0 10px"> 'update_meta_cache' => true, // Pre-fetch groupmeta for queried groups.
</span><span class="cx" style="display: block; padding: 0 10px"> 'update_admin_cache' => false,
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -732,7 +731,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'show_hidden' => $r['show_hidden'],
</span><span class="cx" style="display: block; padding: 0 10px"> 'per_page' => $r['per_page'],
</span><span class="cx" style="display: block; padding: 0 10px"> 'page' => $r['page'],
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'populate_extras' => $r['populate_extras'],
</del><span class="cx" style="display: block; padding: 0 10px"> 'update_meta_cache' => $r['update_meta_cache'],
</span><span class="cx" style="display: block; padding: 0 10px"> 'update_admin_cache' => $r['update_admin_cache'],
</span><span class="cx" style="display: block; padding: 0 10px"> 'order' => $r['order'],
</span></span></pre></div>
<a id="trunksrcbpgroupsbpgroupstemplatephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-groups/bp-groups-template.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-groups/bp-groups-template.php 2016-09-13 22:09:52 UTC (rev 11099)
+++ trunk/src/bp-groups/bp-groups-template.php 2016-09-14 01:34:44 UTC (rev 11100)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -134,8 +134,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * See {@link WP_Meta_Query::queries} for description.
</span><span class="cx" style="display: block; padding: 0 10px"> * @type array|string $include Array or comma-separated list of group IDs. Results will be limited
</span><span class="cx" style="display: block; padding: 0 10px"> * to groups within the list. Default: false.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * @type bool $populate_extras Whether to fetch additional information (such as member count)
- * about groups. Default: true.
</del><span class="cx" style="display: block; padding: 0 10px"> * @type array|string $exclude Array or comma-separated list of group IDs. Results will exclude
</span><span class="cx" style="display: block; padding: 0 10px"> * the listed groups. Default: false.
</span><span class="cx" style="display: block; padding: 0 10px"> * @type array|string $parent_id Array or comma-separated list of group IDs. Results will include only
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -205,7 +203,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'include' => false,
</span><span class="cx" style="display: block; padding: 0 10px"> 'exclude' => false,
</span><span class="cx" style="display: block; padding: 0 10px"> 'parent_id' => null,
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'populate_extras' => true,
</del><span class="cx" style="display: block; padding: 0 10px"> 'update_meta_cache' => true,
</span><span class="cx" style="display: block; padding: 0 10px"> 'update_admin_cache' => bp_is_groups_directory() || bp_is_user_groups(),
</span><span class="cx" style="display: block; padding: 0 10px"> ), 'has_groups' );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -230,7 +227,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'include' => $r['include'],
</span><span class="cx" style="display: block; padding: 0 10px"> 'exclude' => $r['exclude'],
</span><span class="cx" style="display: block; padding: 0 10px"> 'parent_id' => $r['parent_id'],
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'populate_extras' => (bool) $r['populate_extras'],
</del><span class="cx" style="display: block; padding: 0 10px"> 'update_meta_cache' => (bool) $r['update_meta_cache'],
</span><span class="cx" style="display: block; padding: 0 10px"> 'update_admin_cache' => (bool) $r['update_admin_cache'],
</span><span class="cx" style="display: block; padding: 0 10px"> ) );
</span></span></pre></div>
<a id="trunksrcbpgroupsclassesclassbpgroupsgroupphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-groups/classes/class-bp-groups-group.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-groups/classes/class-bp-groups-group.php 2016-09-13 22:09:52 UTC (rev 11099)
+++ trunk/src/bp-groups/classes/class-bp-groups-group.php 2016-09-14 01:34:44 UTC (rev 11100)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -881,8 +881,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * will be limited to groups within the list. Default: false.
</span><span class="cx" style="display: block; padding: 0 10px"> * @type array|string $parent_id Optional. Array or comma-separated list of group IDs. Results
</span><span class="cx" style="display: block; padding: 0 10px"> * will be limited to children of the specified groups. Default: null.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * @type bool $populate_extras Whether to fetch additional information
- * (such as member count) about groups. Default: true.
</del><span class="cx" style="display: block; padding: 0 10px"> * @type array|string $exclude Optional. Array or comma-separated list of group IDs.
</span><span class="cx" style="display: block; padding: 0 10px"> * Results will exclude the listed groups. Default: false.
</span><span class="cx" style="display: block; padding: 0 10px"> * @type bool $update_meta_cache Whether to pre-fetch groupmeta for the returned groups.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -935,7 +933,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'meta_query' => false,
</span><span class="cx" style="display: block; padding: 0 10px"> 'include' => false,
</span><span class="cx" style="display: block; padding: 0 10px"> 'parent_id' => null,
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'populate_extras' => true,
</del><span class="cx" style="display: block; padding: 0 10px"> 'update_meta_cache' => true,
</span><span class="cx" style="display: block; padding: 0 10px"> 'update_admin_cache' => false,
</span><span class="cx" style="display: block; padding: 0 10px"> 'exclude' => false,
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1150,11 +1147,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $group_ids[] = $group->id;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // Populate some extra information instead of querying each time in the loop.
- if ( !empty( $r['populate_extras'] ) ) {
- $paged_groups = BP_Groups_Group::get_group_extras( $paged_groups, $group_ids, $r['type'] );
- }
-
</del><span class="cx" style="display: block; padding: 0 10px"> // Grab all groupmeta.
</span><span class="cx" style="display: block; padding: 0 10px"> if ( ! empty( $r['update_meta_cache'] ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> bp_groups_update_meta_cache( $group_ids );
</span></span></pre></div>
<a id="trunksrcbpgroupsclassesclassbpgroupsmembersuggestionsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-groups/classes/class-bp-groups-member-suggestions.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-groups/classes/class-bp-groups-member-suggestions.php 2016-09-13 22:09:52 UTC (rev 11099)
+++ trunk/src/bp-groups/classes/class-bp-groups-member-suggestions.php 2016-09-14 01:34:44 UTC (rev 11100)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -92,7 +92,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> public function get_suggestions() {
</span><span class="cx" style="display: block; padding: 0 10px"> $user_query = array(
</span><span class="cx" style="display: block; padding: 0 10px"> 'count_total' => '', // Prevents total count.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'populate_extras' => false,
</del><span class="cx" style="display: block; padding: 0 10px"> 'type' => 'alphabetical',
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> 'group_role' => array( 'admin', 'member', 'mod' ),
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -115,7 +114,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> } else {
</span><span class="cx" style="display: block; padding: 0 10px"> $group_query = array(
</span><span class="cx" style="display: block; padding: 0 10px"> 'count_total' => '', // Prevents total count.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'populate_extras' => false,
</del><span class="cx" style="display: block; padding: 0 10px"> 'type' => 'alphabetical',
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> 'group_id' => absint( $this->args['group_id'] ),
</span></span></pre></div>
<a id="trunksrcbpgroupsclassesclassbpgroupstemplatephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-groups/classes/class-bp-groups-template.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-groups/classes/class-bp-groups-template.php 2016-09-13 22:09:52 UTC (rev 11099)
+++ trunk/src/bp-groups/classes/class-bp-groups-template.php 2016-09-14 01:34:44 UTC (rev 11100)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -171,7 +171,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'group_type__in' => '',
</span><span class="cx" style="display: block; padding: 0 10px"> 'group_type__not_in' => '',
</span><span class="cx" style="display: block; padding: 0 10px"> 'meta_query' => false,
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'populate_extras' => true,
</del><span class="cx" style="display: block; padding: 0 10px"> 'update_meta_cache' => true,
</span><span class="cx" style="display: block; padding: 0 10px"> 'update_admin_cache' => false,
</span><span class="cx" style="display: block; padding: 0 10px"> );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -226,7 +225,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'include' => $include,
</span><span class="cx" style="display: block; padding: 0 10px"> 'exclude' => $exclude,
</span><span class="cx" style="display: block; padding: 0 10px"> 'parent_id' => $parent_id,
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- 'populate_extras' => $populate_extras,
</del><span class="cx" style="display: block; padding: 0 10px"> 'update_meta_cache' => $update_meta_cache,
</span><span class="cx" style="display: block; padding: 0 10px"> 'update_admin_cache' => $update_admin_cache,
</span><span class="cx" style="display: block; padding: 0 10px"> 'show_hidden' => $show_hidden,
</span></span></pre>
</div>
</div>
</body>
</html>