<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][10905] trunk: Groups: Make sure `BP_Group_Extension::widget_display()` can be used</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://buddypress.trac.wordpress.org/changeset/10905">10905</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://buddypress.trac.wordpress.org/changeset/10905","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>imath</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2016-06-27 03:07:47 +0000 (Mon, 27 Jun 2016)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Groups: Make sure `BP_Group_Extension::widget_display()` can be used
On the single item home (eg: a custom front template), it will now be possible to use `bp_custom_group_boxes()` to get the content provided by the Group extensions in their widget.
2 unit tests are checking this only happens when on the Groups single item home.
Fixes <a href="http://buddypress.trac.wordpress.org/ticket/7131">#7131</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcbpgroupsclassesclassbpgroupextensionphp">trunk/src/bp-groups/classes/class-bp-group-extension.php</a></li>
<li><a href="#trunktestsphpunitassetsgroupextensionsphp">trunk/tests/phpunit/assets/group-extensions.php</a></li>
<li><a href="#trunktestsphpunittestcasesgroupsclassbpgroupextensionphp">trunk/tests/phpunit/testcases/groups/class-bp-group-extension.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcbpgroupsclassesclassbpgroupextensionphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-groups/classes/class-bp-group-extension.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-groups/classes/class-bp-group-extension.php 2016-06-23 17:39:30 UTC (rev 10904)
+++ trunk/src/bp-groups/classes/class-bp-group-extension.php 2016-06-27 03:07:47 UTC (rev 10905)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -763,7 +763,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Hook the group home widget.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if ( ! bp_current_action() && bp_is_current_action( 'home' ) ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( bp_is_group_home() ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> add_action( $this->display_hook, array( &$this, 'widget_display' ) );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre></div>
<a id="trunktestsphpunitassetsgroupextensionsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/assets/group-extensions.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/assets/group-extensions.php 2016-06-23 17:39:30 UTC (rev 10904)
+++ trunk/tests/phpunit/assets/group-extensions.php 2016-06-27 03:07:47 UTC (rev 10905)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -409,3 +409,20 @@
</span><span class="cx" style="display: block; padding: 0 10px"> parent::init( $args );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+class BPTest_Group_Extension_Widget_Method extends BP_Group_Extension {
+ public function __construct() {
+ $class_name = get_class( $this );
+
+ $args = array(
+ 'name' => $class_name,
+ 'slug' => sanitize_title( $class_name ),
+ );
+
+ parent::init( $args );
+ }
+
+ public function widget_display() {
+ echo 'Widget Displayed';
+ }
+}
</ins></span></pre></div>
<a id="trunktestsphpunittestcasesgroupsclassbpgroupextensionphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/testcases/groups/class-bp-group-extension.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/testcases/groups/class-bp-group-extension.php 2016-06-23 17:39:30 UTC (rev 10904)
+++ trunk/tests/phpunit/testcases/groups/class-bp-group-extension.php 2016-06-27 03:07:47 UTC (rev 10905)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -845,4 +845,46 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $this->set_current_user( $old_current_user );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+ /**
+ * @ticket BP7131
+ */
+ public function test_widget_on_group_home_page() {
+ $g = $this->factory->group->create( array(
+ 'status' => 'public',
+ ) );
+ $g_obj = groups_get_group( array( 'group_id' => $g ) );
+
+ $this->go_to( bp_get_group_permalink( $g_obj ) );
+
+ $e1 = new BPTest_Group_Extension_Widget_Method();
+ $e1->_register();
+
+ ob_start();
+ bp_custom_group_boxes();
+ $content = ob_get_clean();
+
+ $this->assertTrue( $content === 'Widget Displayed' );
+ }
+
+ /**
+ * @ticket BP7131
+ */
+ public function test_widget_on_group_members_page() {
+ $g = $this->factory->group->create( array(
+ 'status' => 'public',
+ ) );
+ $g_obj = groups_get_group( array( 'group_id' => $g ) );
+
+ $this->go_to( trailingslashit( bp_get_group_permalink( $g_obj ) ) . 'members/' );
+
+ $e1 = new BPTest_Group_Extension_Widget_Method();
+ $e1->_register();
+
+ ob_start();
+ bp_custom_group_boxes();
+ $content = ob_get_clean();
+
+ $this->assertFalse( $content === 'Widget Displayed' );
+ }
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre>
</div>
</div>
</body>
</html>