<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][10876] trunk: Fix syntax error in back compat block of `bp_core_remove_subnav_item()`.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://buddypress.trac.wordpress.org/changeset/10876">10876</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://buddypress.trac.wordpress.org/changeset/10876","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>boonebgorges</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2016-06-10 14:53:53 +0000 (Fri, 10 Jun 2016)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Fix syntax error in back compat block of `bp_core_remove_subnav_item()`.
The arguments were reversed, causing a compatibility break with plugins
using `bp_core_remove_subnav_item()` to remove group nav items.
We simplify the logic by setting `$component` to 'groups' in thes cases, and
letting the rest of the function handle the nav removal.
To maintain the parallel construction, a similar syntax change has been
introduced to `bp_core_remove_nav_item()`.
Props dcavins, imath.
Fixes <a href="http://buddypress.trac.wordpress.org/ticket/6534">#6534</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcbpcorebpcorebuddybarphp">trunk/src/bp-core/bp-core-buddybar.php</a></li>
<li><a href="#trunktestsphpunittestcasescorenavbpCoreRemoveSubnavItemphp">trunk/tests/phpunit/testcases/core/nav/bpCoreRemoveSubnavItem.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcbpcorebpcorebuddybarphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-core/bp-core-buddybar.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-core/bp-core-buddybar.php 2016-06-07 16:44:35 UTC (rev 10875)
+++ trunk/src/bp-core/bp-core-buddybar.php 2016-06-10 14:53:53 UTC (rev 10876)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -783,7 +783,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> // Backward compatibility for removing group nav items using the group slug as `$parent_slug`.
</span><span class="cx" style="display: block; padding: 0 10px"> if ( ! $component && bp_is_active( 'groups' ) && isset( $bp->groups->nav ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> if ( $bp->groups->nav->get_primary( array( 'slug' => $slug ) ) ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- return bp_core_remove_nav_item( $slug, 'groups' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $component = 'groups';
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -834,7 +834,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> // Backward compatibility for removing group nav items using the group slug as `$parent_slug`.
</span><span class="cx" style="display: block; padding: 0 10px"> if ( ! $component && bp_is_active( 'groups' ) && isset( $bp->groups->nav ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> if ( $bp->groups->nav->get_primary( array( 'slug' => $parent_slug ) ) ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- return bp_core_remove_subnav_item( $slug, $parent_slug, 'groups' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $component = 'groups';
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunktestsphpunittestcasescorenavbpCoreRemoveSubnavItemphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/testcases/core/nav/bpCoreRemoveSubnavItem.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/testcases/core/nav/bpCoreRemoveSubnavItem.php 2016-06-07 16:44:35 UTC (rev 10875)
+++ trunk/tests/phpunit/testcases/core/nav/bpCoreRemoveSubnavItem.php 2016-06-10 14:53:53 UTC (rev 10876)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -70,4 +70,33 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $bp->bp_nav = $_bp_nav;
</span><span class="cx" style="display: block; padding: 0 10px"> $bp->bp_options_nav = $_bp_options_nav;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+ public function test_backcompat_remove_group_nav_items() {
+ $g1 = $this->factory->group->create();
+
+ // In group context
+ $g_obj = groups_get_group( array( 'group_id' => $g1 ) );
+ $this->go_to( bp_get_group_permalink( $g_obj ) );
+
+ bp_core_new_subnav_item( array(
+ 'name' => 'Clam',
+ 'slug' => 'clam',
+ 'parent_slug' => bp_get_current_group_slug(),
+ 'parent_url' => bp_get_group_permalink( $g_obj ),
+ 'screen_function' => 'clam_subnav',
+ ) );
+
+ bp_core_remove_subnav_item( $g_obj->slug, 'clam' );
+
+ $nav = bp_get_nav_menu_items( 'groups' );
+ $found = false;
+ foreach ( $nav as $_nav ) {
+ if ( 'clam' === $_nav->css_id ) {
+ $found = true;
+ break;
+ }
+ }
+
+ $this->assertFalse( $found );
+ }
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre>
</div>
</div>
</body>
</html>