<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][10807] trunk: RTL CSS generation: Move from CSSJanus to RTLCSS.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://buddypress.trac.wordpress.org/changeset/10807">10807</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://buddypress.trac.wordpress.org/changeset/10807","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>dcavins</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2016-05-25 16:38:11 +0000 (Wed, 25 May 2016)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>RTL CSS generation: Move from CSSJanus to RTLCSS.
Moving to the grunt tool RTLCSS for right-to-left
CSS generation keeps us in step with WordPress.
RTLCSS also natively handles more properties than
CSSJanus.
See <a href="http://buddypress.trac.wordpress.org/ticket/7007">#7007</a>.
Props netweb.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkGruntfilejs">trunk/Gruntfile.js</a></li>
<li><a href="#trunkpackagejson">trunk/package.json</a></li>
<li><a href="#trunksrcbpactivitycssmentionscss">trunk/src/bp-activity/css/mentions.css</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkGruntfilejs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/Gruntfile.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/Gruntfile.js 2016-05-25 08:41:54 UTC (rev 10806)
+++ trunk/Gruntfile.js 2016-05-25 16:38:11 UTC (rev 10807)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -8,7 +8,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> '**/*.css'
</span><span class="cx" style="display: block; padding: 0 10px"> ],
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- // CSS exclusions, for excluding files from certain tasks, e.g. cssjanus
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // CSS exclusions, for excluding files from certain tasks, e.g. rtlcss
</ins><span class="cx" style="display: block; padding: 0 10px"> BP_EXCLUDED_CSS = [
</span><span class="cx" style="display: block; padding: 0 10px"> '!**/*-rtl.css'
</span><span class="cx" style="display: block; padding: 0 10px"> ],
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -91,15 +91,22 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> },
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- cssjanus: {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ rtlcss: {
+ options: {
+ opts: {
+ processUrls: false,
+ autoRename: false,
+ clean: true
+ },
+ saveUnmodified: false
+ },
</ins><span class="cx" style="display: block; padding: 0 10px"> core: {
</span><span class="cx" style="display: block; padding: 0 10px"> expand: true,
</span><span class="cx" style="display: block; padding: 0 10px"> cwd: SOURCE_DIR,
</span><span class="cx" style="display: block; padding: 0 10px"> dest: SOURCE_DIR,
</span><span class="cx" style="display: block; padding: 0 10px"> extDot: 'last',
</span><span class="cx" style="display: block; padding: 0 10px"> ext: '-rtl.css',
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- src: BP_CSS.concat( BP_EXCLUDED_CSS, BP_EXCLUDED_MISC ),
- options: { generateExactDuplicates: true }
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ src: BP_CSS.concat( BP_EXCLUDED_CSS, BP_EXCLUDED_MISC )
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> },
</span><span class="cx" style="display: block; padding: 0 10px"> checktextdomain: {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -248,7 +255,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * Register tasks.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- grunt.registerTask( 'src', ['checkDependencies', 'jsvalidate:src', 'jshint', 'scsslint', 'sass', 'cssjanus'] );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ grunt.registerTask( 'src', ['checkDependencies', 'jsvalidate:src', 'jshint', 'scsslint', 'sass', 'rtlcss'] );
</ins><span class="cx" style="display: block; padding: 0 10px"> grunt.registerTask( 'commit', ['src', 'checktextdomain', 'imagemin'] );
</span><span class="cx" style="display: block; padding: 0 10px"> grunt.registerTask( 'build', ['commit', 'clean:all', 'copy:files', 'uglify', 'jsvalidate:build', 'cssmin', 'makepot', 'exec:bpdefault'] );
</span><span class="cx" style="display: block; padding: 0 10px"> grunt.registerTask( 'release', ['build', 'exec:bbpress'] );
</span></span></pre></div>
<a id="trunkpackagejson"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/package.json</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/package.json 2016-05-25 08:41:54 UTC (rev 10806)
+++ trunk/package.json 2016-05-25 16:38:11 UTC (rev 10807)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -14,12 +14,12 @@
</span><span class="cx" style="display: block; padding: 0 10px"> "grunt-contrib-jshint": "~1.0.0",
</span><span class="cx" style="display: block; padding: 0 10px"> "grunt-contrib-uglify": "~0.10.1",
</span><span class="cx" style="display: block; padding: 0 10px"> "grunt-contrib-watch": "~1.0.0",
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- "grunt-cssjanus": "~0.2.4",
</del><span class="cx" style="display: block; padding: 0 10px"> "grunt-exec": "~0.4.6",
</span><span class="cx" style="display: block; padding: 0 10px"> "grunt-check-dependencies": "~0.12.0",
</span><span class="cx" style="display: block; padding: 0 10px"> "grunt-jsvalidate": "~0.2.2",
</span><span class="cx" style="display: block; padding: 0 10px"> "grunt-legacy-util": "^0.2.0",
</span><span class="cx" style="display: block; padding: 0 10px"> "grunt-patch-wordpress": "~0.3.0",
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ "grunt-rtlcss": "~2.0.1",
</ins><span class="cx" style="display: block; padding: 0 10px"> "grunt-sass": "~1.1.0",
</span><span class="cx" style="display: block; padding: 0 10px"> "grunt-scss-lint": "~0.3.8",
</span><span class="cx" style="display: block; padding: 0 10px"> "grunt-wp-i18n": "~0.5.3",
</span></span></pre></div>
<a id="trunksrcbpactivitycssmentionscss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-activity/css/mentions.css</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-activity/css/mentions.css 2016-05-25 08:41:54 UTC (rev 10806)
+++ trunk/src/bp-activity/css/mentions.css 2016-05-25 16:38:11 UTC (rev 10807)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -11,9 +11,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> top: 0;
</span><span class="cx" style="display: block; padding: 0 10px"> z-index: 1000; /* >999 for wp-admin */
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-/* @noflip */
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+/* rtl:ignore */
</ins><span class="cx" style="display: block; padding: 0 10px"> .atwho-view {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- left: 0;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ left: 0;
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> .atwho-view ul {
</span><span class="cx" style="display: block; padding: 0 10px"> background: #FFF;
</span></span></pre>
</div>
</div>
</body>
</html>