<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][10465] trunk/src/bp-core/admin: Improve mobile view of the Settings > Components panel.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://buddypress.trac.wordpress.org/changeset/10465">10465</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://buddypress.trac.wordpress.org/changeset/10465","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>mercime</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2016-01-25 21:37:22 +0000 (Mon, 25 Jan 2016)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Improve mobile view of the Settings > Components panel.
* Use WP_List_Table responsive goodness.
* Move `label` tags into the same `table` cells of the associated `input` fields.
* Remove inline styles.
* Remove unused table markup.
* Add checked/disabled `checkbox` input fields.
* Add dashicons back to the `Core` and `Member` components.
* Add style support to improve the new look.
Props @DJPaul.
Fixes <a href="http://buddypress.trac.wordpress.org/ticket/6803">#6803</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcbpcoreadminbpcoreadmincomponentsphp">trunk/src/bp-core/admin/bp-core-admin-components.php</a></li>
<li><a href="#trunksrcbpcoreadmincsscommonrtlcss">trunk/src/bp-core/admin/css/common-rtl.css</a></li>
<li><a href="#trunksrcbpcoreadmincsscommoncss">trunk/src/bp-core/admin/css/common.css</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcbpcoreadminbpcoreadmincomponentsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-core/admin/bp-core-admin-components.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-core/admin/bp-core-admin-components.php 2016-01-25 21:34:31 UTC (rev 10464)
+++ trunk/src/bp-core/admin/bp-core-admin-components.php 2016-01-25 21:37:22 UTC (rev 10465)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -160,23 +160,15 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> <h3 class="screen-reader-text"><?php _e( 'Components list', 'buddypress' ); ?></h3>
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <table class="widefat fixed plugins" cellspacing="0">
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <table class="wp-list-table widefat plugins">
</ins><span class="cx" style="display: block; padding: 0 10px"> <thead>
</span><span class="cx" style="display: block; padding: 0 10px"> <tr>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <th scope="col" id="cb" class="manage-column column-cb check-column"> </th>
- <th scope="col" id="name" class="manage-column column-name" style="width: 190px;"><?php _e( 'Component', 'buddypress' ); ?></th>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <td id="cb" class="manage-column column-cb check-column"><input id="cb-select-all-1" type="checkbox" disabled><label class="screen-reader-text" for="cb-select-all-1"><?php _e( 'Bulk selection is disabled', 'buddypress' ); ?></label></td>
+ <th scope="col" id="name" class="manage-column column-title column-primary"><?php _e( 'Component', 'buddypress' ); ?></th>
</ins><span class="cx" style="display: block; padding: 0 10px"> <th scope="col" id="description" class="manage-column column-description"><?php _e( 'Description', 'buddypress' ); ?></th>
</span><span class="cx" style="display: block; padding: 0 10px"> </tr>
</span><span class="cx" style="display: block; padding: 0 10px"> </thead>
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <tfoot>
- <tr>
- <th scope="col" class="manage-column column-cb check-column"> </th>
- <th scope="col" class="manage-column column-name" style="width: 190px;"><?php _e( 'Component', 'buddypress' ); ?></th>
- <th scope="col" class="manage-column column-description"><?php _e( 'Description', 'buddypress' ); ?></th>
- </tr>
- </tfoot>
-
</del><span class="cx" style="display: block; padding: 0 10px"> <tbody id="the-list">
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> <?php if ( !empty( $current_components ) ) : ?>
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -190,33 +182,29 @@
</span><span class="cx" style="display: block; padding: 0 10px"> endif; ?>
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> <tr id="<?php echo esc_attr( $name ); ?>" class="<?php echo esc_attr( $name ) . ' ' . esc_attr( $class ); ?>">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <th scope="row">
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <th scope="row" class="check-column">
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> <?php if ( !in_array( $name, array( 'core', 'members' ) ) ) : ?>
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <input type="checkbox" id="bp_components[<?php echo esc_attr( $name ); ?>]" name="bp_components[<?php echo esc_attr( $name ); ?>]" value="1"<?php checked( isset( $active_components[esc_attr( $name )] ) ); ?> />
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <input type="checkbox" id="<?php echo esc_attr( "bp_components[$name]" ); ?>" name="<?php echo esc_attr( "bp_components[$name]" ); ?>" value="1"<?php checked( isset( $active_components[esc_attr( $name )] ) ); ?> /><label for="<?php echo esc_attr( "bp_components[$name]" ); ?>" class="screen-reader-text"><?php printf( __( 'Select %s', 'buddypress' ), esc_html( $labels['title'] ) ); ?></label>
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <?php else : ?>
+
+ <input type="checkbox" id="<?php echo esc_attr( "bp_components[$name]" ); ?>" name="<?php echo esc_attr( "bp_components[$name]" ); ?>" value="1" checked="checked" disabled><label for="<?php echo esc_attr( "bp_components[$name]" ); ?>" class="screen-reader-text"><?php printf( __( '%s is a required component', 'buddypress' ), esc_html( $labels['title'] ) ); ?></label>
+
</ins><span class="cx" style="display: block; padding: 0 10px"> <?php endif; ?>
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> </th>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <td class="plugin-title" style="width: 190px;">
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <td class="plugin-title column-primary">
</ins><span class="cx" style="display: block; padding: 0 10px"> <span></span>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <label for="bp_components[<?php echo esc_attr( $name ); ?>]">
- <strong><?php echo esc_html( $labels['title'] ); ?></strong>
- </label>
-
- <div class="row-actions-visible">
-
- </div>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <strong><?php echo esc_html( $labels['title'] ); ?></strong>
</ins><span class="cx" style="display: block; padding: 0 10px"> </td>
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> <td class="column-description desc">
</span><span class="cx" style="display: block; padding: 0 10px"> <div class="plugin-description">
</span><span class="cx" style="display: block; padding: 0 10px"> <p><?php echo $labels['description']; ?></p>
</span><span class="cx" style="display: block; padding: 0 10px"> </div>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <div class="active second plugin-version-author-uri">
</del><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- </div>
</del><span class="cx" style="display: block; padding: 0 10px"> </td>
</span><span class="cx" style="display: block; padding: 0 10px"> </tr>
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -231,6 +219,15 @@
</span><span class="cx" style="display: block; padding: 0 10px"> <?php endif; ?>
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> </tbody>
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+ <tfoot>
+ <tr>
+ <td class="manage-column column-cb check-column"><input id="cb-select-all-2" type="checkbox" disabled><label class="screen-reader-text" for="cb-select-all-2"><?php _e( 'Bulk selection is disabled', 'buddypress' ); ?></label></td>
+ <th class="manage-column column-title column-primary"><?php _e( 'Component', 'buddypress' ); ?></th>
+ <th class="manage-column column-description"><?php _e( 'Description', 'buddypress' ); ?></th>
+ </tr>
+ </tfoot>
+
</ins><span class="cx" style="display: block; padding: 0 10px"> </table>
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> <input type="hidden" name="bp_components[members]" value="1" />
</span></span></pre></div>
<a id="trunksrcbpcoreadmincsscommonrtlcss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-core/admin/css/common-rtl.css</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-core/admin/css/common-rtl.css 2016-01-25 21:34:31 UTC (rev 10464)
+++ trunk/src/bp-core/admin/css/common-rtl.css 2016-01-25 21:37:22 UTC (rev 10465)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -126,7 +126,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /* Tools */
</span><span class="cx" style="display: block; padding: 0 10px"> #adminmenu .toplevel_page_network-tools div.wp-menu-image:before {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- content: "";
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ content: "";
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /* Components
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -223,11 +223,33 @@
</span><span class="cx" style="display: block; padding: 0 10px"> content: "\f454";
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-#bp-admin-component-form .widefat th {
- display: table-cell;
- vertical-align: top;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+.settings_page_bp-components tr.core td.plugin-title span:before {
+ content: "\f448";
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+.settings_page_bp-components tr.members td.plugin-title span:before {
+ content: "\f307";
+}
+
+#bp-admin-component-form .wp-list-table.plugins .plugin-title {
+ width: 25%;
+}
+
+@media screen and ( max-width: 782px ) {
+ .settings_page_bp-components td.plugin-title span {
+ margin-top: 5px;
+ }
+ #bp-admin-component-form .wp-list-table.plugins .plugin-title {
+ display: block;
+ width: auto;
+ }
+ #bp-admin-component-form .subsubsub {
+ margin-bottom: 0;
+ padding-bottom: 35px;
+ }
+}
+
+
</ins><span class="cx" style="display: block; padding: 0 10px"> /* Version Badge */
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> .bp-badge {
</span></span></pre></div>
<a id="trunksrcbpcoreadmincsscommoncss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-core/admin/css/common.css</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-core/admin/css/common.css 2016-01-25 21:34:31 UTC (rev 10464)
+++ trunk/src/bp-core/admin/css/common.css 2016-01-25 21:37:22 UTC (rev 10465)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -126,7 +126,7 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /* Tools */
</span><span class="cx" style="display: block; padding: 0 10px"> #adminmenu .toplevel_page_network-tools div.wp-menu-image:before {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- content: "";
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ content: "";
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /* Components
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -223,11 +223,33 @@
</span><span class="cx" style="display: block; padding: 0 10px"> content: "\f454";
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-#bp-admin-component-form .widefat th {
- display: table-cell;
- vertical-align: top;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+.settings_page_bp-components tr.core td.plugin-title span:before {
+ content: "\f448";
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+.settings_page_bp-components tr.members td.plugin-title span:before {
+ content: "\f307";
+}
+
+#bp-admin-component-form .wp-list-table.plugins .plugin-title {
+ width: 25%;
+}
+
+@media screen and ( max-width: 782px ) {
+ .settings_page_bp-components td.plugin-title span {
+ margin-top: 5px;
+ }
+ #bp-admin-component-form .wp-list-table.plugins .plugin-title {
+ display: block;
+ width: auto;
+ }
+ #bp-admin-component-form .subsubsub {
+ margin-bottom: 0;
+ padding-bottom: 35px;
+ }
+}
+
+
</ins><span class="cx" style="display: block; padding: 0 10px"> /* Version Badge */
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> .bp-badge {
</span></span></pre>
</div>
</div>
</body>
</html>