<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][10460] trunk: Allow bp_field_css_class() to accept multiple classes.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://buddypress.trac.wordpress.org/changeset/10460">10460</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://buddypress.trac.wordpress.org/changeset/10460","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>dcavins</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2016-01-25 01:49:30 +0000 (Mon, 25 Jan 2016)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Allow bp_field_css_class() to accept multiple classes.
Allow `bp_field_css_class()` to accept more than one class
name passed as a space-separated string or array.
Fixes <a href="http://buddypress.trac.wordpress.org/ticket/6679">#6679</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcbpxprofilebpxprofiletemplatephp">trunk/src/bp-xprofile/bp-xprofile-template.php</a></li>
<li><a href="#trunktestsphpunittestcasesxprofilefunctionsphp">trunk/tests/phpunit/testcases/xprofile/functions.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcbpxprofilebpxprofiletemplatephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-xprofile/bp-xprofile-template.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-xprofile/bp-xprofile-template.php 2016-01-22 18:02:13 UTC (rev 10459)
+++ trunk/src/bp-xprofile/bp-xprofile-template.php 2016-01-25 01:49:30 UTC (rev 10460)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -443,7 +443,13 @@
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * Output the class attribute for a field.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * @param string|bool $class Extra classes to append to class attribute.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @since 1.0.0
+ *
+ * @param array|string $class Extra classes to append to class attribute.
+ * Pass mutiple class names as an array or
+ * space-delimited string.
+ *
+ * @return string
</ins><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function bp_field_css_class( $class = false ) {
</span><span class="cx" style="display: block; padding: 0 10px"> echo bp_get_field_css_class( $class );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -461,7 +467,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $css_classes = array();
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> if ( ! empty( $class ) ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $css_classes[] = sanitize_title( esc_attr( $class ) );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if ( ! is_array( $class ) ) {
+ $class = preg_split( '#\s+#', $class );
+ }
+ $css_classes = array_map( 'sanitize_html_class', $class );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Set a class with the field ID.
</span></span></pre></div>
<a id="trunktestsphpunittestcasesxprofilefunctionsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/testcases/xprofile/functions.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/testcases/xprofile/functions.php 2016-01-22 18:02:13 UTC (rev 10459)
+++ trunk/tests/phpunit/testcases/xprofile/functions.php 2016-01-25 01:49:30 UTC (rev 10460)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -939,4 +939,107 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertFalse( bp_xprofile_is_richtext_enabled_for_field( $f ) );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+ /**
+ * @group bp_get_field_css_class
+ */
+ public function test_bp_get_field_css_class_empty_param() {
+ // Fake the global
+ global $profile_template;
+ $reset_profile_template = $profile_template;
+
+ $profile_template = new stdClass;
+ // Avoid the 'alt' class being added
+ $profile_template->current_field = 2;
+ $profile_template->field = new stdClass;
+ $profile_template->field->id = 145;
+ $profile_template->field->name = 'Pie';
+ $profile_template->field->type = 'textbox';
+
+ $expected_classes = array(
+ 'optional-field',
+ 'field_' . $profile_template->field->id,
+ 'field_' . sanitize_title( $profile_template->field->name ),
+ 'field_type_' . sanitize_title( $profile_template->field->type ),
+ 'visibility-public'
+ );
+
+ $classes = bp_get_field_css_class();
+ preg_match( '/class=["\']?([^"\']*)["\' ]/is', $classes, $matches );
+ $ret_classes = explode( ' ', $matches[1] );
+ $this->assertEqualSets( $expected_classes, $ret_classes );
+
+ // Clean up!
+ $profile_template = $reset_profile_template;
+ }
+
+ /**
+ * @group bp_get_field_css_class
+ */
+ public function test_bp_get_field_css_class_space_delimited_string() {
+ // Fake the global
+ global $profile_template;
+ $reset_profile_template = $profile_template;
+
+ $profile_template = new stdClass;
+ // Avoid the 'alt' class being added
+ $profile_template->current_field = 2;
+ $profile_template->field = new stdClass;
+ $profile_template->field->id = 145;
+ $profile_template->field->name = 'Pie';
+ $profile_template->field->type = 'textbox';
+
+ $expected_classes = array(
+ 'optional-field',
+ 'field_' . $profile_template->field->id,
+ 'field_' . sanitize_title( $profile_template->field->name ),
+ 'field_type_' . sanitize_title( $profile_template->field->type ),
+ 'visibility-public',
+ 'rhubarb',
+ 'apple'
+ );
+
+ $classes = bp_get_field_css_class( 'rhubarb apple' );
+ preg_match( '/class=["\']?([^"\']*)["\' ]/is', $classes, $matches );
+ $ret_classes = explode( ' ', $matches[1] );
+ $this->assertEqualSets( $expected_classes, $ret_classes );
+
+ // Clean up!
+ $profile_template = $reset_profile_template;
+ }
+
+ /**
+ * @group bp_get_field_css_class
+ */
+ public function test_bp_get_field_css_class_array() {
+ // Fake the global
+ global $profile_template;
+ $reset_profile_template = $profile_template;
+
+ $profile_template = new stdClass;
+ // Avoid the 'alt' class being added
+ $profile_template->current_field = 2;
+ $profile_template->field = new stdClass;
+ $profile_template->field->id = 145;
+ $profile_template->field->name = 'Pie';
+ $profile_template->field->type = 'textbox';
+
+ $expected_classes = array(
+ 'optional-field',
+ 'field_' . $profile_template->field->id,
+ 'field_' . sanitize_title( $profile_template->field->name ),
+ 'field_type_' . sanitize_title( $profile_template->field->type ),
+ 'visibility-public',
+ 'blueberry',
+ 'gooseberry'
+ );
+
+ $classes = bp_get_field_css_class( array( 'blueberry', 'gooseberry' ) );
+ preg_match( '/class=["\']?([^"\']*)["\' ]/is', $classes, $matches );
+ $ret_classes = explode( ' ', $matches[1] );
+ $this->assertEqualSets( $expected_classes, $ret_classes );
+
+ // Clean up!
+ $profile_template = $reset_profile_template;
+ }
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre>
</div>
</div>
</body>
</html>