<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][10446] trunk/src: Undeprecate Messages autocomplete scripts and styles.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://buddypress.trac.wordpress.org/changeset/10446">10446</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://buddypress.trac.wordpress.org/changeset/10446","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>boonebgorges</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2016-01-12 16:04:52 +0000 (Tue, 12 Jan 2016)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Undeprecate Messages autocomplete scripts and styles.
These assets were deprecated in <a href="http://buddypress.trac.wordpress.org/changeset/8559">[8559]</a>, with the intention of rewriting the
functionality using `BP_Suggestions`. Until that rewrite happens, let's bring
them back from the dead.
Fixes <a href="http://buddypress.trac.wordpress.org/ticket/6740">#6740</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcbpcoredeprecated21php">trunk/src/bp-core/deprecated/2.1.php</a></li>
<li><a href="#trunksrcbpmessagesbpmessagescssjsphp">trunk/src/bp-messages/bp-messages-cssjs.php</a></li>
<li><a href="#trunksrcbpmessagesjsautocompletejqueryautocompletefbjs">trunk/src/bp-messages/js/autocomplete/jquery.autocompletefb.js</a></li>
</ul>
<h3>Added Paths</h3>
<ul>
<li>trunk/src/bp-messages/css/</li>
<li>trunk/src/bp-messages/css/autocomplete/</li>
<li>trunk/src/bp-messages/js/</li>
<li>trunk/src/bp-messages/js/autocomplete/</li>
</ul>
<h3>Removed Paths</h3>
<ul>
<li>trunk/src/bp-core/deprecated/css/</li>
<li>trunk/src/bp-core/deprecated/js/</li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcbpcoredeprecated21php"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-core/deprecated/2.1.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-core/deprecated/2.1.php 2016-01-08 21:38:46 UTC (rev 10445)
+++ trunk/src/bp-core/deprecated/2.1.php 2016-01-12 16:04:52 UTC (rev 10446)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -16,38 +16,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 2.1.0
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function bp_core_register_deprecated_scripts() {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $min = defined( 'SCRIPT_DEBUG' ) && SCRIPT_DEBUG ? '' : '.min';
- $url = buddypress()->plugin_url . 'bp-core/deprecated/js/';
-
- $scripts = apply_filters( 'bp_core_register_deprecated_scripts', array(
-
- // Messages
- 'bp-jquery-autocomplete' => array(
- 'file' => "{$url}autocomplete/jquery.autocomplete{$min}.js",
- 'dependencies' => array( 'jquery' ),
- ),
-
- 'bp-jquery-autocomplete-fb' => array(
- 'file' => "{$url}autocomplete/jquery.autocompletefb{$min}.js",
- 'dependencies' => array( 'jquery' ),
- ),
-
- 'bp-jquery-bgiframe' => array(
- 'file' => "{$url}autocomplete/jquery.bgiframe{$min}.js",
- 'dependencies' => array( 'jquery' ),
- ),
-
- 'bp-jquery-dimensions' => array(
- 'file' => "{$url}autocomplete/jquery.dimensions{$min}.js",
- 'dependencies' => array( 'jquery' ),
- ),
- ) );
-
- foreach ( $scripts as $id => $script ) {
- wp_register_script( $id, $script['file'], $script['dependencies'], bp_get_version(), true );
- }
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Scripts undeprecated as of 2.5.0.
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-add_action( 'bp_enqueue_scripts', 'bp_core_register_deprecated_scripts', 1 );
</del><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * Register (not enqueue) styles that used to be used by BuddyPress.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -55,27 +25,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 2.1.0
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function bp_core_register_deprecated_styles() {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $min = defined( 'SCRIPT_DEBUG' ) && SCRIPT_DEBUG ? '' : '.min';
- $url = buddypress()->plugin_url . 'bp-core/deprecated/css/';
-
- $styles = apply_filters( 'bp_core_register_deprecated_styles', array(
- // Messages
- 'bp-messages-autocomplete' => array(
- 'file' => "{$url}autocomplete/jquery.autocompletefb{$min}.css",
- 'dependencies' => array(),
- )
- ) );
-
- foreach ( $styles as $id => $style ) {
- wp_register_style( $id, $style['file'], $style['dependencies'], bp_get_version() );
-
- wp_style_add_data( $id, 'rtl', true );
- if ( $min ) {
- wp_style_add_data( $id, 'suffix', $min );
- }
- }
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Scripts undeprecated as of 2.5.0.
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-add_action( 'bp_enqueue_scripts', 'bp_core_register_deprecated_styles', 1 );
</del><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /** BuddyBar *****************************************************************/
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunksrcbpmessagesbpmessagescssjsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-messages/bp-messages-cssjs.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-messages/bp-messages-cssjs.php 2016-01-08 21:38:46 UTC (rev 10445)
+++ trunk/src/bp-messages/bp-messages-cssjs.php 2016-01-12 16:04:52 UTC (rev 10446)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -19,10 +19,13 @@
</span><span class="cx" style="display: block; padding: 0 10px"> if ( bp_is_messages_component() && bp_is_current_action( 'compose' ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> add_action( 'wp_head', 'messages_autocomplete_init_jsblock' );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- wp_enqueue_script( 'bp-jquery-autocomplete' );
- wp_enqueue_script( 'bp-jquery-autocomplete-fb' );
- wp_enqueue_script( 'bp-jquery-bgiframe' );
- wp_enqueue_script( 'bp-jquery-dimensions' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $min = defined( 'SCRIPT_DEBUG' ) && SCRIPT_DEBUG ? '' : '.min';
+ $url = buddypress()->plugin_url . 'bp-messages/js/';
+
+ wp_enqueue_script( 'bp-jquery-autocomplete', "{$url}autocomplete/jquery.autocomplete{$min}.js", array( 'jquery' ), bp_get_version() );
+ wp_enqueue_script( 'bp-jquery-autocomplete-fb', "{$url}autocomplete/jquery.autocompletefb{$min}.js", array( 'jquery' ), bp_get_version() );
+ wp_enqueue_script( 'bp-jquery-bgiframe', "{$url}autocomplete/jquery.bgiframe{$min}.js", array( 'jquery' ), bp_get_version() );
+ wp_enqueue_script( 'bp-jquery-dimensions', "{$url}autocomplete/jquery.dimensions{$min}.js", array( 'jquery' ), bp_get_version() );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> add_action( 'bp_enqueue_scripts', 'messages_add_autocomplete_js' );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -34,7 +37,16 @@
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function messages_add_autocomplete_css() {
</span><span class="cx" style="display: block; padding: 0 10px"> if ( bp_is_messages_component() && bp_is_current_action( 'compose' ) ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- wp_enqueue_style( 'bp-messages-autocomplete' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ $min = defined( 'SCRIPT_DEBUG' ) && SCRIPT_DEBUG ? '' : '.min';
+ $url = buddypress()->plugin_url . 'bp-messages/css/';
+
+ wp_register_style( 'bp-messages-autocomplete', "{$url}autocomplete/jquery.autocompletfb{$min}.css", array(), bp_get_version() );
+
+ wp_style_add_data( 'bp-messages-autocomplete', 'rtl', true );
+ if ( $min ) {
+ wp_style_add_data( 'bp-messages-autocomplete', 'suffix', $min );
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> wp_print_styles();
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre></div>
<a id="trunksrcbpmessagesjsautocompletejqueryautocompletefbjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-messages/js/autocomplete/jquery.autocompletefb.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-core/deprecated/js/autocomplete/jquery.autocompletefb.js 2016-01-08 21:38:46 UTC (rev 10445)
+++ trunk/src/bp-messages/js/autocomplete/jquery.autocompletefb.js 2016-01-12 16:04:52 UTC (rev 10446)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -13,7 +13,6 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * http://www.opensource.org/licenses/mit-license.php
</span><span class="cx" style="display: block; padding: 0 10px"> * http://www.gnu.org/licenses/gpl.html
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-
</del><span class="cx" style="display: block; padding: 0 10px"> jQuery.fn.autoCompletefb = function(options)
</span><span class="cx" style="display: block; padding: 0 10px"> {
</span><span class="cx" style="display: block; padding: 0 10px"> var tmp = this;
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -52,21 +51,21 @@
</span><span class="cx" style="display: block; padding: 0 10px"> var f = settings.foundClass.replace(/\./,'');
</span><span class="cx" style="display: block; padding: 0 10px"> var d = String(d).split(' (');
</span><span class="cx" style="display: block; padding: 0 10px"> var un = d[1].substr(0, d[1].length-1);
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
</ins><span class="cx" style="display: block; padding: 0 10px"> /* Don't add the same user multiple times */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- if( 0 === jQuery(settings.inputClass).siblings('#un-' + un).length ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ if( 0 === jQuery(settings.inputClass).siblings('#un-' + un).length ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> var ln = '#link-' + un;
</span><span class="cx" style="display: block; padding: 0 10px"> var l = jQuery(ln).attr('href');
</span><span class="cx" style="display: block; padding: 0 10px"> var v = '<li class="'+f+'" id="un-'+un+'"><span><a href="'+l+'">'+d[0]+'</a></span> <span class="p">X</span></li>';
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
</ins><span class="cx" style="display: block; padding: 0 10px"> var x = jQuery(settings.inputClass,tmp).before(v);
</span><span class="cx" style="display: block; padding: 0 10px"> jQuery('#send-to-usernames').addClass(un);
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
</ins><span class="cx" style="display: block; padding: 0 10px"> jQuery('.p',x[0].previousSibling).click(function(){
</span><span class="cx" style="display: block; padding: 0 10px"> acfb.removeFind(this);
</span><span class="cx" style="display: block; padding: 0 10px"> });
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- }
-
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> jQuery(settings.inputClass,tmp).val('');
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> });
</span></span></pre>
</div>
</div>
</body>
</html>