<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][10437] trunk: Delete a user's notifications when the user is deleted.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://buddypress.trac.wordpress.org/changeset/10437">10437</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://buddypress.trac.wordpress.org/changeset/10437","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>boonebgorges</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2016-01-05 15:23:11 +0000 (Tue, 05 Jan 2016)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Delete a user's notifications when the user is deleted.
Props henry.wright, Mamaduka.
Fixes <a href="http://buddypress.trac.wordpress.org/ticket/6681">#6681</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcbpnotificationsbpnotificationsfunctionsphp">trunk/src/bp-notifications/bp-notifications-functions.php</a></li>
<li><a href="#trunktestsphpunittestcasesnotificationsfunctionsphp">trunk/tests/phpunit/testcases/notifications/functions.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcbpnotificationsbpnotificationsfunctionsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-notifications/bp-notifications-functions.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-notifications/bp-notifications-functions.php 2016-01-05 15:08:32 UTC (rev 10436)
+++ trunk/src/bp-notifications/bp-notifications-functions.php 2016-01-05 15:23:11 UTC (rev 10437)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -421,6 +421,26 @@
</span><span class="cx" style="display: block; padding: 0 10px"> ) );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+/**
+ * Delete a user's notifications when the user is deleted.
+ *
+ * @since 2.5.0
+ *
+ * @param int $user_id ID of the user who is about to be deleted.
+ * @return int|bool The number of rows deleted, or false on error.
+ */
+function bp_notifications_delete_notifications_on_user_delete( $user_id ) {
+ return BP_Notifications_Notification::delete( array(
+ 'user_id' => $user_id,
+ 'item_id' => false,
+ 'secondary_item_id' => false,
+ 'component_action' => false,
+ 'component_name' => false,
+ ) );
+}
+add_action( 'wpmu_delete_user', 'bp_notifications_delete_notifications_on_user_delete' );
+add_action( 'delete_user', 'bp_notifications_delete_notifications_on_user_delete' );
+
</ins><span class="cx" style="display: block; padding: 0 10px"> /** Mark **********************************************************************/
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span></span></pre></div>
<a id="trunktestsphpunittestcasesnotificationsfunctionsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/tests/phpunit/testcases/notifications/functions.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/tests/phpunit/testcases/notifications/functions.php 2016-01-05 15:08:32 UTC (rev 10436)
+++ trunk/tests/phpunit/testcases/notifications/functions.php 2016-01-05 15:23:11 UTC (rev 10437)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -233,4 +233,65 @@
</span><span class="cx" style="display: block; padding: 0 10px"> // assert
</span><span class="cx" style="display: block; padding: 0 10px"> $this->assertEquals( 2, buddypress()->notifications->query_loop->total_notification_count );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+ /**
+ * @group bp_notifications_delete_notifications_on_user_delete
+ * @ticket BP6681
+ */
+ public function test_bp_notifications_delete_notifications_on_user_delete_should_delete_all_notifications() {
+ $u = $this->factory->user->create();
+
+ // Create notifications
+ $n1 = $this->factory->notification->create( array(
+ 'component_name' => 'messages',
+ 'component_action' => 'new_message',
+ 'item_id' => 99,
+ 'user_id' => $u,
+ ) );
+
+ $n2 = $this->factory->notification->create( array(
+ 'component_name' => 'activity',
+ 'component_action' => 'new_at_mention',
+ 'item_id' => 99,
+ 'user_id' => $u,
+ ) );
+
+ $n3 = $this->factory->notification->create( array(
+ 'component_name' => 'groups',
+ 'user_id' => $u,
+ ) );
+
+ $n4 = $this->factory->notification->create( array(
+ 'component_name' => 'friends',
+ 'component_action' => 'friendship_request',
+ 'user_id' => $u,
+ ) );
+
+ // Create notification for non-core component
+ $n5 = $this->factory->notification->create( array(
+ 'component_name' => 'foo',
+ 'component_action' => 'bar',
+ 'item_id' => 99,
+ 'user_id' => $u,
+ ) );
+
+ global $wpdb, $bp;
+
+ /**
+ * Can't use BP_Notifications_Notification::get(), because class::parse_args,
+ * checks against bp_notifications_get_registered_components()
+ * and if component is disabled it will be ignored.
+ */
+ $query = $wpdb->prepare( "SELECT id FROM {$bp->notifications->table_name} WHERE user_id = %d and is_new = 1", $u );
+
+ // Make sure notifications have been added.
+ $found1 = $wpdb->get_col( $query );
+ $this->assertEqualSets( array( $n1, $n2, $n3, $n4, $n5 ), $found1 );
+
+ wp_delete_user( $u );
+
+ // Check if notifications are deleted.
+ $found2 = $wpdb->get_col( $query );
+ $this->assertEmpty( $found2 );
+ }
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span></span></pre>
</div>
</div>
</body>
</html>