<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][10425] trunk/src/bp-core: Scrutinizr feedback cleanup.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://buddypress.trac.wordpress.org/changeset/10425">10425</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://buddypress.trac.wordpress.org/changeset/10425","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>tw2113</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2015-12-22 05:41:48 +0000 (Tue, 22 Dec 2015)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Scrutinizr feedback cleanup.
See <a href="http://buddypress.trac.wordpress.org/ticket/6398">#6398</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcbpcorebpcoreattachmentsphp">trunk/src/bp-core/bp-core-attachments.php</a></li>
<li><a href="#trunksrcbpcorebpcorefunctionsphp">trunk/src/bp-core/bp-core-functions.php</a></li>
<li><a href="#trunksrcbpcorebpcoretemplateloaderphp">trunk/src/bp-core/bp-core-template-loader.php</a></li>
<li><a href="#trunksrcbpcorebpcoretemplatephp">trunk/src/bp-core/bp-core-template.php</a></li>
<li><a href="#trunksrcbpcoreclassesclassbpcoreuserphp">trunk/src/bp-core/classes/class-bp-core-user.php</a></li>
<li><a href="#trunksrcbpcoreclassesclassbpuserqueryphp">trunk/src/bp-core/classes/class-bp-user-query.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcbpcorebpcoreattachmentsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-core/bp-core-attachments.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-core/bp-core-attachments.php 2015-12-22 05:40:21 UTC (rev 10424)
+++ trunk/src/bp-core/bp-core-attachments.php 2015-12-22 05:41:48 UTC (rev 10425)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1069,7 +1069,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @type string $component The component for the object (eg: groups, xprofile). Required.
</span><span class="cx" style="display: block; padding: 0 10px"> * @type string $cover_image_dir The Cover image dir to write the image into. Required.
</span><span class="cx" style="display: block; padding: 0 10px"> * }
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * @param BP_Attachment_Cover_Image $cover_image_class The class to use to fit the cover image.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @param BP_Attachment_Cover_Image|null $cover_image_class The class to use to fit the cover image.
</ins><span class="cx" style="display: block; padding: 0 10px"> * @return bool|array An array containing cover image data on success, false otherwise.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function bp_attachments_cover_image_generate_file( $args = array(), $cover_image_class = null ) {
</span></span></pre></div>
<a id="trunksrcbpcorebpcorefunctionsphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-core/bp-core-functions.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-core/bp-core-functions.php 2015-12-22 05:40:21 UTC (rev 10424)
+++ trunk/src/bp-core/bp-core-functions.php 2015-12-22 05:41:48 UTC (rev 10425)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -2559,6 +2559,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @uses switch_to_blog()
</span><span class="cx" style="display: block; padding: 0 10px"> * @uses wp_upload_dir()
</span><span class="cx" style="display: block; padding: 0 10px"> * @uses restore_current_blog()
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ *
+ * @return string
</ins><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function bp_upload_dir() {
</span><span class="cx" style="display: block; padding: 0 10px"> $bp = buddypress();
</span></span></pre></div>
<a id="trunksrcbpcorebpcoretemplateloaderphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-core/bp-core-template-loader.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-core/bp-core-template-loader.php 2015-12-22 05:40:21 UTC (rev 10424)
+++ trunk/src/bp-core/bp-core-template-loader.php 2015-12-22 05:41:48 UTC (rev 10425)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -23,10 +23,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @uses load_template()
</span><span class="cx" style="display: block; padding: 0 10px"> * @uses get_template_part()
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * @param string $slug Template part slug. Used to generate filenames,
- * eg 'friends' for 'friends.php'.
- * @param string $name Optional. Template part name. Used to generate
- * secondary filenames, eg 'personal' for 'activity-personal.php'.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @param string $slug Template part slug. Used to generate filenames,
+ * eg 'friends' for 'friends.php'.
+ * @param string|null $name Optional. Template part name. Used to generate
+ * secondary filenames, eg 'personal' for 'activity-personal.php'.
</ins><span class="cx" style="display: block; padding: 0 10px"> * @return string Path to located template. See {@link bp_locate_template()}.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function bp_get_template_part( $slug, $name = null ) {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -255,10 +255,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @see bp_get_template_part() for a description of $slug and $name params.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * @param string $slug See {@link bp_get_template_part()}.
- * @param string $name See {@link bp_get_template_part()}.
- * @param bool $echo If true, template content will be echoed. If false,
- * returned. Default: true.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @param string $slug See {@link bp_get_template_part()}.
+ * @param string|null $name See {@link bp_get_template_part()}.
+ * @param bool $echo If true, template content will be echoed. If false,
+ * returned. Default: true.
</ins><span class="cx" style="display: block; padding: 0 10px"> * @return string|null If $echo, returns the template content.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function bp_buffer_template_part( $slug, $name = null, $echo = true ) {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -371,7 +371,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 1.7.0
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @param array $stacks Array of template locations.
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * @return array() Array of all template locations registered so far.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @return array Array of all template locations registered so far.
</ins><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function bp_add_template_stack_locations( $stacks = array() ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $retval = array();
</span></span></pre></div>
<a id="trunksrcbpcorebpcoretemplatephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-core/bp-core-template.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-core/bp-core-template.php 2015-12-22 05:40:21 UTC (rev 10424)
+++ trunk/src/bp-core/bp-core-template.php 2015-12-22 05:41:48 UTC (rev 10425)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -311,6 +311,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * Returns the name of the BP site. Used in RSS headers.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 1.6.0
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ *
+ * @return string
</ins><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function bp_get_site_name() {
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunksrcbpcoreclassesclassbpcoreuserphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-core/classes/class-bp-core-user.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-core/classes/class-bp-core-user.php 2015-12-22 05:40:21 UTC (rev 10424)
+++ trunk/src/bp-core/classes/class-bp-core-user.php 2015-12-22 05:41:48 UTC (rev 10425)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -444,13 +444,13 @@
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @global wpdb $wpdb WordPress database object.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * @param string $letter The letter the users names are to start with.
- * @param int $limit The number of users we wish to retrive.
- * @param int $page The page number we are currently on, used in conjunction
- * with $limit to get the start position for the limit.
- * @param bool $populate_extras If we should populate extra user fields.
- * @param string $exclude Comma-separated IDs of users whose results
- * aren't to be fetched.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @param string $letter The letter the users names are to start with.
+ * @param int|null $limit The number of users we wish to retrive.
+ * @param int $page The page number we are currently on, used in conjunction
+ * with $limit to get the start position for the limit.
+ * @param bool $populate_extras If we should populate extra user fields.
+ * @param string $exclude Comma-separated IDs of users whose results
+ * aren't to be fetched.
</ins><span class="cx" style="display: block; padding: 0 10px"> * @return mixed False on error, otherwise associative array of results.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public static function get_users_by_letter( $letter, $limit = null, $page = 1, $populate_extras = true, $exclude = '' ) {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -531,11 +531,11 @@
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @global wpdb $wpdb WordPress database object.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * @param array $user_ids The user IDs of the users who we wish to
- * fetch information on.
- * @param int $limit The limit of results we want.
- * @param int $page The page we are on for pagination.
- * @param bool $populate_extras If we should populate extra user fields.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @param array $user_ids The user IDs of the users who we wish to
+ * fetch information on.
+ * @param int|null $limit The limit of results we want.
+ * @param int $page The page we are on for pagination.
+ * @param bool $populate_extras If we should populate extra user fields.
</ins><span class="cx" style="display: block; padding: 0 10px"> * @return array Associative array.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public static function get_specific_users( $user_ids, $limit = null, $page = 1, $populate_extras = true ) {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -626,11 +626,11 @@
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @global wpdb $wpdb WordPress database object.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * @param string $search_terms The terms to search the profile table
- * value column for.
- * @param int $limit The limit of results we want.
- * @param int $page The page we are on for pagination.
- * @param boolean $populate_extras If we should populate extra user fields.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @param string $search_terms The terms to search the profile table
+ * value column for.
+ * @param int|null $limit The limit of results we want.
+ * @param int $page The page we are on for pagination.
+ * @param boolean $populate_extras If we should populate extra user fields.
</ins><span class="cx" style="display: block; padding: 0 10px"> * @return array Associative array.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public static function search_users( $search_terms, $limit = null, $page = 1, $populate_extras = true ) {
</span></span></pre></div>
<a id="trunksrcbpcoreclassesclassbpuserqueryphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-core/classes/class-bp-user-query.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-core/classes/class-bp-user-query.php 2015-12-22 05:40:21 UTC (rev 10424)
+++ trunk/src/bp-core/classes/class-bp-user-query.php 2015-12-22 05:41:48 UTC (rev 10425)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -143,7 +143,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @since 1.7.0
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- * @param string|array $query See {@link BP_User_Query}.
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ * @param string|array|null $query See {@link BP_User_Query}.
</ins><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> public function __construct( $query = null ) {
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre>
</div>
</div>
</body>
</html>