<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][10294] trunk/src/bp-templates/bp-legacy/js/buddypress.js: bp-legacy: Pass all `$_POST` data when a user makes a "What's New" activity update.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://buddypress.trac.wordpress.org/changeset/10294">10294</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://buddypress.trac.wordpress.org/changeset/10294","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>r-a-y</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2015-10-21 18:57:52 +0000 (Wed, 21 Oct 2015)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>bp-legacy: Pass all `$_POST` data when a user makes a "What's New" activity update.
Previously, if a plugin developer added a custom field to the "What's New"
form, the data for that field would not get passed to our AJAX post handler
- `bp_legacy_theme_post_update()`. This made things difficult for plugin
developers to save their custom activity data.
This commit passes all valid `$_POST` fields from the "What's New" form to
our AJAX post handler, which will allow plugin developers to find their
data and save it.
See https://buddypress.trac.wordpress.org/ticket/6569#comment:21 for a
brief example.
Props imath.
See <a href="http://buddypress.trac.wordpress.org/ticket/6569">#6569</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcbptemplatesbplegacyjsbuddypressjs">trunk/src/bp-templates/bp-legacy/js/buddypress.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcbptemplatesbplegacyjsbuddypressjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-templates/bp-legacy/js/buddypress.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-templates/bp-legacy/js/buddypress.js 2015-10-21 16:41:38 UTC (rev 10293)
+++ trunk/src/bp-templates/bp-legacy/js/buddypress.js 2015-10-21 18:57:52 UTC (rev 10294)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -104,13 +104,31 @@
</span><span class="cx" style="display: block; padding: 0 10px"> jq('#aw-whats-new-submit').on( 'click', function() {
</span><span class="cx" style="display: block; padding: 0 10px"> var last_date_recorded = 0,
</span><span class="cx" style="display: block; padding: 0 10px"> button = jq(this),
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- form = button.closest('form#whats-new-form');
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ form = button.closest('form#whats-new-form'),
+ inputs = {}, post_data;
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- form.children().each( function() {
- if ( jq.nodeName(this, 'textarea') || jq.nodeName(this, 'input') ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Get all inputs and organize them into an object {name: value}
+ jq.each( form.serializeArray(), function( key, input ) {
+ // Only include public extra data
+ if ( '_' !== input.name.substr( 0, 1 ) && 'whats-new' !== input.name.substr( 0, 9 ) ) {
+ if ( ! inputs[ input.name ] ) {
+ inputs[ input.name ] = input.value;
+ } else {
+ // Checkboxes/dropdown list can have multiple selected value
+ if ( ! jq.isArray( inputs[ input.name ] ) ) {
+ inputs[ input.name ] = new Array( inputs[ input.name ], input.value );
+ } else {
+ inputs[ input.name ].push( input.value );
+ }
+ }
+ }
+ } );
+
+ form.find( '*' ).each( function() {
+ if ( jq.nodeName( this, 'textarea' ) || jq.nodeName( this, 'input' ) ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> jq(this).prop( 'disabled', true );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- });
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ } );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /* Remove any errors */
</span><span class="cx" style="display: block; padding: 0 10px"> jq('div.error').remove();
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -145,7 +163,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> object = jq('#whats-new-post-object').val();
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- jq.post( ajaxurl, {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ post_data = jq.extend( {
</ins><span class="cx" style="display: block; padding: 0 10px"> action: 'post_update',
</span><span class="cx" style="display: block; padding: 0 10px"> 'cookie': bp_get_cookies(),
</span><span class="cx" style="display: block; padding: 0 10px"> '_wpnonce_post_update': jq('#_wpnonce_post_update').val(),
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -154,11 +172,11 @@
</span><span class="cx" style="display: block; padding: 0 10px"> 'item_id': item_id,
</span><span class="cx" style="display: block; padding: 0 10px"> 'since': last_date_recorded,
</span><span class="cx" style="display: block; padding: 0 10px"> '_bp_as_nonce': jq('#_bp_as_nonce').val() || ''
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- },
- function(response) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ }, inputs );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- form.children().each( function() {
- if ( jq.nodeName(this, 'textarea') || jq.nodeName(this, 'input') ) {
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ jq.post( ajaxurl, post_data, function( response ) {
+ form.find( '*' ).each( function() {
+ if ( jq.nodeName( this, 'textarea' ) || jq.nodeName( this, 'input' ) ) {
</ins><span class="cx" style="display: block; padding: 0 10px"> jq(this).prop( 'disabled', false );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> });
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -205,6 +223,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> jq('li.new-update').hide().slideDown( 300 );
</span><span class="cx" style="display: block; padding: 0 10px"> jq('li.new-update').removeClass( 'new-update' );
</span><span class="cx" style="display: block; padding: 0 10px"> jq('#whats-new').val('');
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ form.get(0).reset();
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // reset vars to get newest activities
</span><span class="cx" style="display: block; padding: 0 10px"> newest_activities = '';
</span></span></pre>
</div>
</div>
</body>
</html>