<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][10060] trunk/src/bp-messages: Messages: Audit `bp-messages-template.php` output functions and add escaping and/or sanitization based on their anticipated results and usages.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://buddypress.trac.wordpress.org/changeset/10060">10060</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://buddypress.trac.wordpress.org/changeset/10060","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>johnjamesjacoby</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2015-08-22 16:18:39 +0000 (Sat, 22 Aug 2015)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Messages: Audit `bp-messages-template.php` output functions and add escaping and/or sanitization based on their anticipated results and usages.
Hat-tip boonebgorges. Props vnd.
For 2.4 (trunk)</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcbpmessagesbpmessagesfiltersphp">trunk/src/bp-messages/bp-messages-filters.php</a></li>
<li><a href="#trunksrcbpmessagesbpmessagestemplatephp">trunk/src/bp-messages/bp-messages-template.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcbpmessagesbpmessagesfiltersphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-messages/bp-messages-filters.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-messages/bp-messages-filters.php 2015-08-22 13:42:35 UTC (rev 10059)
+++ trunk/src/bp-messages/bp-messages-filters.php 2015-08-22 16:18:39 UTC (rev 10060)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -57,14 +57,15 @@
</span><span class="cx" style="display: block; padding: 0 10px"> add_filter( 'bp_get_message_notice_text', 'wpautop' );
</span><span class="cx" style="display: block; padding: 0 10px"> add_filter( 'bp_get_the_thread_message_content', 'wpautop' );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-add_filter( 'bp_get_message_notice_subject', 'stripslashes_deep' );
-add_filter( 'bp_get_message_notice_text', 'stripslashes_deep' );
-add_filter( 'bp_get_message_thread_subject', 'stripslashes_deep' );
-add_filter( 'bp_get_message_thread_excerpt', 'stripslashes_deep' );
-add_filter( 'bp_get_messages_subject_value', 'stripslashes_deep' );
-add_filter( 'bp_get_messages_content_value', 'stripslashes_deep' );
-add_filter( 'bp_get_the_thread_message_content', 'stripslashes_deep' );
-add_filter( 'bp_get_the_thread_subject', 'stripslashes_deep' );
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+add_filter( 'bp_get_message_notice_subject', 'stripslashes_deep' );
+add_filter( 'bp_get_message_notice_text', 'stripslashes_deep' );
+add_filter( 'bp_get_message_thread_subject', 'stripslashes_deep' );
+add_filter( 'bp_get_message_thread_excerpt', 'stripslashes_deep' );
+add_filter( 'bp_get_message_get_recipient_usernames', 'stripslashes_deep' );
+add_filter( 'bp_get_messages_subject_value', 'stripslashes_deep' );
+add_filter( 'bp_get_messages_content_value', 'stripslashes_deep' );
+add_filter( 'bp_get_the_thread_message_content', 'stripslashes_deep' );
+add_filter( 'bp_get_the_thread_subject', 'stripslashes_deep' );
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * Enforce limitations on viewing private message contents
</span></span></pre></div>
<a id="trunksrcbpmessagesbpmessagestemplatephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-messages/bp-messages-template.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-messages/bp-messages-template.php 2015-08-22 13:42:35 UTC (rev 10059)
+++ trunk/src/bp-messages/bp-messages-template.php 2015-08-22 16:18:39 UTC (rev 10060)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -656,7 +656,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * Output the URL for deleting the current thread.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function bp_message_thread_delete_link() {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- echo bp_get_message_thread_delete_link();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ echo esc_url( bp_get_message_thread_delete_link() );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * Generate the URL for deleting the current thread.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -775,7 +775,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * Output the CSS class for the current thread.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function bp_message_css_class() {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- echo bp_get_message_css_class();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ echo esc_attr( bp_get_message_css_class() );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * Generate the CSS class for the current thread.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -827,7 +827,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * Output the current thread's unread count.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function bp_message_thread_unread_count() {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- echo bp_get_message_thread_unread_count();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ echo esc_html( bp_get_message_thread_unread_count() );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * Get the current thread's unread count.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1102,7 +1102,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> $message = sprintf( _n( 'Viewing %1$s - %2$s of %3$s message', 'Viewing %1$s - %2$s of %3$s messages', $messages_template->total_thread_count, 'buddypress' ), $from_num, $to_num, $total );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- echo $message;
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ echo esc_html( $message );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1149,7 +1149,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * Echo the form action for Messages HTML forms.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function bp_messages_form_action() {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- echo bp_get_messages_form_action();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ echo esc_url( bp_get_messages_form_action() );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * Return the form action for Messages HTML forms.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1172,7 +1172,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * Output the default username for the recipient box.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function bp_messages_username_value() {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- echo bp_get_messages_username_value();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ echo esc_attr( bp_get_messages_username_value() );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * Get the default username for the recipient box.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1203,7 +1203,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * Output the default value for the Subject field.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function bp_messages_subject_value() {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- echo bp_get_messages_subject_value();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ echo esc_attr( bp_get_messages_subject_value() );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * Get the default value for the Subject field.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1214,6 +1214,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @return string
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function bp_get_messages_subject_value() {
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+ // Sanitized in bp-messages-filters.php
</ins><span class="cx" style="display: block; padding: 0 10px"> $subject = ! empty( $_POST['subject'] )
</span><span class="cx" style="display: block; padding: 0 10px"> ? $_POST['subject']
</span><span class="cx" style="display: block; padding: 0 10px"> : '';
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1232,7 +1234,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * Output the default value for the Compose content field.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function bp_messages_content_value() {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- echo bp_get_messages_content_value();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ echo esc_textarea( bp_get_messages_content_value() );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * Get the default value fo the Compose content field.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1244,7 +1246,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function bp_get_messages_content_value() {
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $content = !empty( $_POST['content'] )
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Sanitized in bp-messages-filters.php
+ $content = ! empty( $_POST['content'] )
</ins><span class="cx" style="display: block; padding: 0 10px"> ? $_POST['content']
</span><span class="cx" style="display: block; padding: 0 10px"> : '';
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1370,7 +1373,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * Output the ID of the current notice in the loop.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function bp_message_notice_id() {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- echo bp_get_message_notice_id();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ echo (int) bp_get_message_notice_id();
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * Get the ID of the current notice in the loop.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1466,7 +1469,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * Output the URL for deleting the current notice.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function bp_message_notice_delete_link() {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- echo bp_get_message_notice_delete_link();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ echo esc_url( bp_get_message_notice_delete_link() );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * Get the URL for deleting the current notice.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1491,7 +1494,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * Output the URL for deactivating the current notice.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function bp_message_activate_deactivate_link() {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- echo bp_get_message_activate_deactivate_link();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ echo esc_url( bp_get_message_activate_deactivate_link() );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * Get the URL for deactivating the current notice.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1521,7 +1524,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * Output the Deactivate/Activate text for the notice action link.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function bp_message_activate_deactivate_text() {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- echo bp_get_message_activate_deactivate_text();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ echo esc_html( bp_get_message_activate_deactivate_text() );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * Generate the text ('Deactivate' or 'Activate') for the notice action link.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1611,7 +1614,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * Output the URL for the Private Message link in member profile headers.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function bp_send_private_message_link() {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- echo bp_get_send_private_message_link();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ echo esc_url( bp_get_send_private_message_link() );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * Generate the URL for the Private Message link in member profile headers.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1688,7 +1691,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * Output the URL of the Messages AJAX loader gif.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function bp_message_loading_image_src() {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- echo bp_get_message_loading_image_src();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ echo esc_url( bp_get_message_loading_image_src() );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * Get the URL of the Messages AJAX loader gif.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1736,7 +1739,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * Output recipient usernames for prefilling the 'To' field on the Compose screen.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function bp_message_get_recipient_usernames() {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- echo bp_get_message_get_recipient_usernames();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ echo esc_attr( bp_get_message_get_recipient_usernames() );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * Get the recipient usernames for prefilling the 'To' field on the Compose screen.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1744,8 +1747,12 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @return string
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function bp_get_message_get_recipient_usernames() {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $recipients = isset( $_GET['r'] ) ? stripslashes( $_GET['r'] ) : '';
</del><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Sanitized in bp-messages-filters.php
+ $recipients = isset( $_GET['r'] )
+ ? $_GET['r']
+ : '';
+
</ins><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * Filters the recipients usernames for prefilling the 'To' field on the Compose screen.
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1981,7 +1988,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * Output the 'ASC' or 'DESC' messages order string for this loop.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function bp_thread_messages_order() {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- echo bp_get_thread_messages_order();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ echo esc_attr( bp_get_thread_messages_order() );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * Get the 'ASC' or 'DESC' messages order string for this loop.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -2019,7 +2026,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * Output the ID of the thread that the current loop belongs to.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function bp_the_thread_id() {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- echo bp_get_the_thread_id();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ echo (int) bp_get_the_thread_id();
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * Get the ID of the thread that the current loop belongs to.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -2072,7 +2079,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> *
</span><span class="cx" style="display: block; padding: 0 10px"> * @return string
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-function bp_get_the_thread_recipients(){
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+function bp_get_the_thread_recipients() {
</ins><span class="cx" style="display: block; padding: 0 10px"> if ( 5 <= bp_get_thread_recipients_count() ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $recipients = sprintf( __( '%s recipients', 'buddypress' ), number_format_i18n( bp_get_thread_recipients_count() ) );
</span><span class="cx" style="display: block; padding: 0 10px"> } else {
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -2160,7 +2167,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @since BuddyPress (1.9.0)
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function bp_the_thread_message_id() {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- echo bp_get_the_thread_message_id();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ echo (int) bp_get_the_thread_message_id();
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * Get the ID of the current message in the thread.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -2192,7 +2199,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @since BuddyPress (2.1.0)
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function bp_the_thread_message_css_class() {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- echo bp_get_the_thread_message_css_class();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ echo esc_attr( bp_get_the_thread_message_css_class() );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * Generate the CSS classes for messages within a single thread.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -2233,7 +2240,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * Output the CSS class used for message zebra striping.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function bp_the_thread_message_alt_class() {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- echo bp_get_the_thread_message_alt_class();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ echo esc_attr( bp_get_the_thread_message_alt_class() );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * Get the CSS class used for message zebra striping.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -2265,7 +2272,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * @since BuddyPress (2.1.0)
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function bp_the_thread_message_sender_id() {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- echo bp_get_the_thread_message_sender_id();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ echo (int) bp_get_the_thread_message_sender_id();
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * Return the ID for message sender within a single thread.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -2341,7 +2348,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * Output a link to the sender of the current message.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function bp_the_thread_message_sender_link() {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- echo bp_get_the_thread_message_sender_link();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ echo esc_url( bp_get_the_thread_message_sender_link() );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * Get a link to the sender of the current message.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -2365,7 +2372,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * Output the display name of the sender of the current message.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function bp_the_thread_message_sender_name() {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- echo bp_get_the_thread_message_sender_name();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ echo esc_html( bp_get_the_thread_message_sender_name() );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * Get the display name of the sender of the current message.
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -2395,7 +2402,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> * Output the URL for deleting the current thread.
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function bp_the_thread_delete_link() {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- echo bp_get_the_thread_delete_link();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ echo esc_url( bp_get_the_thread_delete_link() );
</ins><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> /**
</span><span class="cx" style="display: block; padding: 0 10px"> * Get the URL for deleting the current thread.
</span></span></pre>
</div>
</div>
</body>
</html>