<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][9249] trunk/src/bp-core/bp-core-filters.php: Core: Make page title on member pages unique.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://buddypress.trac.wordpress.org/changeset/9249">9249</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://buddypress.trac.wordpress.org/changeset/9249","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>r-a-y</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2014-12-22 02:31:06 +0000 (Mon, 22 Dec 2014)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Core: Make page title on member pages unique.
This commit partially reverts <a href="http://buddypress.trac.wordpress.org/changeset/9105">r9105</a>, which made the `<title>` element the
same across all member pages, which goes against SEO conventions.
This commit does the following:
* When on a member's landing page (eg. example.com/members/admin/), the page title will be `admin | {SITE NAME}`.
* Uses the profile navigation name in the page title instead of the component's admin title. For example, when on `example.com/members/admin/profile/`, the page title will be `'admin | Profile | {SITE NAME}'` instead of `'admin | Extended Profiles | {SITE NAME}'`.
* Adds the profile subnav name in the page title when on a member component sub-page. For example, when on `example.com/members/admin/activity/mentions/`, the page title will be `admin | Activity | Mentions | {SITE NAME}`.
Fixes <a href="http://buddypress.trac.wordpress.org/ticket/5838">#5838</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcbpcorebpcorefiltersphp">trunk/src/bp-core/bp-core-filters.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcbpcorebpcorefiltersphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-core/bp-core-filters.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-core/bp-core-filters.php 2014-12-21 11:55:47 UTC (rev 9248)
+++ trunk/src/bp-core/bp-core-filters.php 2014-12-22 02:31:06 UTC (rev 9249)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -445,8 +445,49 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Displayed user
</span><span class="cx" style="display: block; padding: 0 10px"> if ( bp_get_displayed_user_fullname() && ! is_404() ) {
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- $title = bp_get_displayed_user_fullname();
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Get the component's ID to try and get its name
+ $component_id = $component_name = bp_current_component();
</ins><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Use the component nav name
+ if ( ! empty( $bp->bp_nav[$component_id] ) ) {
+ // Remove counts that are added by the nav item
+ $span = strpos( $bp->bp_nav[ $component_id ]['name'], '<span' );
+ if ( false !== $span ) {
+ $component_name = substr( $bp->bp_nav[ $component_id ]['name'], 0, $span - 1 );
+
+ } else {
+ $component_name = $bp->bp_nav[ $component_id ]['name'];
+ }
+
+ // Fall back on the component ID
+ } elseif ( ! empty( $bp->{$component_id}->id ) ) {
+ $component_name = ucwords( $bp->{$component_id}->id );
+ }
+
+ // Append action name if we're on a member component sub-page
+ if ( ! empty( $bp->bp_options_nav[ $component_id ][ bp_current_action() ]['name'] ) && ! empty( $bp->canonical_stack['action'] ) ) {
+ $component_subnav_name = "{$bp->bp_options_nav[ $component_id ][ bp_current_action() ]['name']}";
+ } else {
+ $component_subnav_name = '';
+ }
+
+ // If on the user profile's landing page, just use the fullname
+ if ( bp_is_current_component( $bp->default_component ) && bp_get_requested_url() === bp_displayed_user_domain() ) {
+ $title = bp_get_displayed_user_fullname();
+
+ // Use component name on member pages
+ } else {
+ // If we have a subnav name, add it separately for localization
+ if ( ! empty( $component_subnav_name ) ) {
+ // translators: construct the page title. 1 = user name, 2 = component name, 3 = seperator, 4 = component subnav name
+ $title = strip_tags( sprintf( __( '%1$s %3$s %2$s %3$s %4$s', 'buddypress' ), bp_get_displayed_user_fullname(), $component_name, $sep, $component_subnav_name ) );
+
+ } else {
+ // translators: construct the page title. 1 = user name, 2 = component name, 3 = seperator
+ $title = strip_tags( sprintf( __( '%1$s %3$s %2$s', 'buddypress' ), bp_get_displayed_user_fullname(), $component_name, $sep ) );
+ }
+ }
+
</ins><span class="cx" style="display: block; padding: 0 10px"> // A single group
</span><span class="cx" style="display: block; padding: 0 10px"> } elseif ( bp_is_active( 'groups' ) && ! empty( $bp->groups->current_group ) && ! empty( $bp->bp_options_nav[ $bp->groups->current_group->slug ] ) ) {
</span><span class="cx" style="display: block; padding: 0 10px"> $subnav = isset( $bp->bp_options_nav[ $bp->groups->current_group->slug ][ bp_current_action() ]['name'] ) ? $bp->bp_options_nav[ $bp->groups->current_group->slug ][ bp_current_action() ]['name'] : '';
</span></span></pre>
</div>
</div>
</body>
</html>