<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][9143] trunk/src: Improve labeling and validation behavior of notifications Bulk Action dropdown.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://buddypress.trac.wordpress.org/changeset/9143">9143</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://buddypress.trac.wordpress.org/changeset/9143","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>boonebgorges</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2014-11-14 15:16:38 +0000 (Fri, 14 Nov 2014)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Improve labeling and validation behavior of notifications Bulk Action dropdown.
Props lakrisgubben, hnla.
Fixes <a href="http://buddypress.trac.wordpress.org/ticket/5513">#5513</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcbpnotificationsbpnotificationstemplatephp">trunk/src/bp-notifications/bp-notifications-template.php</a></li>
<li><a href="#trunksrcbptemplatesbplegacybuddypressmemberssinglenotificationsnotificationsloopphp">trunk/src/bp-templates/bp-legacy/buddypress/members/single/notifications/notifications-loop.php</a></li>
<li><a href="#trunksrcbptemplatesbplegacycssbuddypresscss">trunk/src/bp-templates/bp-legacy/css/buddypress.css</a></li>
<li><a href="#trunksrcbptemplatesbplegacyjsbuddypressjs">trunk/src/bp-templates/bp-legacy/js/buddypress.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcbpnotificationsbpnotificationstemplatephp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-notifications/bp-notifications-template.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-notifications/bp-notifications-template.php 2014-11-14 14:01:30 UTC (rev 9142)
+++ trunk/src/bp-notifications/bp-notifications-template.php 2014-11-14 15:16:38 UTC (rev 9143)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1057,6 +1057,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> */
</span><span class="cx" style="display: block; padding: 0 10px"> function bp_notifications_bulk_management_dropdown() {
</span><span class="cx" style="display: block; padding: 0 10px"> ?>
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <label class="bp-screen-reader-text" for="notification-select"><?php _e( 'Select Bulk Action', 'buddypress' ); ?></label>
</ins><span class="cx" style="display: block; padding: 0 10px"> <select name="notification_bulk_action" id="notification-select">
</span><span class="cx" style="display: block; padding: 0 10px"> <option value="" selected="selected"><?php _e( 'Bulk Actions', 'buddypress' ); ?></option>
</span><span class="cx" style="display: block; padding: 0 10px">
</span></span></pre></div>
<a id="trunksrcbptemplatesbplegacybuddypressmemberssinglenotificationsnotificationsloopphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-templates/bp-legacy/buddypress/members/single/notifications/notifications-loop.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-templates/bp-legacy/buddypress/members/single/notifications/notifications-loop.php 2014-11-14 14:01:30 UTC (rev 9142)
+++ trunk/src/bp-templates/bp-legacy/buddypress/members/single/notifications/notifications-loop.php 2014-11-14 15:16:38 UTC (rev 9143)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -3,7 +3,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> <thead>
</span><span class="cx" style="display: block; padding: 0 10px"> <tr>
</span><span class="cx" style="display: block; padding: 0 10px"> <th class="icon"></th>
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <th><label for="select-all-notifications"><?php _e( 'Select all', 'buddypress' ); ?></label><input id="select-all-notifications" type="checkbox"></th>
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <th><label class="bp-screen-reader-text" for="select-all-notifications"><?php _e( 'Select all', 'buddypress' ); ?></label><input id="select-all-notifications" type="checkbox"></th>
</ins><span class="cx" style="display: block; padding: 0 10px"> <th class="title"><?php _e( 'Notification', 'buddypress' ); ?></th>
</span><span class="cx" style="display: block; padding: 0 10px"> <th class="date"><?php _e( 'Date Received', 'buddypress' ); ?></th>
</span><span class="cx" style="display: block; padding: 0 10px"> <th class="actions"><?php _e( 'Actions', 'buddypress' ); ?></th>
</span></span></pre></div>
<a id="trunksrcbptemplatesbplegacycssbuddypresscss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-templates/bp-legacy/css/buddypress.css</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-templates/bp-legacy/css/buddypress.css 2014-11-14 14:01:30 UTC (rev 9142)
+++ trunk/src/bp-templates/bp-legacy/css/buddypress.css 2014-11-14 15:16:38 UTC (rev 9143)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -728,15 +728,15 @@
</span><span class="cx" style="display: block; padding: 0 10px"> #buddypress .standard-form #profile-details-section {
</span><span class="cx" style="display: block; padding: 0 10px"> float: right;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-#buddypress .standard-form #blog-details-section {
- clear: left;
-}
-#buddypress label[for="select-all-notifications"] {
- display: none;
-}
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+#buddypress .standard-form #blog-details-section,
</ins><span class="cx" style="display: block; padding: 0 10px"> #buddypress #notifications-bulk-management {
</span><span class="cx" style="display: block; padding: 0 10px"> clear: left;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+body.no-js #buddypress #notifications-bulk-management #select-all-notifications,
+body.no-js #buddypress label[for="message-type-select"],
+body.no-js #buddypress #message-type-select,
+body.no-js #buddypress #delete_inbox_messages,
+body.no-js #buddypress #delete_sentbox_messages,
</ins><span class="cx" style="display: block; padding: 0 10px"> body.no-js #buddypress #notifications-bulk-management #select-all-notifications {
</span><span class="cx" style="display: block; padding: 0 10px"> display: none;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -827,6 +827,17 @@
</span><span class="cx" style="display: block; padding: 0 10px"> #buddypress .wp-editor-wrap input[type=reset] {
</span><span class="cx" style="display: block; padding: 0 10px"> padding: 0 10px 1px;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+/* Form classes & generic attr styling */
+#buddypress form *[disabled="disabled"]{
+ cursor: default;
+ opacity: .4;
+ }
+.bp-screen-reader-text {
+ clip: rect(1px, 1px, 1px, 1px);
+ position: absolute;
+}
+
</ins><span class="cx" style="display: block; padding: 0 10px"> /*--------------------------------------------------------------
</span><span class="cx" style="display: block; padding: 0 10px"> 3.6 - Ajax Loading
</span><span class="cx" style="display: block; padding: 0 10px"> --------------------------------------------------------------*/
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -871,6 +882,7 @@
</span><span class="cx" style="display: block; padding: 0 10px"> #buddypress input[type="submit"].disabled,
</span><span class="cx" style="display: block; padding: 0 10px"> #buddypress input[type="button"].disabled,
</span><span class="cx" style="display: block; padding: 0 10px"> #buddypress input[type="reset"].disabled,
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+#buddypress input[type="submit"][disabled=disabled],
</ins><span class="cx" style="display: block; padding: 0 10px"> #buddypress button.pending,
</span><span class="cx" style="display: block; padding: 0 10px"> #buddypress button.disabled,
</span><span class="cx" style="display: block; padding: 0 10px"> #buddypress div.pending a,
</span></span></pre></div>
<a id="trunksrcbptemplatesbplegacyjsbuddypressjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-templates/bp-legacy/js/buddypress.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-templates/bp-legacy/js/buddypress.js 2014-11-14 14:01:30 UTC (rev 9142)
+++ trunk/src/bp-templates/bp-legacy/js/buddypress.js 2014-11-14 15:16:38 UTC (rev 9143)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -1538,6 +1538,14 @@
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px"> });
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ /* Make sure a 'Bulk Action' is selected before submiting the form */
+ jq('#notification-bulk-manage').attr('disabled', 'disabled');
+
+ /* Remove the disabled attribute from the form submit button when bulk action has a value */
+ jq('#notification-select').on('change', function(){
+ jq('#notification-bulk-manage').attr('disabled', jq(this).val().length <= 0);
+ });
+
</ins><span class="cx" style="display: block; padding: 0 10px"> /* Close site wide notices in the sidebar */
</span><span class="cx" style="display: block; padding: 0 10px"> jq('#close-notice').on( 'click', function() {
</span><span class="cx" style="display: block; padding: 0 10px"> jq(this).addClass('loading');
</span></span></pre>
</div>
</div>
</body>
</html>