<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][9084] trunk/src/bp-xprofile: Update XProfile admin area title CSS and JS to bring it up-to-speed with WordPress 4.0 expectations.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta" style="font-size: 105%">
<dt style="float: left; width: 6em; font-weight: bold">Revision</dt> <dd><a style="font-weight: bold" href="http://buddypress.trac.wordpress.org/changeset/9084">9084</a><script type="application/ld+json">{"@context":"http://schema.org","@type":"EmailMessage","description":"Review this Commit","action":{"@type":"ViewAction","url":"http://buddypress.trac.wordpress.org/changeset/9084","name":"Review Commit"}}</script></dd>
<dt style="float: left; width: 6em; font-weight: bold">Author</dt> <dd>johnjamesjacoby</dd>
<dt style="float: left; width: 6em; font-weight: bold">Date</dt> <dd>2014-10-16 18:20:17 +0000 (Thu, 16 Oct 2014)</dd>
</dl>
<pre style='padding-left: 1em; margin: 2em 0; border-left: 2px solid #ccc; line-height: 1.25; font-size: 105%; font-family: sans-serif'>Update XProfile admin area title CSS and JS to bring it up-to-speed with WordPress 4.0 expectations.
* Remove placeholder attributes on titles and rely on accompanying labels
* Show/hide title labels the way WordPress posts currently do
* Add 20px bottom margin to title wrappers to separate it from descriptions
* Tweak admin area form markup slightly to accommodate these improvements</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcbpxprofileadmincssadminrtlcss">trunk/src/bp-xprofile/admin/css/admin-rtl.css</a></li>
<li><a href="#trunksrcbpxprofileadmincssadmincss">trunk/src/bp-xprofile/admin/css/admin.css</a></li>
<li><a href="#trunksrcbpxprofileadminjsadminjs">trunk/src/bp-xprofile/admin/js/admin.js</a></li>
<li><a href="#trunksrcbpxprofilebpxprofileclassesphp">trunk/src/bp-xprofile/bp-xprofile-classes.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcbpxprofileadmincssadminrtlcss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-xprofile/admin/css/admin-rtl.css</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-xprofile/admin/css/admin-rtl.css 2014-10-15 22:03:54 UTC (rev 9083)
+++ trunk/src/bp-xprofile/admin/css/admin-rtl.css 2014-10-16 18:20:17 UTC (rev 9084)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -249,3 +249,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> border: 1px solid #ddd;
</span><span class="cx" style="display: block; padding: 0 10px"> width: 100%;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+#bp-xprofile-add-field .titlewrap,
+#bp-xprofile-add-field-group .titlewrap {
+ margin-bottom: 20px;
+}
</ins></span></pre></div>
<a id="trunksrcbpxprofileadmincssadmincss"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-xprofile/admin/css/admin.css</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-xprofile/admin/css/admin.css 2014-10-15 22:03:54 UTC (rev 9083)
+++ trunk/src/bp-xprofile/admin/css/admin.css 2014-10-16 18:20:17 UTC (rev 9084)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -249,3 +249,8 @@
</span><span class="cx" style="display: block; padding: 0 10px"> border: 1px solid #ddd;
</span><span class="cx" style="display: block; padding: 0 10px"> width: 100%;
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
+#bp-xprofile-add-field .titlewrap,
+#bp-xprofile-add-field-group .titlewrap {
+ margin-bottom: 20px;
+}
</ins></span></pre></div>
<a id="trunksrcbpxprofileadminjsadminjs"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-xprofile/admin/js/admin.js</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-xprofile/admin/js/admin.js 2014-10-15 22:03:54 UTC (rev 9083)
+++ trunk/src/bp-xprofile/admin/js/admin.js 2014-10-16 18:20:17 UTC (rev 9084)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -119,11 +119,37 @@
</span><span class="cx" style="display: block; padding: 0 10px"> jQuery( '.sortable, .sortable span' ).css( 'cursor', 'default' );
</span><span class="cx" style="display: block; padding: 0 10px"> }
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+function titleHint( id ) {
+ id = id || 'title';
+
+ var title = jQuery('#' + id), titleprompt = jQuery('#' + id + '-prompt-text');
+
+ if ( '' === title.val() ) {
+ titleprompt.removeClass('screen-reader-text');
+ }
+
+ titleprompt.click(function(){
+ jQuery(this).addClass('screen-reader-text');
+ title.focus();
+ });
+
+ title.blur(function(){
+ if ( '' === this.value ) {
+ titleprompt.removeClass('screen-reader-text');
+ }
+ }).focus(function(){
+ titleprompt.addClass('screen-reader-text');
+ }).keydown(function(e){
+ titleprompt.addClass('screen-reader-text');
+ jQuery(this).unbind(e);
+ });
+};
+
</ins><span class="cx" style="display: block; padding: 0 10px"> jQuery( document ).ready( function() {
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> // Set focus in Field Title, if we're on the right page
</span><span class="cx" style="display: block; padding: 0 10px"> jQuery( '#bp-xprofile-add-field #title' ).focus();
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">-
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+
</ins><span class="cx" style="display: block; padding: 0 10px"> // Set up deleting options ajax
</span><span class="cx" style="display: block; padding: 0 10px"> jQuery( 'a.ajax-option-delete' ).on( 'click', function() {
</span><span class="cx" style="display: block; padding: 0 10px"> var theId = this.id.split( '-' );
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -197,6 +223,9 @@
</span><span class="cx" style="display: block; padding: 0 10px"> // Allow reordering of field options
</span><span class="cx" style="display: block; padding: 0 10px"> enableSortableFieldOptions( jQuery('#fieldtype :selected').val() );
</span><span class="cx" style="display: block; padding: 0 10px">
</span><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ // Handle title placeholder text the WordPress way
+ titleHint( 'title' );
+
</ins><span class="cx" style="display: block; padding: 0 10px"> // tabs init with a custom tab template and an "add" callback filling in the content
</span><span class="cx" style="display: block; padding: 0 10px"> var $tab_items,
</span><span class="cx" style="display: block; padding: 0 10px"> $tabs = jQuery( '#tabs' ).tabs();
</span></span></pre></div>
<a id="trunksrcbpxprofilebpxprofileclassesphp"></a>
<div class="modfile"><h4 style="background-color: #eee; color: inherit; margin: 1em 0; padding: 1.3em; font-size: 115%">Modified: trunk/src/bp-xprofile/bp-xprofile-classes.php</h4>
<pre class="diff"><span>
<span class="info" style="display: block; padding: 0 10px; color: #888">--- trunk/src/bp-xprofile/bp-xprofile-classes.php 2014-10-15 22:03:54 UTC (rev 9083)
+++ trunk/src/bp-xprofile/bp-xprofile-classes.php 2014-10-16 18:20:17 UTC (rev 9084)
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -493,14 +493,14 @@
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="cx" style="display: block; padding: 0 10px"> <?php endif; ?>
</span><span class="cx" style="display: block; padding: 0 10px">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <form action="<?php echo esc_url( $action ); ?>" method="post">
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <form id="bp-xprofile-add-field-group" action="<?php echo esc_url( $action ); ?>" method="post">
</ins><span class="cx" style="display: block; padding: 0 10px"> <div id="poststuff">
</span><span class="cx" style="display: block; padding: 0 10px"> <div id="post-body" class="metabox-holder columns-2">
</span><span class="cx" style="display: block; padding: 0 10px"> <div id="post-body-content">
</span><span class="cx" style="display: block; padding: 0 10px"> <div id="titlediv">
</span><span class="cx" style="display: block; padding: 0 10px"> <div id="titlewrap">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <label class="screen-reader-text" id="title-prompt-text" for="title"><?php esc_html_e( 'Field Group Title', 'buddypress') ?></label>
- <input type="text" name="group_name" autocomplete="off" id="title" value="<?php echo esc_attr( $this->name ); ?>" placeholder="<?php echo esc_attr_x( 'Group Name', 'XProfile admin edit group', 'buddypress' ); ?>" />
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <label id="title-prompt-text" for="title"><?php esc_html_e( 'Field Group Name', 'buddypress') ?></label>
+ <input type="text" name="group_name" id="title" value="<?php echo esc_attr( $this->name ); ?>" autocomplete="off" />
</ins><span class="cx" style="display: block; padding: 0 10px"> </div>
</span><span class="cx" style="display: block; padding: 0 10px"> </div>
</span><span class="cx" style="display: block; padding: 0 10px">
</span><span class="lines" style="display: block; padding: 0 10px; color: #888">@@ -920,7 +920,10 @@
</span><span class="cx" style="display: block; padding: 0 10px"> <div id="post-body" class="metabox-holder columns-<?php echo ( 1 == get_current_screen()->get_columns() ) ? '1' : '2'; ?>">
</span><span class="cx" style="display: block; padding: 0 10px"> <div id="post-body-content">
</span><span class="cx" style="display: block; padding: 0 10px"> <div id="titlediv">
</span><del style="background-color: #fdd; text-decoration:none; display:block; padding: 0 10px">- <input type="text" name="title" id="title" value="<?php echo esc_attr( $this->name ); ?>" placeholder="<?php echo esc_attr_x( 'Field Name', 'XProfile admin edit field', 'buddypress' ); ?>" />
</del><ins style="background-color: #dfd; text-decoration:none; display:block; padding: 0 10px">+ <div class="titlewrap">
+ <label id="title-prompt-text" for="title"><?php echo esc_attr_x( 'Field Name', 'XProfile admin edit field', 'buddypress' ); ?></label>
+ <input type="text" name="title" id="title" value="<?php echo esc_attr( $this->name ); ?>" autocomplete="off" />
+ </div>
</ins><span class="cx" style="display: block; padding: 0 10px"> </div>
</span><span class="cx" style="display: block; padding: 0 10px"> <div class="postbox">
</span><span class="cx" style="display: block; padding: 0 10px"> <h3><?php _e( 'Field Description', 'buddypress' ); ?></h3>
</span></span></pre>
</div>
</div>
</body>
</html>