<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][8994] trunk/src/bp-core: Remove 'Edit' post link on BuddyPress pages.</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://buddypress.trac.wordpress.org/changeset/8994">8994</a></dd>
<dt>Author</dt> <dd>r-a-y</dd>
<dt>Date</dt> <dd>2014-09-08 18:47:36 +0000 (Mon, 08 Sep 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Remove 'Edit' post link on BuddyPress pages.
Changes in bp_core_load_template() (<a href="http://buddypress.trac.wordpress.org/changeset/8932">r8932</a>) to set the post to the current
BP directory page and <a href="http://buddypress.trac.wordpress.org/ticket/5418">#5418</a> to set the post type to 'page' resulted in
showing the "Edit" post link at the bottom of BuddyPress pages and in
the WP Toolbar for users with the 'edit_post' capability.
Since the "Edit" post link does not make sense on BuddyPress pages, this
commit manually removes the 'Edit' post link from rendering on BuddyPress
pages and in the WP Toolbar.
Fixes <a href="http://buddypress.trac.wordpress.org/ticket/5853">#5853</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcbpcorebpcoreadminbarphp">trunk/src/bp-core/bp-core-adminbar.php</a></li>
<li><a href="#trunksrcbpcorebpcorethemecompatibilityphp">trunk/src/bp-core/bp-core-theme-compatibility.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcbpcorebpcoreadminbarphp"></a>
<div class="modfile"><h4>Modified: trunk/src/bp-core/bp-core-adminbar.php (8993 => 8994)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/bp-core/bp-core-adminbar.php 2014-09-08 18:30:41 UTC (rev 8993)
+++ trunk/src/bp-core/bp-core-adminbar.php 2014-09-08 18:47:36 UTC (rev 8994)
</span><span class="lines">@@ -39,6 +39,12 @@
</span><span class="cx"> 'class' => 'ab-sub-secondary'
</span><span class="cx"> )
</span><span class="cx"> ) );
</span><ins>+
+ // Remove 'Edit' post link as it's not applicable to BP
+ // Remove when https://core.trac.wordpress.org/ticket/29538 is addressed
+ if ( is_buddypress() ) {
+ $wp_admin_bar->remove_node( 'edit' );
+ }
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx"> add_action( 'admin_bar_menu', 'bp_admin_bar_my_account_root', 100 );
</span></span></pre></div>
<a id="trunksrcbpcorebpcorethemecompatibilityphp"></a>
<div class="modfile"><h4>Modified: trunk/src/bp-core/bp-core-theme-compatibility.php (8993 => 8994)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/bp-core/bp-core-theme-compatibility.php 2014-09-08 18:30:41 UTC (rev 8993)
+++ trunk/src/bp-core/bp-core-theme-compatibility.php 2014-09-08 18:47:36 UTC (rev 8994)
</span><span class="lines">@@ -556,6 +556,9 @@
</span><span class="cx">
</span><span class="cx"> // If we are resetting a post, we are in theme compat
</span><span class="cx"> bp_set_theme_compat_active( true );
</span><ins>+
+ // If we are in theme compat, we don't need the 'Edit' post link
+ add_filter( 'get_edit_post_link', '__return_false' );
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> /**
</span></span></pre>
</div>
</div>
</body>
</html>