<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][8934] trunk/src/bp-groups/bp-groups-classes.php: BP_Group_Extension should automatically handle redirects after the 'edit' screen save routine</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://buddypress.trac.wordpress.org/changeset/8934">8934</a></dd>
<dt>Author</dt> <dd>boonebgorges</dd>
<dt>Date</dt> <dd>2014-08-17 18:11:40 +0000 (Sun, 17 Aug 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>BP_Group_Extension should automatically handle redirects after the 'edit' screen save routine
After handling POSTed settings save on the 'edit' view of a BP_Group_Extension
plugin, plugins were previously required to handle their own redirects
(primarily to avoid "are you sure you want to resubmit the data?" browser
prompts when reloading the page). This created a disparity between the 'edit'
screen and the 'create' and 'admin' screens, the latter two of which handled
their own redirect logic.
This changeset performs the necessary redirect after calling the edit screen
save callback. There is some logic in place to ensure that no double redirects
take place.
Fixes <a href="http://buddypress.trac.wordpress.org/ticket/5557">#5557</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcbpgroupsbpgroupsclassesphp">trunk/src/bp-groups/bp-groups-classes.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcbpgroupsbpgroupsclassesphp"></a>
<div class="modfile"><h4>Modified: trunk/src/bp-groups/bp-groups-classes.php (8933 => 8934)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/bp-groups/bp-groups-classes.php 2014-08-17 10:30:41 UTC (rev 8933)
+++ trunk/src/bp-groups/bp-groups-classes.php 2014-08-17 18:11:40 UTC (rev 8934)
</span><span class="lines">@@ -3001,6 +3001,14 @@
</span><span class="cx"> protected $legacy_properties_converted = array();
</span><span class="cx">
</span><span class="cx"> /**
</span><ins>+ * Redirect location as defined by post-edit save callback.
+ *
+ * @since BuddyPress (2.1.0)
+ * @var string
+ */
+ protected $post_save_redirect;
+
+ /**
</ins><span class="cx"> * Miscellaneous data as set by the __set() magic method.
</span><span class="cx"> *
</span><span class="cx"> * @since BuddyPress (1.8.0)
</span><span class="lines">@@ -3689,7 +3697,24 @@
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> $this->check_nonce( 'edit' );
</span><ins>+
+ // Detect whether the screen_save_callback is performing a
+ // redirect, so that we don't do one of our own
+ add_filter( 'wp_redirect', array( $this, 'detect_post_save_redirect' ) );
+
+ // Call the extension's save routine
</ins><span class="cx"> call_user_func( $this->screens['edit']['screen_save_callback'], $this->group_id );
</span><ins>+
+ // Clean up detection filters
+ remove_filter( 'wp_redirect', array( $this, 'detect_post_save_redirect' ) );
+
+ // Perform a redirect only if one has not already taken place
+ if ( empty( $this->post_save_redirect ) ) {
+ $redirect_to = apply_filters( 'bp_group_extension_edit_screen_save_redirect', bp_get_requested_url( ) );
+
+ bp_core_redirect( $redirect_to );
+ die();
+ }
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> /**
</span><span class="lines">@@ -3753,6 +3778,22 @@
</span><span class="cx"> return ! empty( $matches[0] );
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+ /**
+ * Detect redirects hardcoded into edit_screen_save() callbacks.
+ *
+ * @since BuddyPress (2.1.0)
+ *
+ * @param string $location
+ * @return string
+ */
+ public function detect_post_save_redirect( $redirect = '' ) {
+ if ( ! empty( $redirect ) ) {
+ $this->post_save_redirect = $redirect;
+ }
+
+ return $redirect;
+ }
+
</ins><span class="cx"> /** Admin *************************************************************/
</span><span class="cx">
</span><span class="cx"> /**
</span></span></pre>
</div>
</div>
</body>
</html>