<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][8819] trunk/src: Introduce bp_the_profile_field_ids(), and use as appropriate throughout BP</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://buddypress.trac.wordpress.org/changeset/8819">8819</a></dd>
<dt>Author</dt> <dd>boonebgorges</dd>
<dt>Date</dt> <dd>2014-08-13 00:30:12 +0000 (Wed, 13 Aug 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Introduce bp_the_profile_field_ids(), and use as appropriate throughout BP
The POST routine run when editing one's xprofile-powered profile (or
registering for an account when the registration form includes xprofile fields)
works in part by sending a list of field IDs in the 'field_ids' <input> element.
These field IDs are then used to decide which POST keys to look for when saving
submitted profile values. Historically, the function powering this field_ids
element has been bp_the_profile_group_field_ids(), which pulls up only the
field IDs from a single field group. Normally this works fine, because the
typical Profile > Edit screen only allows for the editing of a single field
group at a time. However, the introduction in BP 2.0 of Settings > Profile
demonstrates that this technique breaks when attempting to save more than one
field group at a time.
The new bp_the_profile_field_ids() replaces this logic by pulling up all the
field_ids from all the groups in the $profile_template global object.
In order to provide for backward compatibility with themes that may have
overridden the modified templates (in particular, members/single/settings/profile.php),
we add logic to the Settings > Profile save routine that looks for any
submitted profile fields that are not present in the field_ids array.
Fixes <a href="http://buddypress.trac.wordpress.org/ticket/5666">#5666</a>
Props boonebgorges, r-a-y</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcbptemplatesbplegacybuddypressmembersregisterphp">trunk/src/bp-templates/bp-legacy/buddypress/members/register.php</a></li>
<li><a href="#trunksrcbptemplatesbplegacybuddypressmemberssingleprofileeditphp">trunk/src/bp-templates/bp-legacy/buddypress/members/single/profile/edit.php</a></li>
<li><a href="#trunksrcbptemplatesbplegacybuddypressmemberssinglesettingsprofilephp">trunk/src/bp-templates/bp-legacy/buddypress/members/single/settings/profile.php</a></li>
<li><a href="#trunksrcbpxprofilebpxprofileactionsphp">trunk/src/bp-xprofile/bp-xprofile-actions.php</a></li>
<li><a href="#trunksrcbpxprofilebpxprofiletemplatephp">trunk/src/bp-xprofile/bp-xprofile-template.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcbptemplatesbplegacybuddypressmembersregisterphp"></a>
<div class="modfile"><h4>Modified: trunk/src/bp-templates/bp-legacy/buddypress/members/register.php (8818 => 8819)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/bp-templates/bp-legacy/buddypress/members/register.php 2014-08-12 21:31:40 UTC (rev 8818)
+++ trunk/src/bp-templates/bp-legacy/buddypress/members/register.php 2014-08-13 00:30:12 UTC (rev 8819)
</span><span class="lines">@@ -104,7 +104,7 @@
</span><span class="cx">
</span><span class="cx"> <?php endwhile; ?>
</span><span class="cx">
</span><del>- <input type="hidden" name="signup_profile_field_ids" id="signup_profile_field_ids" value="<?php bp_the_profile_group_field_ids(); ?>" />
</del><ins>+ <input type="hidden" name="signup_profile_field_ids" id="signup_profile_field_ids" value="<?php bp_the_profile_field_ids(); ?>" />
</ins><span class="cx">
</span><span class="cx"> <?php endwhile; endif; endif; ?>
</span><span class="cx">
</span></span></pre></div>
<a id="trunksrcbptemplatesbplegacybuddypressmemberssingleprofileeditphp"></a>
<div class="modfile"><h4>Modified: trunk/src/bp-templates/bp-legacy/buddypress/members/single/profile/edit.php (8818 => 8819)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/bp-templates/bp-legacy/buddypress/members/single/profile/edit.php 2014-08-12 21:31:40 UTC (rev 8818)
+++ trunk/src/bp-templates/bp-legacy/buddypress/members/single/profile/edit.php 2014-08-13 00:30:12 UTC (rev 8819)
</span><span class="lines">@@ -63,7 +63,7 @@
</span><span class="cx"> <input type="submit" name="profile-group-edit-submit" id="profile-group-edit-submit" value="<?php esc_attr_e( 'Save Changes', 'buddypress' ); ?> " />
</span><span class="cx"> </div>
</span><span class="cx">
</span><del>- <input type="hidden" name="field_ids" id="field_ids" value="<?php bp_the_profile_group_field_ids(); ?>" />
</del><ins>+ <input type="hidden" name="field_ids" id="field_ids" value="<?php bp_the_profile_field_ids(); ?>" />
</ins><span class="cx">
</span><span class="cx"> <?php wp_nonce_field( 'bp_xprofile_edit' ); ?>
</span><span class="cx">
</span></span></pre></div>
<a id="trunksrcbptemplatesbplegacybuddypressmemberssinglesettingsprofilephp"></a>
<div class="modfile"><h4>Modified: trunk/src/bp-templates/bp-legacy/buddypress/members/single/settings/profile.php (8818 => 8819)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/bp-templates/bp-legacy/buddypress/members/single/settings/profile.php 2014-08-12 21:31:40 UTC (rev 8818)
+++ trunk/src/bp-templates/bp-legacy/buddypress/members/single/settings/profile.php 2014-08-13 00:30:12 UTC (rev 8819)
</span><span class="lines">@@ -46,7 +46,7 @@
</span><span class="cx">
</span><span class="cx"> <?php wp_nonce_field( 'bp_xprofile_settings' ); ?>
</span><span class="cx">
</span><del>- <input type="hidden" name="field_ids" id="field_ids" value="<?php bp_the_profile_group_field_ids(); ?>" />
</del><ins>+ <input type="hidden" name="field_ids" id="field_ids" value="<?php bp_the_profile_field_ids(); ?>" />
</ins><span class="cx">
</span><span class="cx"> </form>
</span><span class="cx">
</span></span></pre></div>
<a id="trunksrcbpxprofilebpxprofileactionsphp"></a>
<div class="modfile"><h4>Modified: trunk/src/bp-xprofile/bp-xprofile-actions.php (8818 => 8819)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/bp-xprofile/bp-xprofile-actions.php 2014-08-12 21:31:40 UTC (rev 8818)
+++ trunk/src/bp-xprofile/bp-xprofile-actions.php 2014-08-13 00:30:12 UTC (rev 8819)
</span><span class="lines">@@ -85,6 +85,17 @@
</span><span class="cx"> // Get the POST'ed field ID's
</span><span class="cx"> $posted_field_ids = explode( ',', $_POST['field_ids'] );
</span><span class="cx">
</span><ins>+ // Backward compatibility: a bug in BP 2.0 caused only a single
+ // group's field IDs to be submitted. Look for values submitted
+ // in the POST request that may not appear in 'field_ids', and
+ // add them to the list of IDs to save.
+ foreach ( $_POST as $posted_key => $posted_value ) {
+ preg_match( '/^field_([0-9]+)_visibility$/', $posted_key, $matches );
+ if ( ! empty( $matches[1] ) && ! in_array( $matches[1], $posted_field_ids ) ) {
+ $posted_field_ids[] = $matches[1];
+ }
+ }
+
</ins><span class="cx"> // Save the visibility settings
</span><span class="cx"> foreach ( $posted_field_ids as $field_id ) {
</span><span class="cx">
</span></span></pre></div>
<a id="trunksrcbpxprofilebpxprofiletemplatephp"></a>
<div class="modfile"><h4>Modified: trunk/src/bp-xprofile/bp-xprofile-template.php (8818 => 8819)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/bp-xprofile/bp-xprofile-template.php 2014-08-12 21:31:40 UTC (rev 8818)
+++ trunk/src/bp-xprofile/bp-xprofile-template.php 2014-08-13 00:30:12 UTC (rev 8819)
</span><span class="lines">@@ -314,6 +314,34 @@
</span><span class="cx"> return substr( $field_ids, 0, -1 );
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+/**
+ * Output a comma-separated list of field IDs that are to be submitted on profile edit.
+ *
+ * @since BuddyPress (2.1.0)
+ */
+function bp_the_profile_field_ids() {
+ echo bp_get_the_profile_field_ids();
+}
+ /**
+ * Generate a comma-separated list of field IDs that are to be submitted on profile edit.
+ *
+ * @since BuddyPress (2.1.0)
+ *
+ * @return string
+ */
+ function bp_get_the_profile_field_ids() {
+ global $profile_template;
+
+ $field_ids = array();
+ foreach ( $profile_template->groups as $group ) {
+ $field_ids = array_merge( $field_ids, wp_list_pluck( $group->fields, 'id' ) );
+ }
+
+ $field_ids = implode( ',', wp_parse_id_list( $field_ids ) );
+
+ return apply_filters( 'bp_get_tthe_profile_field_ids', $field_ids );
+ }
+
</ins><span class="cx"> function bp_profile_fields() {
</span><span class="cx"> global $profile_template;
</span><span class="cx"> return $profile_template->profile_fields();
</span></span></pre>
</div>
</div>
</body>
</html>