<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][8751] trunk/src/bp-groups/bp-groups-template.php: Clean up `bp_get_group_avatar()`:</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://buddypress.trac.wordpress.org/changeset/8751">8751</a></dd>
<dt>Author</dt> <dd>johnjamesjacoby</dd>
<dt>Date</dt> <dd>2014-08-03 02:17:58 +0000 (Sun, 03 Aug 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Clean up `bp_get_group_avatar()`:
* Remove `$bp` global
* Use `bp_parse_args()`
* Code format tidying
* Pass `$r` through filter
* Add documentation</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcbpgroupsbpgroupstemplatephp">trunk/src/bp-groups/bp-groups-template.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcbpgroupsbpgroupstemplatephp"></a>
<div class="modfile"><h4>Modified: trunk/src/bp-groups/bp-groups-template.php (8750 => 8751)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/bp-groups/bp-groups-template.php 2014-08-02 23:47:12 UTC (rev 8750)
+++ trunk/src/bp-groups/bp-groups-template.php 2014-08-03 02:17:58 UTC (rev 8751)
</span><span class="lines">@@ -549,33 +549,62 @@
</span><span class="cx"> return apply_filters( 'bp_get_group_status', $group->status );
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+/**
+ * Output the group avatar while in the groups loop.
+ *
+ * @since BuddyPress (1.0.0)
+ *
+ * @param array $args {@see bp_core_fetch_avatar()}
+ */
</ins><span class="cx"> function bp_group_avatar( $args = '' ) {
</span><span class="cx"> echo bp_get_group_avatar( $args );
</span><span class="cx"> }
</span><ins>+ /**
+ * Return the group avatar while in the groups loop.
+ *
+ * @since BuddyPress (1.0.0)
+ *
+ * @param array $args {@see bp_core_fetch_avatar()}
+ */
</ins><span class="cx"> function bp_get_group_avatar( $args = '' ) {
</span><del>- global $bp, $groups_template;
</del><ins>+ global $groups_template;
</ins><span class="cx">
</span><ins>+ // Bail if avatars are turned off
+ // @todo Should we maybe still filter this?
</ins><span class="cx"> if ( ! buddypress()->avatar->show_avatars ) {
</span><span class="cx"> return false;
</span><span class="cx"> }
</span><span class="cx">
</span><del>- $defaults = array(
</del><ins>+ // Parse the arguments
+ $r = bp_parse_args( $args, array(
</ins><span class="cx"> 'type' => 'full',
</span><span class="cx"> 'width' => false,
</span><span class="cx"> 'height' => false,
</span><span class="cx"> 'class' => 'avatar',
</span><span class="cx"> 'id' => false,
</span><span class="cx"> 'alt' => sprintf( __( 'Group logo of %s', 'buddypress' ), $groups_template->group->name )
</span><del>- );
</del><ins>+ ) );
</ins><span class="cx">
</span><del>- $r = wp_parse_args( $args, $defaults );
- extract( $r, EXTR_SKIP );
</del><ins>+ // Fetch the avatar from the folder
+ $avatar = bp_core_fetch_avatar( array(
+ 'item_id' => $groups_template->group->id,
+ 'title' => $groups_template->group->name,
+ 'avatar_dir' => 'group-avatars',
+ 'object' => 'group',
+ 'type' => $r['type'],
+ 'alt' => $r['alt'],
+ 'css_id' => $r['id'],
+ 'class' => $r['class'],
+ 'width' => $r['width'],
+ 'height' => $r['height']
+ ) );
</ins><span class="cx">
</span><del>- /* Fetch the avatar from the folder, if not provide backwards compat. */
- if ( !$avatar = bp_core_fetch_avatar( array( 'item_id' => $groups_template->group->id, 'object' => 'group', 'type' => $type, 'avatar_dir' => 'group-avatars', 'alt' => $alt, 'css_id' => $id, 'class' => $class, 'width' => $width, 'height' => $height, 'title' => $groups_template->group->name, 'alt' => $alt ) ) )
</del><ins>+ // If No avatar found, provide some backwards compatibility
+ if ( empty( $avatar ) ) {
</ins><span class="cx"> $avatar = '<img src="' . esc_url( $groups_template->group->avatar_thumb ) . '" class="avatar" alt="' . esc_attr( $groups_template->group->name ) . '" />';
</span><ins>+ }
</ins><span class="cx">
</span><del>- return apply_filters( 'bp_get_group_avatar', $avatar );
</del><ins>+ return apply_filters( 'bp_get_group_avatar', $avatar, $r );
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> function bp_group_avatar_thumb( $group = false ) {
</span></span></pre>
</div>
</div>
</body>
</html>