<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][8655] trunk/src/bp-messages/bp-messages-notifications.php: i18n improvements in Message notifications</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://buddypress.trac.wordpress.org/changeset/8655">8655</a></dd>
<dt>Author</dt> <dd>djpaul</dd>
<dt>Date</dt> <dd>2014-07-20 21:41:10 +0000 (Sun, 20 Jul 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>i18n improvements in Message notifications
Add singular form of ?\226?\128?\156you have x new private messages?\226?\128?\157, and use
`bp_core_number_format` to format the number correctly for the locale.
See <a href="http://buddypress.trac.wordpress.org/ticket/5767">#5767</a>, props SGr33n</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcbpmessagesbpmessagesnotificationsphp">trunk/src/bp-messages/bp-messages-notifications.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcbpmessagesbpmessagesnotificationsphp"></a>
<div class="modfile"><h4>Modified: trunk/src/bp-messages/bp-messages-notifications.php (8654 => 8655)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/bp-messages/bp-messages-notifications.php 2014-07-20 21:33:58 UTC (rev 8654)
+++ trunk/src/bp-messages/bp-messages-notifications.php 2014-07-20 21:41:10 UTC (rev 8655)
</span><span class="lines">@@ -122,13 +122,14 @@
</span><span class="cx"> * @return string|array Formatted notifications.
</span><span class="cx"> */
</span><span class="cx"> function messages_format_notifications( $action, $item_id, $secondary_item_id, $total_items, $format = 'string' ) {
</span><ins>+ $total_items = (int) $total_items;
</ins><span class="cx">
</span><span class="cx"> if ( 'new_message' === $action ) {
</span><span class="cx"> $link = trailingslashit( bp_loggedin_user_domain() . bp_get_messages_slug() . '/inbox' );
</span><span class="cx"> $title = __( 'Inbox', 'buddypress' );
</span><span class="cx">
</span><del>- if ( (int) $total_items > 1 ) {
- $text = sprintf( __( 'You have %d new messages', 'buddypress' ), (int) $total_items );
</del><ins>+ if ( $total_items > 1 ) {
+ $text = sprintf( __( 'You have %d new messages', 'buddypress' ), $total_items );
</ins><span class="cx"> $filter = 'bp_messages_multiple_new_message_notification';
</span><span class="cx"> } else {
</span><span class="cx"> // get message thread ID
</span><span class="lines">@@ -141,7 +142,7 @@
</span><span class="cx"> if ( ! empty( $secondary_item_id ) ) {
</span><span class="cx"> $text = sprintf( __( '%s sent you a new private message', 'buddypress' ), bp_core_get_user_displayname( $secondary_item_id ) );
</span><span class="cx"> } else {
</span><del>- $text = sprintf( __( 'You have %d new private messages', 'buddypress' ), (int) $total_items );
</del><ins>+ $text = sprintf( _n( 'You have %s new private message', 'You have %s new private messages', $total_items, 'buddypress' ), bp_core_number_format( $total_items ) );
</ins><span class="cx"> }
</span><span class="cx"> $filter = 'bp_messages_single_new_message_notification';
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>