<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][8639] trunk/src/bp-xprofile/admin: More visual updates to XProfile admin UI, to bring it more inline with other WordPress core sortable/droppable elements.</title>
</head>
<body>

<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt;  }
#msg dl a { font-weight: bold}
#msg dl a:link    { color:#fc3; }
#msg dl a:active  { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff  {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://buddypress.trac.wordpress.org/changeset/8639">8639</a></dd>
<dt>Author</dt> <dd>johnjamesjacoby</dd>
<dt>Date</dt> <dd>2014-07-17 18:04:14 +0000 (Thu, 17 Jul 2014)</dd>
</dl>

<h3>Log Message</h3>
<pre>More visual updates to XProfile admin UI, to bring it more inline with other WordPress core sortable/droppable elements.</pre>

<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcbpxprofileadmincssadminrtlcss">trunk/src/bp-xprofile/admin/css/admin-rtl.css</a></li>
<li><a href="#trunksrcbpxprofileadmincssadmincss">trunk/src/bp-xprofile/admin/css/admin.css</a></li>
<li><a href="#trunksrcbpxprofileadminjsadminjs">trunk/src/bp-xprofile/admin/js/admin.js</a></li>
</ul>

</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcbpxprofileadmincssadminrtlcss"></a>
<div class="modfile"><h4>Modified: trunk/src/bp-xprofile/admin/css/admin-rtl.css (8638 => 8639)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/bp-xprofile/admin/css/admin-rtl.css    2014-07-17 02:31:55 UTC (rev 8638)
+++ trunk/src/bp-xprofile/admin/css/admin-rtl.css       2014-07-17 18:04:14 UTC (rev 8639)
</span><span class="lines">@@ -9,7 +9,7 @@
</span><span class="cx">  position: relative;
</span><span class="cx">  }
</span><span class="cx">  p.nofields {
</span><del>-               margin-top: 20px;
</del><ins>+                margin: 10px 0;
</ins><span class="cx">   }
</span><span class="cx"> 
</span><span class="cx">  /* Field group tabs */
</span><span class="lines">@@ -70,8 +70,8 @@
</span><span class="cx">  .tab-toolbar {
</span><span class="cx">          background: #f5f5f5;
</span><span class="cx">          border-width: 1px 1px 0;
</span><del>-               margin: -20px -21px 20px -21px;
-               clear: right;
</del><ins>+                margin: -20px -21px 10px -21px;
+               clear: left;
</ins><span class="cx">           padding: 10px;
</span><span class="cx">          border: 1px solid #dedede;
</span><span class="cx">  }
</span><span class="lines">@@ -98,7 +98,7 @@
</span><span class="cx">  div.tab-wrapper {
</span><span class="cx">          background-color: #fff;
</span><span class="cx">          clear: left;
</span><del>-               padding: 20px;
</del><ins>+                padding: 20px 20px 10px 20px;
</ins><span class="cx">           border-left: 1px solid #ccc;
</span><span class="cx">          border-right: 1px solid #ccc;
</span><span class="cx">  }
</span><span class="lines">@@ -106,7 +106,6 @@
</span><span class="cx">  .tab-wrapper fieldset {
</span><span class="cx">          position: relative;
</span><span class="cx">          cursor: default !important;
</span><del>-               background: inherit;
</del><span class="cx">           }
</span><span class="cx">          .tab-wrapper fieldset legend {
</span><span class="cx">                  font-weight: bold;
</span><span class="lines">@@ -117,30 +116,22 @@
</span><span class="cx">  .tab-wrapper fieldset fieldset {
</span><span class="cx">          position: relative;
</span><span class="cx">          border: 1px solid #ddd;
</span><del>-               margin: 10px 0 0 0;
</del><ins>+                margin: 10px 0;
</ins><span class="cx">           cursor: move !important;
</span><del>-               background: #f5f5f5;
</del><ins>+                background: #fafafa;
+               padding: 10px 0 0 ;
</ins><span class="cx">   }
</span><span class="cx">  .tab-wrapper fieldset fieldset legend {
</span><del>-               position: absolute !important;
-               top: 0;
-               right: 0;
-               width: 80%;
-               padding: 30px;
-       }
-       .tab-wrapper fieldset fieldset legend span {
</del><span class="cx">           position: absolute;
</span><del>-               top: 6px;
</del><ins>+                top: 10px;
</ins><span class="cx">           right: 10px;
</span><del>-               font-weight: bold;
-               width: 100%;
</del><ins>+                padding: 0;
</ins><span class="cx">   }
</span><span class="cx">          .field-group fieldset:hover {
</span><del>-                       background-color: #fafafa;
-                       border-color: #ccc;
</del><ins>+                        border-color: #999;
</ins><span class="cx">           }
</span><span class="cx">          fieldset div.field-wrapper {
</span><del>-                       padding: 40px 10px 10px;
</del><ins>+                        padding: 25px 10px 10px;
</ins><span class="cx">           }
</span><span class="cx">  fieldset.radio div div label,
</span><span class="cx">  fieldset.checkbox div label {
</span><span class="lines">@@ -153,7 +144,7 @@
</span><span class="cx">  .field-group div.actions {
</span><span class="cx">          float: none;
</span><span class="cx">          border-top: 1px solid #ddd;
</span><del>-               margin: 20px 0 0;
</del><ins>+                margin: 10px 0 0;
</ins><span class="cx">           padding-top: 10px;
</span><span class="cx">  }
</span><span class="cx">  .field-group div.actions a,
</span><span class="lines">@@ -166,7 +157,7 @@
</span><span class="cx">  }
</span><span class="cx">  .field-group fieldset.ui-sortable-placeholder {
</span><span class="cx">          border: 1px dashed #999;
</span><del>-               background-color: #fafafa;
</del><ins>+                background-color: #fff;
</ins><span class="cx">           visibility: visible !important;
</span><span class="cx">  }
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunksrcbpxprofileadmincssadmincss"></a>
<div class="modfile"><h4>Modified: trunk/src/bp-xprofile/admin/css/admin.css (8638 => 8639)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/bp-xprofile/admin/css/admin.css        2014-07-17 02:31:55 UTC (rev 8638)
+++ trunk/src/bp-xprofile/admin/css/admin.css   2014-07-17 18:04:14 UTC (rev 8639)
</span><span class="lines">@@ -9,7 +9,7 @@
</span><span class="cx">  position: relative;
</span><span class="cx">  }
</span><span class="cx">  p.nofields {
</span><del>-               margin-top: 20px;
</del><ins>+                margin: 10px 0;
</ins><span class="cx">   }
</span><span class="cx"> 
</span><span class="cx">  /* Field group tabs */
</span><span class="lines">@@ -98,7 +98,7 @@
</span><span class="cx">  div.tab-wrapper {
</span><span class="cx">          background-color: #fff;
</span><span class="cx">          clear: left;
</span><del>-               padding: 20px;
</del><ins>+                padding: 20px 20px 10px 20px;
</ins><span class="cx">           border-left: 1px solid #ccc;
</span><span class="cx">          border-right: 1px solid #ccc;
</span><span class="cx">  }
</span><span class="lines">@@ -106,7 +106,6 @@
</span><span class="cx">  .tab-wrapper fieldset {
</span><span class="cx">          position: relative;
</span><span class="cx">          cursor: default !important;
</span><del>-               background: inherit;
</del><span class="cx">           }
</span><span class="cx">          .tab-wrapper fieldset legend {
</span><span class="cx">                  font-weight: bold;
</span><span class="lines">@@ -117,30 +116,22 @@
</span><span class="cx">  .tab-wrapper fieldset fieldset {
</span><span class="cx">          position: relative;
</span><span class="cx">          border: 1px solid #ddd;
</span><del>-               margin: 10px 0 0 0;
</del><ins>+                margin: 10px 0;
</ins><span class="cx">           cursor: move !important;
</span><del>-               background: #f5f5f5;
</del><ins>+                background: #fafafa;
+               padding: 10px 0 0 ;
</ins><span class="cx">   }
</span><span class="cx">  .tab-wrapper fieldset fieldset legend {
</span><del>-               position: absolute !important;
-               top: 0;
-               left: 0;
-               width: 80%;
-               padding: 30px;
-       }
-       .tab-wrapper fieldset fieldset legend span {
</del><span class="cx">           position: absolute;
</span><del>-               top: 6px;
</del><ins>+                top: 10px;
</ins><span class="cx">           left: 10px;
</span><del>-               font-weight: bold;
-               width: 100%;
</del><ins>+                padding: 0;
</ins><span class="cx">   }
</span><span class="cx">          .field-group fieldset:hover {
</span><del>-                       background-color: #fafafa;
-                       border-color: #ccc;
</del><ins>+                        border-color: #999;
</ins><span class="cx">           }
</span><span class="cx">          fieldset div.field-wrapper {
</span><del>-                       padding: 40px 10px 10px;
</del><ins>+                        padding: 25px 10px 10px;
</ins><span class="cx">           }
</span><span class="cx">  fieldset.radio div div label,
</span><span class="cx">  fieldset.checkbox div label {
</span><span class="lines">@@ -153,7 +144,7 @@
</span><span class="cx">  .field-group div.actions {
</span><span class="cx">          float: none;
</span><span class="cx">          border-top: 1px solid #ddd;
</span><del>-               margin: 20px 0 0;
</del><ins>+                margin: 10px 0 0;
</ins><span class="cx">           padding-top: 10px;
</span><span class="cx">  }
</span><span class="cx">  .field-group div.actions a,
</span><span class="lines">@@ -166,7 +157,7 @@
</span><span class="cx">  }
</span><span class="cx">  .field-group fieldset.ui-sortable-placeholder {
</span><span class="cx">          border: 1px dashed #999;
</span><del>-               background-color: #fafafa;
</del><ins>+                background-color: #fff;
</ins><span class="cx">           visibility: visible !important;
</span><span class="cx">  }
</span><span class="cx"> 
</span></span></pre></div>
<a id="trunksrcbpxprofileadminjsadminjs"></a>
<div class="modfile"><h4>Modified: trunk/src/bp-xprofile/admin/js/admin.js (8638 => 8639)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/bp-xprofile/admin/js/admin.js  2014-07-17 02:31:55 UTC (rev 8638)
+++ trunk/src/bp-xprofile/admin/js/admin.js     2014-07-17 18:04:14 UTC (rev 8639)
</span><span class="lines">@@ -64,6 +64,8 @@
</span><span class="cx"> 
</span><span class="cx"> /**
</span><span class="cx">  * Hide all "options" sections, and show the options section for the forWhat type.
</span><ins>+ *
+ * @param {string} forWhat Value of the field to show options for
</ins><span class="cx">  */
</span><span class="cx"> function show_options( forWhat ) {
</span><span class="cx">  for ( var i = 0; i < XProfileAdmin.supports_options_field_types.length; i++ ) {
</span><span class="lines">@@ -146,9 +148,9 @@
</span><span class="cx">  jQuery( 'ul#field-group-tabs' ).sortable( {
</span><span class="cx">          cursor: 'move',
</span><span class="cx">          axis: 'x',
</span><del>-               opacity: 0.6,
</del><ins>+                opacity: 1,
</ins><span class="cx">           items: 'li',
</span><del>-               tolerance: 'pointer',
</del><ins>+                tolerance: 'intersect',
</ins><span class="cx"> 
</span><span class="cx">          update: function() {
</span><span class="cx">                  jQuery.post( ajaxurl, {
</span><span class="lines">@@ -164,9 +166,9 @@
</span><span class="cx">  // Allow reordering of fields within groups
</span><span class="cx">  jQuery( 'fieldset.field-group' ).sortable({
</span><span class="cx">          cursor: 'move',
</span><del>-               opacity: 0.3,
</del><ins>+                opacity: 1,
</ins><span class="cx">           items: 'fieldset',
</span><del>-               tolerance: 'pointer',
</del><ins>+                tolerance: 'ponter',
</ins><span class="cx"> 
</span><span class="cx">          update: function() {
</span><span class="cx">                  jQuery.post( ajaxurl, {
</span><span class="lines">@@ -205,8 +207,8 @@
</span><span class="cx"> 
</span><span class="cx">                  // When field is dropped on tab
</span><span class="cx">                  drop: function( ev, ui ) {
</span><del>-                               var $item = jQuery(this),  // The tab
-                                       $list   = jQuery( $item.find( 'a' ).attr( 'href' ) ).find( '.connectedSortable' );  // The tab body
</del><ins>+                                var $item = jQuery(this), // The tab
+                                       $list = jQuery( $item.find( 'a' ).attr( 'href' ) ).find( '.connectedSortable' ); // The tab body
</ins><span class="cx"> 
</span><span class="cx">                          // Remove helper class
</span><span class="cx">                          jQuery($item).removeClass( 'drop-candidate' );
</span></span></pre>
</div>
</div>

</body>
</html>