<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][8548] trunk/tests/phpunit/testcases/groups/template.php: In groups/template tests, cast time() to a variable before using to create data</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://buddypress.trac.wordpress.org/changeset/8548">8548</a></dd>
<dt>Author</dt> <dd>boonebgorges</dd>
<dt>Date</dt> <dd>2014-06-25 13:52:50 +0000 (Wed, 25 Jun 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>In groups/template tests, cast time() to a variable before using to create data
This ensures that relative times don't get screwed up if tests take more than
one second.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunktestsphpunittestcasesgroupstemplatephp">trunk/tests/phpunit/testcases/groups/template.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunktestsphpunittestcasesgroupstemplatephp"></a>
<div class="modfile"><h4>Modified: trunk/tests/phpunit/testcases/groups/template.php (8547 => 8548)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/tests/phpunit/testcases/groups/template.php 2014-06-25 13:36:44 UTC (rev 8547)
+++ trunk/tests/phpunit/testcases/groups/template.php 2014-06-25 13:52:50 UTC (rev 8548)
</span><span class="lines">@@ -43,20 +43,21 @@
</span><span class="cx"> * @group bp_has_groups
</span><span class="cx"> */
</span><span class="cx"> public function test_bp_has_groups_with_order_orderby_with_null_type() {
</span><ins>+ $now = time();
</ins><span class="cx"> $g1 = $this->factory->group->create( array(
</span><span class="cx"> 'name' => 'AAAAA',
</span><del>- 'date_created' => gmdate( 'Y-m-d H:i:s', time() - 100 ),
- 'last_activity' => gmdate( 'Y-m-d H:i:s', time() - 1000000 ),
</del><ins>+ 'date_created' => gmdate( 'Y-m-d H:i:s', $now - 100 ),
+ 'last_activity' => gmdate( 'Y-m-d H:i:s', $now - 1000000 ),
</ins><span class="cx"> ) );
</span><span class="cx"> $g2 = $this->factory->group->create( array(
</span><span class="cx"> 'name' => 'BBBBB',
</span><del>- 'date_created' => gmdate( 'Y-m-d H:i:s', time() - 1000000 ),
- 'last_activity' => gmdate( 'Y-m-d H:i:s', time() - 10000 ),
</del><ins>+ 'date_created' => gmdate( 'Y-m-d H:i:s', $now - 1000000 ),
+ 'last_activity' => gmdate( 'Y-m-d H:i:s', $now - 10000 ),
</ins><span class="cx"> ) );
</span><span class="cx"> $g3 = $this->factory->group->create( array(
</span><span class="cx"> 'name' => 'CCCCC',
</span><del>- 'date_created' => gmdate( 'Y-m-d H:i:s', time() - 10000 ),
- 'last_activity' => gmdate( 'Y-m-d H:i:s', time() - 10 ),
</del><ins>+ 'date_created' => gmdate( 'Y-m-d H:i:s', $now - 10000 ),
+ 'last_activity' => gmdate( 'Y-m-d H:i:s', $now - 10 ),
</ins><span class="cx"> ) );
</span><span class="cx">
</span><span class="cx"> global $groups_template;
</span><span class="lines">@@ -78,17 +79,18 @@
</span><span class="cx"> * @group bp_has_groups
</span><span class="cx"> */
</span><span class="cx"> public function test_bp_has_groups_defaults_to_DESC_last_activity_for_default_type_active_backpat() {
</span><ins>+ $now = time();
</ins><span class="cx"> $g1 = $this->factory->group->create( array(
</span><span class="cx"> 'name' => 'AAAAA',
</span><del>- 'last_activity' => gmdate( 'Y-m-d H:i:s', time() - 100 ),
</del><ins>+ 'last_activity' => gmdate( 'Y-m-d H:i:s', $now - 100 ),
</ins><span class="cx"> ) );
</span><span class="cx"> $g2 = $this->factory->group->create( array(
</span><span class="cx"> 'name' => 'BBBBB',
</span><del>- 'last_activity' => gmdate( 'Y-m-d H:i:s', time() - 1000000 ),
</del><ins>+ 'last_activity' => gmdate( 'Y-m-d H:i:s', $now - 1000000 ),
</ins><span class="cx"> ) );
</span><span class="cx"> $g3 = $this->factory->group->create( array(
</span><span class="cx"> 'name' => 'CCCCC',
</span><del>- 'last_activity' => gmdate( 'Y-m-d H:i:s', time() - 10000 ),
</del><ins>+ 'last_activity' => gmdate( 'Y-m-d H:i:s', $now - 10000 ),
</ins><span class="cx"> ) );
</span><span class="cx">
</span><span class="cx"> global $groups_template;
</span><span class="lines">@@ -374,11 +376,12 @@
</span><span class="cx"> 'creator_id' => $u1,
</span><span class="cx"> ) );
</span><span class="cx">
</span><ins>+ $now = time();
</ins><span class="cx"> $this->add_user_to_group( $u2, $g, array(
</span><del>- 'date_modified' => gmdate( 'Y-m-d H:i:s', time() - 60*60*24 ),
</del><ins>+ 'date_modified' => gmdate( 'Y-m-d H:i:s', $now - 60*60*24 ),
</ins><span class="cx"> ) );
</span><span class="cx"> $this->add_user_to_group( $u3, $g, array(
</span><del>- 'date_modified' => gmdate( 'Y-m-d H:i:s', time() - 60*60*12 ),
</del><ins>+ 'date_modified' => gmdate( 'Y-m-d H:i:s', $now - 60*60*12 ),
</ins><span class="cx"> ) );
</span><span class="cx">
</span><span class="cx"> $m2 = new BP_Groups_Member( $u2, $g );
</span><span class="lines">@@ -402,14 +405,15 @@
</span><span class="cx"> * @group bp_group_has_members
</span><span class="cx"> */
</span><span class="cx"> public function test_bp_group_has_members_default_order() {
</span><ins>+ $now = time();
</ins><span class="cx"> $u1 = $this->create_user( array(
</span><del>- 'last_activity' => gmdate( 'Y-m-d H:i:s', time() - 60 ),
</del><ins>+ 'last_activity' => gmdate( 'Y-m-d H:i:s', $now - 60 ),
</ins><span class="cx"> ) );
</span><span class="cx"> $u2 = $this->create_user( array(
</span><del>- 'last_activity' => gmdate( 'Y-m-d H:i:s', time() - 600 ),
</del><ins>+ 'last_activity' => gmdate( 'Y-m-d H:i:s', $now - 600 ),
</ins><span class="cx"> ) );
</span><span class="cx"> $u3 = $this->create_user( array(
</span><del>- 'last_activity' => gmdate( 'Y-m-d H:i:s', time() - 6000 ),
</del><ins>+ 'last_activity' => gmdate( 'Y-m-d H:i:s', $now - 6000 ),
</ins><span class="cx"> ) );
</span><span class="cx">
</span><span class="cx"> $g = $this->factory->group->create( array(
</span><span class="lines">@@ -417,11 +421,11 @@
</span><span class="cx"> ) );
</span><span class="cx">
</span><span class="cx"> $this->add_user_to_group( $u2, $g, array(
</span><del>- 'date_modified' => gmdate( 'Y-m-d H:i:s', time() - 60*60*24 ),
</del><ins>+ 'date_modified' => gmdate( 'Y-m-d H:i:s', $now - 60*60*24 ),
</ins><span class="cx"> ) );
</span><span class="cx">
</span><span class="cx"> $this->add_user_to_group( $u3, $g, array(
</span><del>- 'date_modified' => gmdate( 'Y-m-d H:i:s', time() - 60*60*12 ),
</del><ins>+ 'date_modified' => gmdate( 'Y-m-d H:i:s', $now - 60*60*12 ),
</ins><span class="cx"> ) );
</span><span class="cx">
</span><span class="cx"> global $members_template;
</span><span class="lines">@@ -440,17 +444,18 @@
</span><span class="cx"> * @group BP_Groups_Invite_Template
</span><span class="cx"> */
</span><span class="cx"> public function test_bp_group_has_invites_template_structure() {
</span><ins>+ $now = time();
</ins><span class="cx"> $u1 = $this->create_user( array(
</span><del>- 'last_activity' => gmdate( 'Y-m-d H:i:s', time() - 60 ),
</del><ins>+ 'last_activity' => gmdate( 'Y-m-d H:i:s', $now - 60 ),
</ins><span class="cx"> ) );
</span><span class="cx"> $u2 = $this->create_user( array(
</span><del>- 'last_activity' => gmdate( 'Y-m-d H:i:s', time() - 600 ),
</del><ins>+ 'last_activity' => gmdate( 'Y-m-d H:i:s', $now - 600 ),
</ins><span class="cx"> ) );
</span><span class="cx"> $u3 = $this->create_user( array(
</span><del>- 'last_activity' => gmdate( 'Y-m-d H:i:s', time() - 6000 ),
</del><ins>+ 'last_activity' => gmdate( 'Y-m-d H:i:s', $now - 6000 ),
</ins><span class="cx"> ) );
</span><span class="cx"> $u4 = $this->create_user( array(
</span><del>- 'last_activity' => gmdate( 'Y-m-d H:i:s', time() - 60000 ),
</del><ins>+ 'last_activity' => gmdate( 'Y-m-d H:i:s', $now - 60000 ),
</ins><span class="cx"> ) );
</span><span class="cx">
</span><span class="cx">
</span><span class="lines">@@ -459,21 +464,21 @@
</span><span class="cx"> ) );
</span><span class="cx">
</span><span class="cx"> $m2 = $this->add_user_to_group( $u2, $g, array(
</span><del>- 'date_modified' => gmdate( 'Y-m-d H:i:s', time() - 60*60*24 ),
</del><ins>+ 'date_modified' => gmdate( 'Y-m-d H:i:s', $now - 60*60*24 ),
</ins><span class="cx"> 'is_confirmed' => 0,
</span><span class="cx"> 'inviter_id' => $u1,
</span><span class="cx"> 'invite_sent' => true,
</span><span class="cx"> ) );
</span><span class="cx">
</span><span class="cx"> $m3 = $this->add_user_to_group( $u3, $g, array(
</span><del>- 'date_modified' => gmdate( 'Y-m-d H:i:s', time() - 60*60*12 ),
</del><ins>+ 'date_modified' => gmdate( 'Y-m-d H:i:s', $now - 60*60*12 ),
</ins><span class="cx"> 'is_confirmed' => 0,
</span><span class="cx"> 'inviter_id' => $u1,
</span><span class="cx"> 'invite_sent' => true,
</span><span class="cx"> ) );
</span><span class="cx">
</span><span class="cx"> $m4 = $this->add_user_to_group( $u4, $g, array(
</span><del>- 'date_modified' => gmdate( 'Y-m-d H:i:s', time() - 60*60*36 ),
</del><ins>+ 'date_modified' => gmdate( 'Y-m-d H:i:s', $now - 60*60*36 ),
</ins><span class="cx"> 'is_confirmed' => 1,
</span><span class="cx"> 'inviter_id' => $u1,
</span><span class="cx"> 'invite_sent' => true,
</span><span class="lines">@@ -529,13 +534,14 @@
</span><span class="cx"> ) );
</span><span class="cx">
</span><span class="cx"> $users = array();
</span><ins>+ $now = time();
</ins><span class="cx"> for ( $i = 1; $i < 15; $i++ ) {
</span><span class="cx"> $users[ $i ] = $this->create_user( array(
</span><del>- 'last_activity' => gmdate( 'Y-m-d H:i:s', time() - $i ),
</del><ins>+ 'last_activity' => gmdate( 'Y-m-d H:i:s', $now - $i ),
</ins><span class="cx"> ) );
</span><span class="cx">
</span><span class="cx"> $this->add_user_to_group( $users[ $i ], $g, array(
</span><del>- 'date_modified' => gmdate( 'Y-m-d H:i:s', time() - $i ),
</del><ins>+ 'date_modified' => gmdate( 'Y-m-d H:i:s', $now - $i ),
</ins><span class="cx"> 'is_confirmed' => 0,
</span><span class="cx"> 'inviter_id' => $u1,
</span><span class="cx"> 'invite_sent' => true,
</span><span class="lines">@@ -562,8 +568,9 @@
</span><span class="cx"> * @group BP_Group_Membership_Requests_Template
</span><span class="cx"> */
</span><span class="cx"> public function test_bp_group_has_membership_requests_results() {
</span><ins>+ $now = time();
</ins><span class="cx"> $u1 = $this->create_user( array(
</span><del>- 'last_activity' => gmdate( 'Y-m-d H:i:s', time() - 60 ),
</del><ins>+ 'last_activity' => gmdate( 'Y-m-d H:i:s', $now - 60 ),
</ins><span class="cx"> ) );
</span><span class="cx">
</span><span class="cx"> $g = $this->factory->group->create( array(
</span><span class="lines">@@ -574,14 +581,14 @@
</span><span class="cx"> $memberships = array();
</span><span class="cx"> for ( $i = 1; $i < 15; $i++ ) {
</span><span class="cx"> $users[ $i ] = $this->create_user( array(
</span><del>- 'last_activity' => gmdate( 'Y-m-d H:i:s', time() - ( 100 - $i ) ),
</del><ins>+ 'last_activity' => gmdate( 'Y-m-d H:i:s', $now - ( 100 - $i ) ),
</ins><span class="cx"> ) );
</span><span class="cx">
</span><span class="cx"> $memberships[ $i ] = $this->add_user_to_group( $users[ $i ], $g, array(
</span><span class="cx"> // this date_modified ensures that order will match
</span><span class="cx"> // id order. necessary due to a quirk in the legacy
</span><span class="cx"> // implementation
</span><del>- 'date_modified' => gmdate( 'Y-m-d H:i:s', time() - ( 100 - $i ) ),
</del><ins>+ 'date_modified' => gmdate( 'Y-m-d H:i:s', $now - ( 100 - $i ) ),
</ins><span class="cx"> 'is_confirmed' => 0,
</span><span class="cx"> 'inviter_id' => 0,
</span><span class="cx"> 'invite_sent' => false,
</span></span></pre>
</div>
</div>
</body>
</html>