<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][8494] trunk/src/bp-xprofile: Generate list of xprofile field types that support options for Field Admin, rather than hardcoding</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://buddypress.trac.wordpress.org/changeset/8494">8494</a></dd>
<dt>Author</dt> <dd>boonebgorges</dd>
<dt>Date</dt> <dd>2014-06-10 12:51:44 +0000 (Tue, 10 Jun 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Generate list of xprofile field types that support options for Field Admin, rather than hardcoding
This change allows custom field types to support options, while using the core
admin panel UI.
Fixes <a href="http://buddypress.trac.wordpress.org/ticket/5691">#5691</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcbpxprofileadminjsadminjs">trunk/src/bp-xprofile/admin/js/admin.js</a></li>
<li><a href="#trunksrcbpxprofilebpxprofilecssjsphp">trunk/src/bp-xprofile/bp-xprofile-cssjs.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcbpxprofileadminjsadminjs"></a>
<div class="modfile"><h4>Modified: trunk/src/bp-xprofile/admin/js/admin.js (8493 => 8494)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/bp-xprofile/admin/js/admin.js 2014-06-09 19:22:34 UTC (rev 8493)
+++ trunk/src/bp-xprofile/admin/js/admin.js 2014-06-10 12:51:44 UTC (rev 8494)
</span><span class="lines">@@ -61,27 +61,17 @@
</span><span class="cx"> document.getElementById(forWhat + '_option_number').value = theId;
</span><span class="cx"> }
</span><span class="cx">
</span><del>-function show_options(forWhat) {
- document.getElementById( 'radio' ).style.display = 'none';
- document.getElementById( 'selectbox' ).style.display = 'none';
- document.getElementById( 'multiselectbox' ).style.display = 'none';
- document.getElementById( 'checkbox' ).style.display = 'none';
-
- if ( forWhat === 'radio' ) {
- document.getElementById( 'radio' ).style.display = '';
</del><ins>+/**
+ * Hide all "options" sections, and show the options section for the forWhat type.
+ */
+function show_options( forWhat ) {
+ for ( var i = 0; i < XProfileAdmin.supports_options_field_types.length; i++ ) {
+ document.getElementById( XProfileAdmin.supports_options_field_types[i] ).style.display = 'none';
</ins><span class="cx"> }
</span><span class="cx">
</span><del>- if ( forWhat === 'selectbox' ) {
- document.getElementById( 'selectbox' ).style.display = '';
</del><ins>+ if ( XProfileAdmin.supports_options_field_types.indexOf( forWhat ) >= 0 ) {
+ document.getElementById( forWhat ).style.display = '';
</ins><span class="cx"> }
</span><del>-
- if ( forWhat === 'multiselectbox' ) {
- document.getElementById( 'multiselectbox' ).style.display = '';
- }
-
- if ( forWhat === 'checkbox' ) {
- document.getElementById( 'checkbox' ).style.display = '';
- }
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> function hide( id ) {
</span></span></pre></div>
<a id="trunksrcbpxprofilebpxprofilecssjsphp"></a>
<div class="modfile"><h4>Modified: trunk/src/bp-xprofile/bp-xprofile-cssjs.php (8493 => 8494)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/bp-xprofile/bp-xprofile-cssjs.php 2014-06-09 19:22:34 UTC (rev 8493)
+++ trunk/src/bp-xprofile/bp-xprofile-cssjs.php 2014-06-10 12:51:44 UTC (rev 8494)
</span><span class="lines">@@ -39,6 +39,23 @@
</span><span class="cx">
</span><span class="cx"> $min = defined( 'SCRIPT_DEBUG' ) && SCRIPT_DEBUG ? '' : '.min';
</span><span class="cx"> wp_enqueue_script( 'xprofile-admin-js', buddypress()->plugin_url . "bp-xprofile/admin/js/admin{$min}.js", array( 'jquery', 'jquery-ui-sortable' ), bp_get_version() );
</span><ins>+
+ // Localize strings.
+ // supports_options_field_types is a dynamic list of field
+ // types that support options, for use in showing/hiding the
+ // "please enter options for this field" section
+ $strings = array(
+ 'supports_options_field_types' => array(),
+ );
+
+ foreach ( bp_xprofile_get_field_types() as $field_type => $field_type_class ) {
+ $field = new $field_type_class();
+ if ( $field->supports_options ) {
+ $strings['supports_options_field_types'][] = $field_type;
+ }
+ }
+
+ wp_localize_script( 'xprofile-admin-js', 'XProfileAdmin', $strings );
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx"> add_action( 'admin_enqueue_scripts', 'xprofile_add_admin_js', 1 );
</span></span></pre>
</div>
</div>
</body>
</html>