<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][8438] trunk/src/bp-members/admin/bp-members-classes.php: Clean-up in `admin/bp-members-classes.php`:</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://buddypress.trac.wordpress.org/changeset/8438">8438</a></dd>
<dt>Author</dt> <dd>johnjamesjacoby</dd>
<dt>Date</dt> <dd>2014-05-21 12:11:51 +0000 (Wed, 21 May 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Clean-up in `admin/bp-members-classes.php`:
* Use sprint() on URL's to remove hard-to-read concatenation
* Audit use of get text functions (a few were incorrectly escaped, others incorrectly nesting other functions)
* Fix inconsistencies between single-site and multi-site list tables
* Code formatting, whitespace, etc...
Fixes <a href="http://buddypress.trac.wordpress.org/ticket/5654">#5654</a>.</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunksrcbpmembersadminbpmembersclassesphp">trunk/src/bp-members/admin/bp-members-classes.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunksrcbpmembersadminbpmembersclassesphp"></a>
<div class="modfile"><h4>Modified: trunk/src/bp-members/admin/bp-members-classes.php (8437 => 8438)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/src/bp-members/admin/bp-members-classes.php 2014-05-21 12:03:11 UTC (rev 8437)
+++ trunk/src/bp-members/admin/bp-members-classes.php 2014-05-21 12:11:51 UTC (rev 8438)
</span><span class="lines">@@ -54,12 +54,10 @@
</span><span class="cx"> public function prepare_items() {
</span><span class="cx"> global $usersearch;
</span><span class="cx">
</span><del>- $usersearch = isset( $_REQUEST['s'] ) ? $_REQUEST['s'] : '';
-
</del><ins>+ $usersearch = isset( $_REQUEST['s'] ) ? $_REQUEST['s'] : '';
</ins><span class="cx"> $signups_per_page = $this->get_items_per_page( str_replace( '-', '_', "{$this->screen->id}_per_page" ) );
</span><ins>+ $paged = $this->get_pagenum();
</ins><span class="cx">
</span><del>- $paged = $this->get_pagenum();
-
</del><span class="cx"> $args = array(
</span><span class="cx"> 'offset' => ( $paged - 1 ) * $signups_per_page,
</span><span class="cx"> 'number' => $signups_per_page,
</span><span class="lines">@@ -99,7 +97,7 @@
</span><span class="cx">
</span><span class="cx"> // Remove the 'current' class from the 'All' link
</span><span class="cx"> $views['all'] = str_replace( 'class="current"', '', $views['all'] );
</span><del>- $views['registered'] = '<a href="' . add_query_arg( 'page', 'bp-signups', bp_get_admin_url( 'users.php' ) ) . '" class="current">' . sprintf( _x( 'Pending <span class="count">(%s)</span>', 'signup users', 'buddypress' ), number_format_i18n( $this->signup_counts ) ) . '</a>';
</del><ins>+ $views['registered'] = sprintf( '<a href="%1$s" class="current">%2$s</a>', add_query_arg( 'page', 'bp-signups', bp_get_admin_url( 'users.php' ) ), sprintf( _x( 'Pending %s', 'signup users', 'buddypress' ), '<span class="count">(' . number_format_i18n( $this->signup_counts ) . ')</span>' ) );
</ins><span class="cx">
</span><span class="cx"> return $views;
</span><span class="cx"> }
</span><span class="lines">@@ -124,12 +122,12 @@
</span><span class="cx"> public function get_columns() {
</span><span class="cx"> return apply_filters( 'bp_members_signup_columns', array(
</span><span class="cx"> 'cb' => '<input type="checkbox" />',
</span><del>- 'username' => __( 'Username', 'buddypress' ),
- 'name' => __( 'Name', 'buddypress' ),
- 'email' => __( 'Email', 'buddypress' ),
- 'registered' => __( 'Registered', 'buddypress' ),
- 'date_sent' => __( 'Last Sent', 'buddypress' ),
- 'count_sent' => __( '# Times Emailed', 'buddypress' )
</del><ins>+ 'username' => __( 'Username', 'buddypress' ),
+ 'name' => __( 'Name', 'buddypress' ),
+ 'email' => __( 'Email', 'buddypress' ),
+ 'registered' => __( 'Registered', 'buddypress' ),
+ 'date_sent' => __( 'Last Sent', 'buddypress' ),
+ 'count_sent' => __( 'Emails Sent', 'buddypress' )
</ins><span class="cx"> ) );
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -141,7 +139,7 @@
</span><span class="cx"> public function get_bulk_actions() {
</span><span class="cx"> $actions = array(
</span><span class="cx"> 'activate' => _x( 'Activate', 'Pending signup action', 'buddypress' ),
</span><del>- 'resend' => _x( 'Email', 'Pending signup action', 'buddypress' ),
</del><ins>+ 'resend' => _x( 'Email', 'Pending signup action', 'buddypress' ),
</ins><span class="cx"> );
</span><span class="cx">
</span><span class="cx"> if ( current_user_can( 'delete_users' ) ) {
</span><span class="lines">@@ -167,14 +165,14 @@
</span><span class="cx">
</span><span class="cx"> // Specific case when BuddyPress is not network activated
</span><span class="cx"> if ( is_multisite() && current_user_can( 'manage_network_users') ) {
</span><del>- $link = '<a href="' . esc_url( network_admin_url( 'settings.php' ) ) . '">' . esc_html__( 'Edit settings', 'buddypress' ) . '</a>';
</del><ins>+ $link = sprintf( '<a href="%1$s">%2$s</a>', esc_url( network_admin_url( 'settings.php' ) ), esc_html__( 'Edit settings', 'buddypress' ) );
</ins><span class="cx"> } elseif ( current_user_can( 'manage_options' ) ) {
</span><del>- $link = '<a href="' . esc_url( bp_get_admin_url( 'options-general.php' ) ) . '">' . esc_html__( 'Edit settings', 'buddypress' ) . '</a>';
</del><ins>+ $link = sprintf( '<a href="%1$s">%2$s</a>', esc_url( bp_get_admin_url( 'options-general.php' ) ), esc_html__( 'Edit settings', 'buddypress' ) );
</ins><span class="cx"> }
</span><del>-
</del><ins>+
</ins><span class="cx"> printf( __( 'Registration is disabled. %s', 'buddypress' ), $link );
</span><span class="cx"> }
</span><del>-
</del><ins>+
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> /**
</span><span class="lines">@@ -222,8 +220,8 @@
</span><span class="cx"> * @since BuddyPress (2.0.0)
</span><span class="cx"> */
</span><span class="cx"> public function column_cb( $signup_object = null ) {
</span><del>- ?>
- <label class="screen-reader-text" for="signup_<?php echo intval( $signup_object->id ); ?>"><?php echo esc_html( sprintf( __( 'Select %s', 'buddypress' ), $signup_object->user_login ) ); ?></label>
</del><ins>+ ?>
+ <label class="screen-reader-text" for="signup_<?php echo intval( $signup_object->id ); ?>"><?php printf( esc_html__( 'Select %s', 'buddypress' ), $signup_object->user_login ); ?></label>
</ins><span class="cx"> <input type="checkbox" id="signup_<?php echo intval( $signup_object->id ) ?>" name="allsignups[]" value="<?php echo esc_attr( $signup_object->id ) ?>" />
</span><span class="cx"> <?php
</span><span class="cx"> }
</span><span class="lines">@@ -268,19 +266,19 @@
</span><span class="cx"> bp_get_admin_url( 'users.php' )
</span><span class="cx"> );
</span><span class="cx">
</span><del>- echo $avatar . '<strong><a href="' . $activate_link .'" class="edit" title="' . esc_attr__( 'Activate', 'buddypress' ) . '">' . $signup_object->user_login .'</a></strong><br/>';
</del><ins>+ echo $avatar . sprintf( '<strong><a href="%1$s" class="edit" title="%2$s">%3$s</a></strong><br/>', esc_url( $activate_link ), esc_attr__( 'Activate', 'buddypress' ), $signup_object->user_login );
</ins><span class="cx">
</span><span class="cx"> $actions = array();
</span><span class="cx">
</span><del>- $actions['activate'] = '<a href="' . esc_url( $activate_link ) . '">' . __( 'Activate', 'buddypress' ) . '</a>';
</del><ins>+ $actions['activate'] = sprintf( '<a href="%1$s">%2$s</a>', esc_url( $activate_link ), __( 'Activate', 'buddypress' ) );
+ $actions['resend'] = sprintf( '<a href="%1$s">%2$s</a>', esc_url( $email_link ), __( 'Email', 'buddypress' ) );
</ins><span class="cx">
</span><del>- $actions['resend'] = '<a href="' . esc_url( $email_link ) . '">' . __( 'Email', 'buddypress' ) . '</a>';
-
</del><span class="cx"> if ( current_user_can( 'delete_users' ) ) {
</span><del>- $actions['delete'] = '<a href="' . esc_url( $delete_link ) . '" class="delete">' . __( 'Delete', 'buddypress' ) . '</a>';
</del><ins>+ $actions['delete'] = sprintf( '<a href="%1$s" class="delete">%2$s</a>', esc_url( $delete_link ), __( 'Delete', 'buddypress' ) );
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> $actions = apply_filters( 'bp_members_ms_signup_row_actions', $actions, $signup_object );
</span><ins>+
</ins><span class="cx"> echo $this->row_actions( $actions );
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -303,7 +301,7 @@
</span><span class="cx"> * @param object $signup_object The signup data object.
</span><span class="cx"> */
</span><span class="cx"> public function column_email( $signup_object = null ) {
</span><del>- echo '<a href="mailto:' . esc_attr( $signup_object->user_email ) . '">' . esc_html( $signup_object->user_email ) .'</a>';
</del><ins>+ printf( '<a href="mailto:%1$s">%2$s</a>', esc_attr( $signup_object->user_email ), esc_html( $signup_object->user_email ) );
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> /**
</span><span class="lines">@@ -381,14 +379,12 @@
</span><span class="cx"> * @since BuddyPress (2.0.0)
</span><span class="cx"> */
</span><span class="cx"> public function prepare_items() {
</span><del>- global $usersearch, $wpdb, $mode;
</del><ins>+ global $usersearch, $mode;
</ins><span class="cx">
</span><del>- $usersearch = isset( $_REQUEST['s'] ) ? $_REQUEST['s'] : '';
-
</del><ins>+ $usersearch = isset( $_REQUEST['s'] ) ? $_REQUEST['s'] : '';
</ins><span class="cx"> $signups_per_page = $this->get_items_per_page( str_replace( '-', '_', "{$this->screen->id}_per_page" ) );
</span><ins>+ $paged = $this->get_pagenum();
</ins><span class="cx">
</span><del>- $paged = $this->get_pagenum();
-
</del><span class="cx"> $args = array(
</span><span class="cx"> 'offset' => ( $paged - 1 ) * $signups_per_page,
</span><span class="cx"> 'number' => $signups_per_page,
</span><span class="lines">@@ -397,17 +393,18 @@
</span><span class="cx"> 'order' => 'DESC'
</span><span class="cx"> );
</span><span class="cx">
</span><del>- if ( isset( $_REQUEST['orderby'] ) )
</del><ins>+ if ( isset( $_REQUEST['orderby'] ) ) {
</ins><span class="cx"> $args['orderby'] = $_REQUEST['orderby'];
</span><ins>+ }
</ins><span class="cx">
</span><del>- if ( isset( $_REQUEST['order'] ) )
</del><ins>+ if ( isset( $_REQUEST['order'] ) ) {
</ins><span class="cx"> $args['order'] = $_REQUEST['order'];
</span><ins>+ }
</ins><span class="cx">
</span><del>- $mode = empty( $_REQUEST['mode'] ) ? 'list' : $_REQUEST['mode'];
-
</del><ins>+ $mode = empty( $_REQUEST['mode'] ) ? 'list' : $_REQUEST['mode'];
</ins><span class="cx"> $signups = BP_Signup::get( $args );
</span><span class="cx">
</span><del>- $this->items = $signups['signups'];
</del><ins>+ $this->items = $signups['signups'];
</ins><span class="cx"> $this->signup_counts = $signups['total'];
</span><span class="cx">
</span><span class="cx"> $this->set_pagination_args( array(
</span><span class="lines">@@ -423,14 +420,13 @@
</span><span class="cx"> *
</span><span class="cx"> * @uses WP_MS_Users_List_Table::get_views() to get the users views
</span><span class="cx"> */
</span><del>- function get_views() {
</del><ins>+ public function get_views() {
</ins><span class="cx"> $views = parent::get_views();
</span><span class="cx">
</span><del>- $views['all'] = str_replace( 'class="current"', '', $views['all'] );
- $class = ' class="current"';
</del><ins>+ // Remove the 'current' class from the 'All' link
+ $views['all'] = str_replace( 'class="current"', '', $views['all'] );
+ $views['registered'] = sprintf( '<a href="%1$s" class="current">%2$s</a>', add_query_arg( 'page', 'bp-signups', bp_get_admin_url( 'users.php' ) ), sprintf( _x( 'Pending %s', 'signup users', 'buddypress' ), '<span class="count">(' . number_format_i18n( $this->signup_counts ) . ')</span>' ) );
</ins><span class="cx">
</span><del>- $views['registered'] = '<a href="' . add_query_arg( 'page', 'bp-signups', bp_get_admin_url( 'users.php' ) ) . '" class="current">' . sprintf( _x( 'Pending <span class="count">(%s)</span>', 'signup users', 'buddypress' ), number_format_i18n( $this->signup_counts ) ) . '</a>';
-
</del><span class="cx"> return $views;
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -442,12 +438,12 @@
</span><span class="cx"> public function get_columns() {
</span><span class="cx"> return apply_filters( 'bp_members_ms_signup_columns', array(
</span><span class="cx"> 'cb' => '<input type="checkbox" />',
</span><del>- 'username' => __( 'Username', 'buddypress' ),
- 'name' => __( 'Name', 'buddypress' ),
- 'email' => __( 'Email', 'buddypress' ),
- 'registered' => __( 'Registered', 'buddypress' ),
- 'date_sent' => __( 'Last Sent', 'buddypress' ),
- 'count_sent' => __( '# Times Emailed', 'buddypress' )
</del><ins>+ 'username' => __( 'Username', 'buddypress' ),
+ 'name' => __( 'Name', 'buddypress' ),
+ 'email' => __( 'Email', 'buddypress' ),
+ 'registered' => __( 'Registered', 'buddypress' ),
+ 'date_sent' => __( 'Last Sent', 'buddypress' ),
+ 'count_sent' => __( 'Emails Sent', 'buddypress' )
</ins><span class="cx"> ) );
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -459,7 +455,7 @@
</span><span class="cx"> public function get_bulk_actions() {
</span><span class="cx"> $actions = array(
</span><span class="cx"> 'activate' => _x( 'Activate', 'Pending signup action', 'buddypress' ),
</span><del>- 'resend' => _x( 'Email', 'Pending signup action', 'buddypress' ),
</del><ins>+ 'resend' => _x( 'Email', 'Pending signup action', 'buddypress' ),
</ins><span class="cx"> );
</span><span class="cx">
</span><span class="cx"> if ( current_user_can( 'delete_users' ) ) {
</span><span class="lines">@@ -483,7 +479,7 @@
</span><span class="cx"> $link = false;
</span><span class="cx">
</span><span class="cx"> if ( current_user_can( 'manage_network_users' ) ) {
</span><del>- $link = '<a href="' . esc_url( network_admin_url( 'settings.php' ) ) . '">' . esc_html__( 'Edit settings', 'buddypress' ) . '</a>';
</del><ins>+ $link = sprintf( '<a href="%1$s">%2$s</a>', esc_url( network_admin_url( 'settings.php' ) ), esc_html__( 'Edit settings', 'buddypress' ) );
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> printf( __( 'Registration is disabled. %s', 'buddypress' ), $link );
</span><span class="lines">@@ -535,8 +531,8 @@
</span><span class="cx"> * @since BuddyPress (2.0.0)
</span><span class="cx"> */
</span><span class="cx"> public function column_cb( $signup_object = null ) {
</span><del>- ?>
- <label class="screen-reader-text" for="signup_<?php echo intval( $signup_object->id ); ?>"><?php echo esc_html( sprintf( __( 'Select %s', 'buddypress' ), $signup_object->user_login ) ); ?></label>
</del><ins>+ ?>
+ <label class="screen-reader-text" for="signup_<?php echo intval( $signup_object->id ); ?>"><?php printf( esc_html__( 'Select %s', 'buddypress' ), $signup_object->user_login ); ?></label>
</ins><span class="cx"> <input type="checkbox" id="signup_<?php echo intval( $signup_object->id ) ?>" name="allsignups[]" value="<?php echo esc_attr( $signup_object->id ) ?>" />
</span><span class="cx"> <?php
</span><span class="cx"> }
</span><span class="lines">@@ -581,17 +577,19 @@
</span><span class="cx"> bp_get_admin_url( 'users.php' )
</span><span class="cx"> );
</span><span class="cx">
</span><del>- echo $avatar . '<strong><a href="' . esc_url( $activate_link ) .'" class="edit" title="' . esc_attr__( 'Activate', 'buddypress' ) . '">' . $signup_object->user_login .'</a></strong><br/>';
</del><ins>+ echo $avatar . sprintf( '<strong><a href="%1$s" class="edit" title="%2$s">%3$s</a></strong><br/>', esc_url( $activate_link ), esc_attr__( 'Activate', 'buddypress' ), $signup_object->user_login );
</ins><span class="cx">
</span><del>- $actions['activate'] = '<a href="' . esc_url( $activate_link ) . '">' . __( 'Activate', 'buddypress' ) . '</a>';
</del><ins>+ $actions = array();
</ins><span class="cx">
</span><del>- $actions['resend'] = '<a href="' . esc_url( $email_link ) . '">' . __( 'Email', 'buddypress' ) . '</a>';
</del><ins>+ $actions['activate'] = sprintf( '<a href="%1$s">%2$s</a>', esc_url( $activate_link ), __( 'Activate', 'buddypress' ) );
+ $actions['resend'] = sprintf( '<a href="%1$s">%2$s</a>', esc_url( $email_link ), __( 'Email', 'buddypress' ) );
</ins><span class="cx">
</span><span class="cx"> if ( current_user_can( 'delete_users' ) ) {
</span><del>- $actions['delete'] = '<a href="' . esc_url( $delete_link ) . '" class="delete">' . __( 'Delete', 'buddypress' ) . '</a>';
</del><ins>+ $actions['delete'] = sprintf( '<a href="%1$s" class="delete">%2$s</a>', esc_url( $delete_link ), __( 'Delete', 'buddypress' ) );
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> $actions = apply_filters( 'bp_members_ms_signup_row_actions', $actions, $signup_object );
</span><ins>+
</ins><span class="cx"> echo $this->row_actions( $actions );
</span><span class="cx"> }
</span><span class="cx">
</span><span class="lines">@@ -614,7 +612,7 @@
</span><span class="cx"> * @param object $signup_object The signup data object.
</span><span class="cx"> */
</span><span class="cx"> public function column_email( $signup_object = null ) {
</span><del>- echo '<a href="mailto:' . esc_attr( $signup_object->user_email ) . '">' . esc_html( $signup_object->user_email ) .'</a>';
</del><ins>+ printf( '<a href="mailto:%1$s">%2$s</a>', esc_attr( $signup_object->user_email ), esc_html( $signup_object->user_email ) );
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> /**
</span><span class="lines">@@ -627,7 +625,7 @@
</span><span class="cx"> public function column_registered( $signup_object = null ) {
</span><span class="cx"> global $mode;
</span><span class="cx">
</span><del>- if ( 'list' == $mode ) {
</del><ins>+ if ( 'list' === $mode ) {
</ins><span class="cx"> $date = 'Y/m/d';
</span><span class="cx"> } else {
</span><span class="cx"> $date = 'Y/m/d \<\b\r \/\> g:i:s a';
</span><span class="lines">@@ -644,7 +642,7 @@
</span><span class="cx"> public function column_date_sent( $signup_object = null ) {
</span><span class="cx"> global $mode;
</span><span class="cx">
</span><del>- if ( 'list' == $mode ) {
</del><ins>+ if ( 'list' === $mode ) {
</ins><span class="cx"> $date = 'Y/m/d';
</span><span class="cx"> } else {
</span><span class="cx"> $date = 'Y/m/d \<\b\r \/\> g:i:s a';
</span></span></pre>
</div>
</div>
</body>
</html>