<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][8380] trunk/Gruntfile.js: Grunt: exclude BP-Default and BP-Legacy from jshint</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://buddypress.trac.wordpress.org/changeset/8380">8380</a></dd>
<dt>Author</dt> <dd>djpaul</dd>
<dt>Date</dt> <dd>2014-05-04 18:16:12 +0000 (Sun, 04 May 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Grunt: exclude BP-Default and BP-Legacy from jshint
These JS files contains a lot of legacy JS, requiring a lot of effort
to bring up to standards. It?\226?\128?\153s better to do that incrementally as part
of template improvements, rather than just to make jshint happy. For
now, let?\226?\128?\153s exclude these from further jshint checks.
Fixes <a href="http://buddypress.trac.wordpress.org/ticket/5613">#5613</a>, see also <a href="http://buddypress.trac.wordpress.org/ticket/5160">#5160</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkGruntfilejs">trunk/Gruntfile.js</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkGruntfilejs"></a>
<div class="modfile"><h4>Modified: trunk/Gruntfile.js (8379 => 8380)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/Gruntfile.js 2014-05-04 17:46:41 UTC (rev 8379)
+++ trunk/Gruntfile.js 2014-05-04 18:16:12 UTC (rev 8380)
</span><span class="lines">@@ -27,6 +27,11 @@
</span><span class="cx"> 'bp-messages/js/*.js',
</span><span class="cx"> 'bp-templates/bp-legacy/js/*.js',
</span><span class="cx"> 'bp-xprofile/admin/js/*.js'
</span><ins>+ ],
+
+ BP_EXCLUDED_JS = [
+ '!bp-templates/bp-legacy/js/*.js',
+ '!bp-themes/bp-default/_inc/*.js'
</ins><span class="cx"> ];
</span><span class="cx">
</span><span class="cx"> require( 'matchdep' ).filterDev( 'grunt-*' ).forEach( grunt.loadNpmTasks );
</span><span class="lines">@@ -41,8 +46,10 @@
</span><span class="cx"> core: {
</span><span class="cx"> expand: true,
</span><span class="cx"> cwd: SOURCE_DIR,
</span><del>- src: BP_JS,
</del><span class="cx">
</span><ins>+ // Exclude known bad JS from jshint for now; see #5613.
+ src: BP_JS.concat( BP_EXCLUDED_JS ),
+
</ins><span class="cx"> /**
</span><span class="cx"> * Limit JSHint's run to a single specified file: grunt jshint:core --file=filename.js
</span><span class="cx"> *
</span></span></pre>
</div>
</div>
</body>
</html>