<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][8289] branches/2.0: Reintroduce DISTINCT keyword to BP_Core_User::get_users()</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://buddypress.trac.wordpress.org/changeset/8289">8289</a></dd>
<dt>Author</dt> <dd>boonebgorges</dd>
<dt>Date</dt> <dd>2014-04-17 19:08:19 +0000 (Thu, 17 Apr 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Reintroduce DISTINCT keyword to BP_Core_User::get_users()
The lack of DISTINCT was causing duplicate entries when joining against the
xprofile fields for the purposes of alphabetical sorts.
Reverts part of <a href="http://buddypress.trac.wordpress.org/changeset/7700">r7700</a>. See <a href="http://buddypress.trac.wordpress.org/ticket/5303">#5303</a>
Fixes <a href="http://buddypress.trac.wordpress.org/ticket/5550">#5550</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#branches20bpcorebpcoreclassesphp">branches/2.0/bp-core/bp-core-classes.php</a></li>
<li><a href="#branches20teststestcasescoreclassbpcoreuserphp">branches/2.0/tests/testcases/core/class-bp-core-user.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="branches20bpcorebpcoreclassesphp"></a>
<div class="modfile"><h4>Modified: branches/2.0/bp-core/bp-core-classes.php (8288 => 8289)</h4>
<pre class="diff"><span>
<span class="info">--- branches/2.0/bp-core/bp-core-classes.php 2014-04-16 17:30:56 UTC (rev 8288)
+++ branches/2.0/bp-core/bp-core-classes.php 2014-04-17 19:08:19 UTC (rev 8289)
</span><span class="lines">@@ -883,7 +883,7 @@
</span><span class="cx">
</span><span class="cx"> $sql = array();
</span><span class="cx">
</span><del>- $sql['select_main'] = "SELECT u.ID as id, u.user_registered, u.user_nicename, u.user_login, u.display_name, u.user_email";
</del><ins>+ $sql['select_main'] = "SELECT DISTINCT u.ID as id, u.user_registered, u.user_nicename, u.user_login, u.display_name, u.user_email";
</ins><span class="cx">
</span><span class="cx"> if ( 'active' == $type || 'online' == $type || 'newest' == $type ) {
</span><span class="cx"> $sql['select_active'] = ", um.meta_value as last_activity";
</span></span></pre></div>
<a id="branches20teststestcasescoreclassbpcoreuserphp"></a>
<div class="modfile"><h4>Modified: branches/2.0/tests/testcases/core/class-bp-core-user.php (8288 => 8289)</h4>
<pre class="diff"><span>
<span class="info">--- branches/2.0/tests/testcases/core/class-bp-core-user.php 2014-04-16 17:30:56 UTC (rev 8288)
+++ branches/2.0/tests/testcases/core/class-bp-core-user.php 2014-04-17 19:08:19 UTC (rev 8289)
</span><span class="lines">@@ -103,6 +103,27 @@
</span><span class="cx"> $this->assertEquals( array( $u1, $u3 ), $user_ids );
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+ /**
+ * @expectedDeprecated BP_Core_User::get_users
+ * @group get_users
+ * @group type
+ */
+ public function test_type_alphabetical() {
+ $u1 = $this->create_user( array(
+ 'display_name' => 'foo',
+ ) );
+ $u2 = $this->create_user( array(
+ 'display_name' => 'bar',
+ ) );
+
+ global $wpdb;
+
+ $q = BP_Core_User::get_users( 'alphabetical' );
+ $found = array_map( 'intval', wp_list_pluck( $q['users'], 'id' ) );
+
+ $this->assertEquals( array( $u2, $u1 ), $found );
+ }
+
</ins><span class="cx"> public function test_get_specific_users() {
</span><span class="cx"> $u1 = $this->create_user();
</span><span class="cx"> $u2 = $this->create_user();
</span></span></pre>
</div>
</div>
</body>
</html>