<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][8224] trunk: When prefetching group data for an activity loop, avoid the query when there's nothing to fetch</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://buddypress.trac.wordpress.org/changeset/8224">8224</a></dd>
<dt>Author</dt> <dd>boonebgorges</dd>
<dt>Date</dt> <dd>2014-03-31 21:27:11 +0000 (Mon, 31 Mar 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>When prefetching group data for an activity loop, avoid the query when there's nothing to fetch
When there are no uncached_ids, don't attempt to query. There's nothing to get,
and it will result in an invalidly formatted SQL query.
Fixes <a href="http://buddypress.trac.wordpress.org/ticket/5503">#5503</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkbpgroupsbpgroupsactivityphp">trunk/bp-groups/bp-groups-activity.php</a></li>
<li><a href="#trunkteststestcasesgroupscachephp">trunk/tests/testcases/groups/cache.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkbpgroupsbpgroupsactivityphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-groups/bp-groups-activity.php (8223 => 8224)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-groups/bp-groups-activity.php 2014-03-31 20:15:00 UTC (rev 8223)
+++ trunk/bp-groups/bp-groups-activity.php 2014-03-31 21:27:11 UTC (rev 8224)
</span><span class="lines">@@ -143,11 +143,13 @@
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><del>- global $wpdb, $bp;
- $uncached_ids_sql = implode( ',', wp_parse_id_list( $uncached_ids ) );
- $groups = $wpdb->get_results( "SELECT * FROM {$bp->groups->table_name} WHERE id IN ({$uncached_ids_sql})" );
- foreach ( $groups as $group ) {
- wp_cache_set( $group->id, $group, 'bp_groups' );
</del><ins>+ if ( ! empty( $uncached_ids ) ) {
+ global $wpdb, $bp;
+ $uncached_ids_sql = implode( ',', wp_parse_id_list( $uncached_ids ) );
+ $groups = $wpdb->get_results( "SELECT * FROM {$bp->groups->table_name} WHERE id IN ({$uncached_ids_sql})" );
+ foreach ( $groups as $group ) {
+ wp_cache_set( $group->id, $group, 'bp_groups' );
+ }
</ins><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkteststestcasesgroupscachephp"></a>
<div class="modfile"><h4>Modified: trunk/tests/testcases/groups/cache.php (8223 => 8224)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/tests/testcases/groups/cache.php 2014-03-31 20:15:00 UTC (rev 8223)
+++ trunk/tests/testcases/groups/cache.php 2014-03-31 21:27:11 UTC (rev 8224)
</span><span class="lines">@@ -101,4 +101,57 @@
</span><span class="cx"> $this->assertFalse( wp_cache_get( $g, 'bp_groups' ) );
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+ /**
+ * @group bp_groups_prefetch_activity_object_data
+ */
+ public function test_bp_groups_prefetch_activity_object_data_all_cached() {
+ $g = $this->factory->group->create();
+
+ // Prime cache
+ groups_get_group( array( 'group_id' => $g ) );
+
+ // fake an activity
+ $a = new stdClass;
+ $a->component = buddypress()->groups->id;
+ $a->item_id = $g;
+ $activities = array(
+ $a,
+ );
+
+ bp_groups_prefetch_activity_object_data( $activities );
+
+ // This assertion is not really necessary - just checks to see
+ // whether a fatal error has occurred above
+ $this->assertNotEmpty( wp_cache_get( $g, 'bp_groups' ) );
+ }
+
+ /**
+ * @group bp_groups_prefetch_activity_object_data
+ */
+ public function test_bp_groups_prefetch_activity_object_data_some_cached() {
+ $g1 = $this->factory->group->create();
+ $g2 = $this->factory->group->create();
+
+ // Prime cache
+ groups_get_group( array( 'group_id' => $g1 ) );
+
+ // fake activities
+ $a1 = new stdClass;
+ $a1->component = buddypress()->groups->id;
+ $a1->item_id = $g1;
+
+ $a2 = new stdClass;
+ $a2->component = buddypress()->groups->id;
+ $a2->item_id = $g2;
+
+ $activities = array(
+ $a1,
+ $a2,
+ );
+
+ bp_groups_prefetch_activity_object_data( $activities );
+
+ $this->assertNotEmpty( wp_cache_get( $g1, 'bp_groups' ) );
+ $this->assertNotEmpty( wp_cache_get( $g2, 'bp_groups' ) );
+ }
</ins><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>