<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][8196] trunk: Remove the bp_get_signup_allowed() checks in Sign-ups management feature</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://buddypress.trac.wordpress.org/changeset/8196">8196</a></dd>
<dt>Author</dt> <dd>imath</dd>
<dt>Date</dt> <dd>2014-03-29 00:04:49 +0000 (Sat, 29 Mar 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Remove the bp_get_signup_allowed() checks in Sign-ups management feature
- Create $wpdb->signups table even if sign-ups are not allowed on single blog config
- Display the UI to manage sign-ups even if signups are not allowed
This way, administrator who temporarly deactivated registrations will still be able to moderate the pending signups.
props johnjamesjacoby, boonebgorges
See <a href="http://buddypress.trac.wordpress.org/ticket/5374">#5374</a></pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkbpcoreadminbpcoreschemaphp">trunk/bp-core/admin/bp-core-schema.php</a></li>
<li><a href="#trunkbpcorebpcoreupdatephp">trunk/bp-core/bp-core-update.php</a></li>
<li><a href="#trunkbpmembersbpmembersadminphp">trunk/bp-members/bp-members-admin.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkbpcoreadminbpcoreschemaphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-core/admin/bp-core-schema.php (8195 => 8196)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-core/admin/bp-core-schema.php 2014-03-28 23:47:39 UTC (rev 8195)
+++ trunk/bp-core/admin/bp-core-schema.php 2014-03-29 00:04:49 UTC (rev 8196)
</span><span class="lines">@@ -52,8 +52,7 @@
</span><span class="cx"> bp_core_install_blog_tracking();
</span><span class="cx">
</span><span class="cx"> // Install the signups table
</span><del>- if ( bp_get_signup_allowed() )
- bp_core_install_signups();
</del><ins>+ bp_core_install_signups();
</ins><span class="cx">
</span><span class="cx"> }
</span><span class="cx">
</span></span></pre></div>
<a id="trunkbpcorebpcoreupdatephp"></a>
<div class="modfile"><h4>Modified: trunk/bp-core/bp-core-update.php (8195 => 8196)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-core/bp-core-update.php 2014-03-28 23:47:39 UTC (rev 8195)
+++ trunk/bp-core/bp-core-update.php 2014-03-29 00:04:49 UTC (rev 8196)
</span><span class="lines">@@ -352,7 +352,7 @@
</span><span class="cx">
</span><span class="cx"> /** Migrate signups data **************************************************/
</span><span class="cx">
</span><del>- if ( bp_get_signup_allowed() && ! is_multisite() ) {
</del><ins>+ if ( ! is_multisite() ) {
</ins><span class="cx">
</span><span class="cx"> if ( empty( $wpdb->signups ) ) {
</span><span class="cx"> bp_core_install_signups();
</span></span></pre></div>
<a id="trunkbpmembersbpmembersadminphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-members/bp-members-admin.php (8195 => 8196)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-members/bp-members-admin.php 2014-03-28 23:47:39 UTC (rev 8195)
+++ trunk/bp-members/bp-members-admin.php 2014-03-29 00:04:49 UTC (rev 8196)
</span><span class="lines">@@ -162,7 +162,7 @@
</span><span class="cx">
</span><span class="cx"> /** Signups **************************************************************/
</span><span class="cx">
</span><del>- if ( bp_get_signup_allowed() && is_admin() ) {
</del><ins>+ if ( is_admin() ) {
</ins><span class="cx"> if ( ! is_multisite() ) {
</span><span class="cx"> add_action( 'pre_user_query', array( $this, 'remove_signups_from_user_query'), 10, 1 );
</span><span class="cx"> }
</span><span class="lines">@@ -194,16 +194,14 @@
</span><span class="cx"> array( &$this, 'user_admin' )
</span><span class="cx"> );
</span><span class="cx">
</span><del>- // Manage signups if allowed
- if ( bp_get_signup_allowed() ) {
- $hooks['signups'] = $this->signups_page = add_users_page(
- __( 'Manage Signups', 'buddypress' ),
- __( 'Manage Signups', 'buddypress' ),
- $this->capability,
- 'bp-signups',
- array( &$this, 'signups_admin' )
- );
- }
</del><ins>+ // Manage signups
+ $hooks['signups'] = $this->signups_page = add_users_page(
+ __( 'Manage Signups', 'buddypress' ),
+ __( 'Manage Signups', 'buddypress' ),
+ $this->capability,
+ 'bp-signups',
+ array( &$this, 'signups_admin' )
+ );
</ins><span class="cx">
</span><span class="cx"> $edit_page = 'user-edit';
</span><span class="cx"> $this->users_page = 'users';
</span></span></pre>
</div>
</div>
</body>
</html>