<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
"http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="content-type" content="text/html; charset=utf-8" />
<title>[BuddyPress][8136] trunk/bp-members: Display a Manage Signups submenu to Users menu in wp-admin</title>
</head>
<body>
<style type="text/css"><!--
#msg dl.meta { border: 1px #006 solid; background: #369; padding: 6px; color: #fff; }
#msg dl.meta dt { float: left; width: 6em; font-weight: bold; }
#msg dt:after { content:':';}
#msg dl, #msg dt, #msg ul, #msg li, #header, #footer, #logmsg { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; }
#msg dl a { font-weight: bold}
#msg dl a:link { color:#fc3; }
#msg dl a:active { color:#ff0; }
#msg dl a:visited { color:#cc6; }
h3 { font-family: verdana,arial,helvetica,sans-serif; font-size: 10pt; font-weight: bold; }
#msg pre { overflow: auto; background: #ffc; border: 1px #fa0 solid; padding: 6px; }
#logmsg { background: #ffc; border: 1px #fa0 solid; padding: 1em 1em 0 1em; }
#logmsg p, #logmsg pre, #logmsg blockquote { margin: 0 0 1em 0; }
#logmsg p, #logmsg li, #logmsg dt, #logmsg dd { line-height: 14pt; }
#logmsg h1, #logmsg h2, #logmsg h3, #logmsg h4, #logmsg h5, #logmsg h6 { margin: .5em 0; }
#logmsg h1:first-child, #logmsg h2:first-child, #logmsg h3:first-child, #logmsg h4:first-child, #logmsg h5:first-child, #logmsg h6:first-child { margin-top: 0; }
#logmsg ul, #logmsg ol { padding: 0; list-style-position: inside; margin: 0 0 0 1em; }
#logmsg ul { text-indent: -1em; padding-left: 1em; }#logmsg ol { text-indent: -1.5em; padding-left: 1.5em; }
#logmsg > ul, #logmsg > ol { margin: 0 0 1em 0; }
#logmsg pre { background: #eee; padding: 1em; }
#logmsg blockquote { border: 1px solid #fa0; border-left-width: 10px; padding: 1em 1em 0 1em; background: white;}
#logmsg dl { margin: 0; }
#logmsg dt { font-weight: bold; }
#logmsg dd { margin: 0; padding: 0 0 0.5em 0; }
#logmsg dd:before { content:'\00bb';}
#logmsg table { border-spacing: 0px; border-collapse: collapse; border-top: 4px solid #fa0; border-bottom: 1px solid #fa0; background: #fff; }
#logmsg table th { text-align: left; font-weight: normal; padding: 0.2em 0.5em; border-top: 1px dotted #fa0; }
#logmsg table td { text-align: right; border-top: 1px dotted #fa0; padding: 0.2em 0.5em; }
#logmsg table thead th { text-align: center; border-bottom: 1px solid #fa0; }
#logmsg table th.Corner { text-align: left; }
#logmsg hr { border: none 0; border-top: 2px dashed #fa0; height: 1px; }
#header, #footer { color: #fff; background: #636; border: 1px #300 solid; padding: 6px; }
#patch { width: 100%; }
#patch h4 {font-family: verdana,arial,helvetica,sans-serif;font-size:10pt;padding:8px;background:#369;color:#fff;margin:0;}
#patch .propset h4, #patch .binary h4 {margin:0;}
#patch pre {padding:0;line-height:1.2em;margin:0;}
#patch .diff {width:100%;background:#eee;padding: 0 0 10px 0;overflow:auto;}
#patch .propset .diff, #patch .binary .diff {padding:10px 0;}
#patch span {display:block;padding:0 10px;}
#patch .modfile, #patch .addfile, #patch .delfile, #patch .propset, #patch .binary, #patch .copfile {border:1px solid #ccc;margin:10px 0;}
#patch ins {background:#dfd;text-decoration:none;display:block;padding:0 10px;}
#patch del {background:#fdd;text-decoration:none;display:block;padding:0 10px;}
#patch .lines, .info {color:#888;background:#fff;}
--></style>
<div id="msg">
<dl class="meta">
<dt>Revision</dt> <dd><a href="http://buddypress.trac.wordpress.org/changeset/8136">8136</a></dd>
<dt>Author</dt> <dd>imath</dd>
<dt>Date</dt> <dd>2014-03-15 10:54:27 +0000 (Sat, 15 Mar 2014)</dd>
</dl>
<h3>Log Message</h3>
<pre>Display a Manage Signups submenu to Users menu in wp-admin
Signups management is simulating a new view in the wp-admin users page. A Pending link is available after the different WordPress views to filter the users by roles. It appears the Signups screen can be a bit difficult to find for site or network administrators. As a result, it is best to display the Manage Signups submenu instead of removing it.
See <a href="http://buddypress.trac.wordpress.org/ticket/5374">#5374</a>
props johnjamesjacoby, boonebgorges</pre>
<h3>Modified Paths</h3>
<ul>
<li><a href="#trunkbpmembersadminbpmembersclassesphp">trunk/bp-members/admin/bp-members-classes.php</a></li>
<li><a href="#trunkbpmembersbpmembersadminphp">trunk/bp-members/bp-members-admin.php</a></li>
</ul>
</div>
<div id="patch">
<h3>Diff</h3>
<a id="trunkbpmembersadminbpmembersclassesphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-members/admin/bp-members-classes.php (8135 => 8136)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-members/admin/bp-members-classes.php 2014-03-14 01:12:13 UTC (rev 8135)
+++ trunk/bp-members/admin/bp-members-classes.php 2014-03-15 10:54:27 UTC (rev 8136)
</span><span class="lines">@@ -99,7 +99,7 @@
</span><span class="cx">
</span><span class="cx"> // Remove the 'current' class from the 'All' link
</span><span class="cx"> $views['all'] = str_replace( 'class="current"', '', $views['all'] );
</span><del>- $views['registered'] = '<a href="' . add_query_arg( 'page', 'bp-signups', bp_get_admin_url( 'users.php' ) ) . '" class="current">' . sprintf( _nx( 'Pending account <span class="count">(%s)</span>', 'Pending accounts <span class="count">(%s)</span>', $this->signup_counts, 'signup users', 'buddypress' ), number_format_i18n( $this->signup_counts ) ) . '</a>';
</del><ins>+ $views['registered'] = '<a href="' . add_query_arg( 'page', 'bp-signups', bp_get_admin_url( 'users.php' ) ) . '" class="current">' . sprintf( _x( 'Pending <span class="count">(%s)</span>', 'signup users', 'buddypress' ), number_format_i18n( $this->signup_counts ) ) . '</a>';
</ins><span class="cx">
</span><span class="cx"> return $views;
</span><span class="cx"> }
</span><span class="lines">@@ -414,7 +414,7 @@
</span><span class="cx"> $views['all'] = str_replace( 'class="current"', '', $views['all'] );
</span><span class="cx"> $class = ' class="current"';
</span><span class="cx">
</span><del>- $views['registered'] = '<a href="' . add_query_arg( 'page', 'bp-signups', bp_get_admin_url( 'users.php' ) ) . '" class="current">' . sprintf( _nx( 'Pending account <span class="count">(%s)</span>', 'Pending accounts <span class="count">(%s)</span>', $this->signup_counts, 'signup users', 'buddypress' ), number_format_i18n( $this->signup_counts ) ) . '</a>';
</del><ins>+ $views['registered'] = '<a href="' . add_query_arg( 'page', 'bp-signups', bp_get_admin_url( 'users.php' ) ) . '" class="current">' . sprintf( _x( 'Pending <span class="count">(%s)</span>', 'signup users', 'buddypress' ), number_format_i18n( $this->signup_counts ) ) . '</a>';
</ins><span class="cx">
</span><span class="cx"> return $views;
</span><span class="cx"> }
</span></span></pre></div>
<a id="trunkbpmembersbpmembersadminphp"></a>
<div class="modfile"><h4>Modified: trunk/bp-members/bp-members-admin.php (8135 => 8136)</h4>
<pre class="diff"><span>
<span class="info">--- trunk/bp-members/bp-members-admin.php 2014-03-14 01:12:13 UTC (rev 8135)
+++ trunk/bp-members/bp-members-admin.php 2014-03-15 10:54:27 UTC (rev 8136)
</span><span class="lines">@@ -202,14 +202,15 @@
</span><span class="cx"> $this->screen_id = array( $edit_page, $this->user_page );
</span><span class="cx">
</span><span class="cx"> foreach ( $hooks as $key => $hook ) {
</span><del>- add_action( "admin_head-$hook", array( $this, 'modify_admin_menu_highlight' ) );
</del><span class="cx"> add_action( "load-$hook", array( $this, $key . '_admin_load' ) );
</span><span class="cx"> }
</span><span class="cx">
</span><ins>+ add_action( "admin_head-$this->user_page", array( $this, 'modify_admin_menu_highlight' ) );
+
</ins><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> /**
</span><del>- * Highlight the Users menu if on Edit Profile or Signups pages.
</del><ins>+ * Highlight the Users menu if on Edit Profile.
</ins><span class="cx"> *
</span><span class="cx"> * @access public
</span><span class="cx"> * @since BuddyPress (2.0.0)
</span><span class="lines">@@ -218,16 +219,16 @@
</span><span class="cx"> global $plugin_page, $submenu_file;
</span><span class="cx">
</span><span class="cx"> // Only Show the All users menu
</span><del>- if ( in_array( $plugin_page, array( 'bp-profile-edit', 'bp-signups' ) ) ) {
</del><ins>+ if ( $plugin_page = 'bp-profile-edit' ) {
</ins><span class="cx"> $submenu_file = 'users.php';
</span><span class="cx"> }
</span><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> /**
</span><del>- * Remove the Edit Profile & Signups submenu page.
</del><ins>+ * Remove the Edit Profile page.
</ins><span class="cx"> *
</span><span class="cx"> * We add these pages in order to integrate with WP's Users panel, but
</span><del>- * we want them to show up as Views of the WP panel, not as separate
</del><ins>+ * we want them to show up as a row action of the WP panel, not as separate
</ins><span class="cx"> * subnav items under the Users menu.
</span><span class="cx"> *
</span><span class="cx"> * @access public
</span><span class="lines">@@ -236,9 +237,6 @@
</span><span class="cx"> public function admin_head() {
</span><span class="cx"> // Remove submenu to force using Profile Navigation
</span><span class="cx"> remove_submenu_page( 'users.php', 'bp-profile-edit' );
</span><del>-
- // Remove submenu to force using users views
- remove_submenu_page( 'users.php', 'bp-signups' );
</del><span class="cx"> }
</span><span class="cx">
</span><span class="cx"> /** Community Profile ************************************************/
</span><span class="lines">@@ -807,7 +805,7 @@
</span><span class="cx"> $class = ' class="current"';
</span><span class="cx"> }
</span><span class="cx">
</span><del>- $views['registered'] = '<a href="' . add_query_arg( 'page', 'bp-signups', bp_get_admin_url( 'users.php' ) ) . '"' . $class . '>' . sprintf( _nx( 'Pending <span class="count">(%s)</span>', 'Pending <span class="count">(%s)</span>', $signups, 'signup users', 'buddypress' ), number_format_i18n( $signups ) ) . '</a>';
</del><ins>+ $views['registered'] = '<a href="' . add_query_arg( 'page', 'bp-signups', bp_get_admin_url( 'users.php' ) ) . '"' . $class . '>' . sprintf( _x( 'Pending <span class="count">(%s)</span>', 'signup users', 'buddypress' ), number_format_i18n( $signups ) ) . '</a>';
</ins><span class="cx">
</span><span class="cx"> return $views;
</span><span class="cx"> }
</span></span></pre>
</div>
</div>
</body>
</html>